From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A30F0C63697 for ; Sat, 28 Nov 2020 07:42:52 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 355DE22274 for ; Sat, 28 Nov 2020 07:42:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="3f+B1jA2"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="eCQ0W7dX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 355DE22274 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4FZNCqoRiYON9cPMiyonsRI4FoUQNiJPm73XGwd39ZY=; b=3f+B1jA2Qe6s05QIxWWqKoW6f bWLcfFOWUqL42ULVtGS9iTjj3iObAKj9nIMOGd0AnLVo3FKOWrXPp6esG3Tz+z0vbbEaUc7MAKZmD cT4/8ejeozeNLycyLvm1gsqgapTn2DkymlyBL9CXGgGBaD0Vukl2ydO+tja5F3gAK7/iG2V4VFPfx oPo1IXfTFqCAX835OX3P4kb7xCfHSMbvq1JlX/LL8JuDHjkn6UYt1LR2i6VPxuHPJLLimS28/0JML VO66Q+nsf/UmFPxRyX6WX+oMI+89usEaXtwSZka9u8E9k/MVaVkzo+BIMNu5psEFaI4qH0xqeN7wu toKNwwCIQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiurF-0005fV-65; Sat, 28 Nov 2020 07:41:25 +0000 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiur9-0005dp-Jn for linux-arm-kernel@lists.infradead.org; Sat, 28 Nov 2020 07:41:20 +0000 Received: by mail-pf1-x444.google.com with SMTP id 131so6404675pfb.9 for ; Fri, 27 Nov 2020 23:41:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=fiEKNoVjJnJUXQv73omVO0kLfIW0bUY/61VADsZy/nI=; b=eCQ0W7dX01bjSdwiLwo7VSutmcdYA/WYg3R59Lfh59MLvgAH/uwC57Mo8greSAjQNJ UAoWAmpfzgaj1GGBVwT7h4SWMMCecfYjtSOEcQJIKzsh5zh1LM3JeddqT4hdLz1zysPg Idi5pK98gJPgMM5coEZUhDa3SeGLuCZrQTblcgWjDRIQnWZ9kvHL4VU+YP0IjoeiZ9+E B+UCkS0JZsaaQbvM9jS9hsbfFj9ePjdry1IJZR6fLR73itjC4uzvOzOiIygHWrzoIxtx xFP4hdNY7szqbxnTbgL2AQxjI5Gw347yRVhcfQk4bN9iboCZtaZA0GixTmS9qFZCUV8n xqxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fiEKNoVjJnJUXQv73omVO0kLfIW0bUY/61VADsZy/nI=; b=aZTAmsRBGFJ8XXhQg6S8h/u/amoHrTchohEkJ+I/AL7sZjODjoOEmq6d8jWJDPO+I6 kR5QmlrVUr1arDR5cA1UXAtIsMaEXFLyr+jcYk9h4dG/ZcGeekTTNSpvPLa9ourv0KfA +8l2vEHua0+yNfarrZ9tj2CuYZ8KzVG/BvwzgJRUPa1QZCRtVddTi34QHk3SmZnkz6ea O+2uc3t50yMQK+XM7/HqDlEdtaIYKlAlave10Fe4o9CYEuGUhL9Q2nvxw8ZVl15xeMHn UqDy5dK0SfV8Kk/Fnmr//gf2Q8TvESB0JZBjZJMpRsXiGWsRBFnNHpGhdgQegyQdn4W5 I2Nw== X-Gm-Message-State: AOAM533W6cERWrlWet4CBp/AMXezLboKIzPJPbhmDu9gqDbJOu8cN4SD LQsdL9uTNi7F2aqF9VST8KT4 X-Google-Smtp-Source: ABdhPJxqoZkRUVBdrARTuHH8eLsvzZgH4wa3wX3gt6FUglxdnv4nZr8gqiEHGuGnl5adYem9WJFv+Q== X-Received: by 2002:a17:90b:438a:: with SMTP id in10mr14303785pjb.27.1606549277113; Fri, 27 Nov 2020 23:41:17 -0800 (PST) Received: from thinkpad ([2409:4072:15:c612:48ab:f1cc:6b16:2820]) by smtp.gmail.com with ESMTPSA id e23sm9700492pfd.64.2020.11.27.23.41.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Nov 2020 23:41:16 -0800 (PST) Date: Sat, 28 Nov 2020 13:11:08 +0530 From: Manivannan Sadhasivam To: Cristian Ciocaltea Subject: Re: [PATCH v2 17/18] arm: dts: owl-s500-roseapplepi: Add I2C pinctrl configuration Message-ID: <20201128074108.GD3077@thinkpad> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201128_024119_867708_AFCDD965 X-CRM114-Status: GOOD ( 17.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, Rob Herring , Andreas =?iso-8859-1?Q?F=E4rber?= , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 20, 2020 at 01:56:11AM +0200, Cristian Ciocaltea wrote: > Add pinctrl definitions for the I2C controllers used in RoseapplePi SBC. > For the moment enable only I2C0, which is used by the ATC2603C PMIC. > > Signed-off-by: Cristian Ciocaltea Earlier we used to add "_default" suffix for the pin groups to differentiate between active and sleep states. But I guess we can just keep the suffix away until we hit usecase. Reviewed-by: Manivannan Sadhasivam Thanks, Mani > --- > arch/arm/boot/dts/owl-s500-roseapplepi.dts | 44 ++++++++++++++++++++++ > 1 file changed, 44 insertions(+) > > diff --git a/arch/arm/boot/dts/owl-s500-roseapplepi.dts b/arch/arm/boot/dts/owl-s500-roseapplepi.dts > index fe9ae3619422..ff91561ca99c 100644 > --- a/arch/arm/boot/dts/owl-s500-roseapplepi.dts > +++ b/arch/arm/boot/dts/owl-s500-roseapplepi.dts > @@ -37,7 +37,51 @@ sd_vcc: sd-vcc { > }; > }; > > +&i2c0 { > + status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c0_pins>; > +}; > + > +&i2c1 { > + status = "disabled"; > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c1_pins>; > +}; > + > +&i2c2 { > + status = "disabled"; > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c2_pins>; > +}; > + > &pinctrl { > + i2c0_pins: i2c0-pins { > + pinmux { > + groups = "i2c0_mfp"; > + function = "i2c0"; > + }; > + > + pinconf { > + pins = "i2c0_sclk", "i2c0_sdata"; > + bias-pull-up; > + }; > + }; > + > + i2c1_pins: i2c1-pins { > + pinconf { > + pins = "i2c1_sclk", "i2c1_sdata"; > + bias-pull-up; > + }; > + }; > + > + i2c2_pins: i2c2-pins { > + pinconf { > + pins = "i2c2_sclk", "i2c2_sdata"; > + bias-pull-up; > + }; > + }; > + > mmc0_pins: mmc0-pins { > pinmux { > groups = "sd0_d0_mfp", "sd0_d1_mfp", "sd0_d2_d3_mfp", > -- > 2.29.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel