From: Nishanth Menon <nm@ti.com>
To: Sekhar Nori <nsekhar@ti.com>
Cc: Tero Kristo <t-kristo@ti.com>,
Device Tree Mailing List <devicetree@vger.kernel.org>,
Faiz Abbas <faiz_abbas@ti.com>,
Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v2 2/2] arm64: dts: ti: k3-j721e-common-proc-board: Add support SD card UHS modes
Date: Sat, 28 Nov 2020 10:41:46 -0600 [thread overview]
Message-ID: <20201128164146.53zz4vfg7jg2nppf@refinance> (raw)
In-Reply-To: <20201127201024.64836-3-nsekhar@ti.com>
On 01:40-20201128, Sekhar Nori wrote:
[...]
> - main_usbss0_pins_default: main-usbss0-pins-default {
> + vdd_sd_dv_alt_pins_default: vdd_sd_dv_alt_pins_default {
> + pinctrl-single,pins = <
> + J721E_IOPAD(0x1d8, PIN_INPUT, 7) /* (W4) SPI1_CS1.GPIO0_117 */
> + >;
> + };
> +
> + main_usbss0_pins_default: main_usbss0_pins_default {
Could you not switch the node name to _ ? We just fixed that
bunch. Now, this patch introduces the following with W=2:
arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts: /bus@100000/pinctrl@11c000/vdd_sd_dv_alt_pins_default: Character '_' not recommended in node name
arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts: /bus@100000/pinctrl@11c000/main_usbss0_pins_default: Character '_' not recommended in node name
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-11-28 16:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 20:10 [PATCH v2 0/2] arm64: dts: ti: k3-j721e: MMC/SD higher speed modes support Sekhar Nori
2020-11-27 20:10 ` [PATCH v2 1/2] arm64: dts: ti: k3-j721e-main: Add output tap delay values Sekhar Nori
2020-11-27 20:10 ` [PATCH v2 2/2] arm64: dts: ti: k3-j721e-common-proc-board: Add support SD card UHS modes Sekhar Nori
2020-11-28 16:41 ` Nishanth Menon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201128164146.53zz4vfg7jg2nppf@refinance \
--to=nm@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=faiz_abbas@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=nsekhar@ti.com \
--cc=robh+dt@kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox