From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C506DC3E8C5 for ; Sun, 29 Nov 2020 18:26:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 66DFB206CA for ; Sun, 29 Nov 2020 18:26:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aeY4yNLK"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bh0AQJXB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 66DFB206CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XpsnwlIGn8ROtWkqKvxUrHxE4oAtUB+Tpu2SLDvgl64=; b=aeY4yNLKZdFlZsJ7wjTv4wp3K zKvJJ6wpn5P05ahikNClvfeGmE3bhi4t8h2cQeK4Z4sfLltXAu7sqChTzRDvD49gXLI6dqCYxNTsz MMCngBCq66O91pW85KyI1rF3NcAZthS90ZlFLluCFqo97XPo506aEbo+WBPhWqvfN+w0K1+bO9ypn Yi9e7Fbb/lkczAshUxvElwVJsr3vXNSZhOGZoQdfiVkysbQcgHgylCvjsb0ArheBPCBajdrPrQAjZ CmjPJzbOoBsYd0SUH00UOwmCopgRaMjdLVrHSy29hu26dHfnP+47S4Ub4ZY7PXzAvUzTg+Pq29pS5 ERpaX3ZFQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjRNC-0008LO-QS; Sun, 29 Nov 2020 18:24:34 +0000 Received: from mail-ed1-x542.google.com ([2a00:1450:4864:20::542]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjRN3-0008JA-E3; Sun, 29 Nov 2020 18:24:29 +0000 Received: by mail-ed1-x542.google.com with SMTP id b2so39548edy.13; Sun, 29 Nov 2020 10:24:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+TaHdEkXgCN7CkQQ251SzNfRN/Dkm6ksvaE3LxK1LzI=; b=bh0AQJXBSiA1fclqsj04XWp10nlZW3rQzm2mlHEK+u9ZlMBldHI9IV7PXYBkyWVb7h 2i8/H4EIcd3GCzU0Xo0NvEOzlGFd5FJWC20SDHDmRDrNenCO0l6RduZ5gOASwPfiVn30 29C8bGSIO5XiXfvMRfS2wtXww+KVY4sPRvIOeQW/pfsY+o+6MvQ2XyhF8WhLY9dt6316 FCv3yjyNFu7q8iPE5Ax0nDU+3whXo+72UE8c8jlIBbCVz85I9Xvl7r7gNqh0oJ5kCVVJ 8TeOuVoZgT3kzDTMOCcUFdjgtTVqjAY1VuvVunwOEj54AdzPzA6ei1EBR1Eu3MDQOjVE htaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+TaHdEkXgCN7CkQQ251SzNfRN/Dkm6ksvaE3LxK1LzI=; b=RbUqwCTDJvioHyl3Pax8xjf/Uar0Mwhjguu4t5G6bVyIE6I6cbg2L1BdGqM50qIbTu Q6EaVr9+t9J4S4IGnLtuyl8fx+jFGl379vxCqSm+BbywRrDcO0/I/FUXSQyyA8/JMEyG OZCjY+hx3GcoFUvImjA24SbGbLjUnsk+Wugky+y7+P4JiIlMBR+GVM4XhS4UF5ndm574 ivWOoKXMVbKxHX7ZO7e2MB5atmcy73l2PV00C8sj3wE+Rn2Q07xQUhmFvOrx0bgvONHF 0M5NbqTI9sOeVeHSKmOSUBV/Wb8mn6pufzS2Aq74WNTa2IvYAQ8rDIxlYeoX9RK2cdPk DtzQ== X-Gm-Message-State: AOAM5315BiRg4A/PCOrw2UFRRCxAK/BU6a4cvcy7GfNuXn+tlRletupI tnyOvHTjRoCenJM1+oh2BXA= X-Google-Smtp-Source: ABdhPJzQPimJ/g3YVN+L+ev4PqPO1ywE7NRbKa2WC+6fa6XWlkqPDvydKX8AsN3kFf0HE0y8mTOyJQ== X-Received: by 2002:a50:f082:: with SMTP id v2mr12973840edl.276.1606674264456; Sun, 29 Nov 2020 10:24:24 -0800 (PST) Received: from BV030612LT ([188.24.159.61]) by smtp.gmail.com with ESMTPSA id s15sm8145744edj.75.2020.11.29.10.24.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Nov 2020 10:24:23 -0800 (PST) Date: Sun, 29 Nov 2020 20:24:21 +0200 From: Cristian Ciocaltea To: Manivannan Sadhasivam Subject: Re: [PATCH v2 05/18] dmaengine: owl: Add compatible for the Actions Semi S500 DMA controller Message-ID: <20201129182421.GD696261@BV030612LT> References: <20201128073045.GU3077@thinkpad> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201128073045.GU3077@thinkpad> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201129_132425_587140_F491A020 X-CRM114-Status: GOOD ( 20.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, Vinod Koul , Rob Herring , dmaengine@vger.kernel.org, Dan Williams , Andreas =?iso-8859-1?Q?F=E4rber?= , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Nov 28, 2020 at 01:00:45PM +0530, Manivannan Sadhasivam wrote: > On Fri, Nov 20, 2020 at 01:55:59AM +0200, Cristian Ciocaltea wrote: > > The DMA controller present on the Actions Semi S500 SoC is compatible > > with the S900 variant, so add it to the list of devices supported by > > the Actions Semi Owl DMA driver. > > > > Signed-off-by: Cristian Ciocaltea > > I hope that you have verified both Memcpy and Slave transfers... I have been using 'dmatest' module as documented in: https://www.kernel.org/doc/html/latest/driver-api/dmaengine/dmatest.html I tested all the available channels and could not find any signs of possible issues. Bellow is an excerpt from the kernel ring buffer: [ 2661.884680] dmatest: dma0chan1-copy0: summary 300 tests, 0 failures 1653.48 iops 13249 KB/s (0) [ 2661.886567] dmatest: dma0chan2-copy0: summary 300 tests, 0 failures 1684.40 iops 12846 KB/s (0) [ 2661.888448] dmatest: dma0chan3-copy0: summary 300 tests, 0 failures 1730.62 iops 13648 KB/s (0) Should I perform some additional tests? Thanks, Cristi > Reviewed-by: Manivannan Sadhasivam > > Thanks, > Mani > > > --- > > drivers/dma/owl-dma.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/dma/owl-dma.c b/drivers/dma/owl-dma.c > > index 9fede32641e9..54e509de66e2 100644 > > --- a/drivers/dma/owl-dma.c > > +++ b/drivers/dma/owl-dma.c > > @@ -1082,6 +1082,7 @@ static struct dma_chan *owl_dma_of_xlate(struct of_phandle_args *dma_spec, > > static const struct of_device_id owl_dma_match[] = { > > { .compatible = "actions,s900-dma", .data = (void *)S900_DMA,}, > > { .compatible = "actions,s700-dma", .data = (void *)S700_DMA,}, > > + { .compatible = "actions,s500-dma", .data = (void *)S900_DMA,}, > > { /* sentinel */ }, > > }; > > MODULE_DEVICE_TABLE(of, owl_dma_match); > > -- > > 2.29.2 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel