From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 993B3C64E7B for ; Mon, 30 Nov 2020 13:55:00 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 13A4B2067D for ; Mon, 30 Nov 2020 13:55:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="m0LOhEyg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 13A4B2067D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NkWtPqB3kNQbTDjznXhOiMRczMOc0qGvmE8w8lCqkrE=; b=m0LOhEygoK4fdkFUkNobfiLqQ Tf9FjDcwQT6UKbiqzCn0hdihmUSfRSItlbeObmE4Gq+Pf+2J4XfoSoXwUSTRGgpBiXnEYVo6M4LcJ P2tPNxtG/bMPGuANNYS0d6yhbXA2gko5f9a2azC3SJi2qRfJLcbc5wAGJ4pgF7RXThTdMw+FEiRll +7CBKdxu+kvXn97v/Chgy4RDN9lXqx6EbX5aW6Cmbga5xW2ZMqbcVztdWnIteVjozAdzkYiYMcqt8 FhSnf2v6caittTGvsvF+Bj2qAG8elsEhJNYqfO+6XczAEt0gMhpj7K5tyyhMR1EcYmpvaGXDo00Xp GjnbV+Jrg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjjcg-0007dc-Ks; Mon, 30 Nov 2020 13:53:46 +0000 Received: from mga05.intel.com ([192.55.52.43]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjjce-0007bp-MZ for linux-arm-kernel@lists.infradead.org; Mon, 30 Nov 2020 13:53:45 +0000 IronPort-SDR: aJq/AurZjL/vgRj95Awij26yaHAn6UG8vLx9wvUKLHV3mUQl+TiIroUEhbSJRuP71NwuffakhV s4zZmpeyzbjw== X-IronPort-AV: E=McAfee;i="6000,8403,9820"; a="257343385" X-IronPort-AV: E=Sophos;i="5.78,381,1599548400"; d="scan'208";a="257343385" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2020 05:53:38 -0800 IronPort-SDR: Ao8RXvPmDEAz0Ds/itDE6rFJeK3ffp0ww976qNBmYThfMVH9nOR0jPRlWneQX1FQMxXiWm79uV B4d8NxJ8kEEQ== X-IronPort-AV: E=Sophos;i="5.78,381,1599548400"; d="scan'208";a="549105746" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2020 05:53:35 -0800 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id 58269208FD; Mon, 30 Nov 2020 15:53:31 +0200 (EET) Date: Mon, 30 Nov 2020 15:53:31 +0200 From: Sakari Ailus To: Paul Kocialkowski Subject: Re: [PATCH v4 2/2] media: i2c: Add support for the OV5648 image sensor Message-ID: <20201130135331.GW3940@paasikivi.fi.intel.com> References: <20201128143350.531460-1-paul.kocialkowski@bootlin.com> <20201128143350.531460-3-paul.kocialkowski@bootlin.com> <20201130092802.GU3940@paasikivi.fi.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201130_085344_867486_952464DE X-CRM114-Status: GOOD ( 20.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Maxime Ripard , Hans Verkuil , Rob Herring , Thomas Petazzoni , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Paul, On Mon, Nov 30, 2020 at 02:48:04PM +0100, Paul Kocialkowski wrote: > Hi Sakari, > > On Mon 30 Nov 20, 11:28, Sakari Ailus wrote: > > Hi Paul, > > > > Thanks for the update. I have a few comments on the driver, too. > > Thanks for the review! > > [...] > > > > + ret = ov5648_write(sensor, OV5648_GAIN_BLUE_MAN_L_REG, > > > + OV5648_GAIN_BLUE_MAN_L(blue_balance)); > > > > return ... > > > > Same below (and above). > > Well I don't think that makes any functional difference, right? > My personal preference is to have explicit checks even at the end of functions > for symetry and alignment with other blocks. > > If it's okay, it'd like to keep it as-is. But if that's against kernel coding > style guidelines, I won't argue more. Please do change them. It's useless code, repeated at the end of a number of functions in this driver. I wouldn't mind otherwise, but people do take examples from existing drivers so such patterns tend to repeat in other places. -- Regards, Sakari Ailus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel