From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EFFEC64E8A for ; Mon, 30 Nov 2020 20:22:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 24DE12073C for ; Mon, 30 Nov 2020 20:22:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CApJ1mBh"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="hqFZh5fJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 24DE12073C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VVON+JBRmukaU1zvZA3ZZGbAVJIBvkkNsXnuae0ZEfU=; b=CApJ1mBhz4q+gIz8UuRxOjW+Q EtA+tzI1OWvanfE0PytyG0SI2rda1n3VtvpYAYOWUQ4gZax1ERi0gfbH7rQqa5mtwbDiwOGkFv8St UyYicsyI9IRVUDVrcs6sgVc6qXw6T1Dhrs+/rLfmbq278YCF18hCsNQ59ikHURO0jP3SMjEDNwJAi voAPiVnrjfi0aYOA9DDOEsXT+1yL1wB6H97+87/KsaUjOQzoYgS4ieIuBurHt/3W/i9g63qxYiKhh RuIJvWTy6yCcFf8a1tR8XWHAMCCm3DUcJhIXO7lRQHfIWbQyrLQMFnItvACQWOTErGukb3te1E0nD Gu5V0uL4g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjpfl-0006jL-1p; Mon, 30 Nov 2020 20:21:21 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjpfh-0006iB-Nz for linux-arm-kernel@lists.infradead.org; Mon, 30 Nov 2020 20:21:18 +0000 Received: from archlinux (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6197B2073C; Mon, 30 Nov 2020 20:21:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606767676; bh=3vBda+pxIcoAiOM7rrSvH/AB34KT1Bwlkb2BskN4kv0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hqFZh5fJSGpKMENMR3RzKM3trL2jgcZyPhOo7LsmmYPuN98YT28DK+3UOnaR6LB+w /gmeei9bASpcrllTWe4fElIm22Uz0Oi7p0dLfCYDt9Jgdrtph6mU7PTZW1LazbDKkS 0ebg14kd2//yhhitOhFMn3cYNcTDsYP+tavBOM/g= Date: Mon, 30 Nov 2020 20:21:10 +0000 From: Jonathan Cameron To: Bartosz Golaszewski Subject: Re: [PATH v3 0/3] iio: adc: xilinx: use even more devres Message-ID: <20201130202110.62e7f989@archlinux> In-Reply-To: <20201130142759.28216-1-brgl@bgdev.pl> References: <20201130142759.28216-1-brgl@bgdev.pl> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201130_152117_874916_F97A36F7 X-CRM114-Status: GOOD ( 17.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lars-Peter Clausen , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Michal Simek , Anand Ashok Dumbre , Bartosz Golaszewski , Peter Meerwald-Stadler , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 30 Nov 2020 15:27:56 +0100 Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > This is a follow-up to commit 750628c79bb1 ("iio: adc: xilinx-xadc: use > devm_krealloc()"). I noticed we can use even more devres helpers and entirely > drop the remove() callback. > > v1 -> v2: > - squash three patches adding more devres calls into one for easier review > - don't insist on the 80 characters limit > - add a new helper: devm_krealloc_array() and use it > > v2 -> v3: > - drop the devm_krealloc_array() helper > > Bartosz Golaszewski (3): > iio: adc: xilinx: use helper variable for &pdev->dev > iio: adc: xilinx: use devm_krealloc() instead of kfree() + kcalloc() > iio: adc: xilinx: use more devres helpers and remove remove() > > drivers/iio/adc/xilinx-xadc-core.c | 157 ++++++++++++++--------------- > 1 file changed, 74 insertions(+), 83 deletions(-) > Series looks good to me but would like to leave it a little longer to let others take a look at it. That will probably mean it falls into next cycle now. +CC Anand who is looking at another series touching this driver and might give this one a spin as well. Thanks, Jonathan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel