From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EBDCC63777 for ; Mon, 30 Nov 2020 21:58:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C1FCA2084C for ; Mon, 30 Nov 2020 21:58:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CAyj768K" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C1FCA2084C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ib4fR+AUyP9HtpnXSz2attjdabTUPYqFON50e2gjpoI=; b=CAyj768K2osk3B/DbjbDFNNrO MBoX3x/SsCO6pqyvHWJkwSMsNtBdAa9/V7u5Jne5Eib8fw4Yrr8QfB/bPBWD4a/W8Z2aZP0/vP51l hrhG50EAT6f03gucEuclPT2peOXTeqcaWAxvNJUZomDBdcItIxkeQMVLY2CRsRU5s6NuVg/1ul0RH GfBYRIeDZnWG1cTCXT0MblrQXXqjuWZ+uCzGUo2SIXJ1c9gzw+6epJSsRxtdySHmJW5gp04PytL01 iioJErVwa1kZ9Yynp7G1V7sUQSgK15aMatveNaJZgOKb6oXwMXYEVoNcajNjPswL4cI3sw+NKY83j 1TK76TYbg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjrAm-0001JL-9B; Mon, 30 Nov 2020 21:57:28 +0000 Received: from mail-il1-f193.google.com ([209.85.166.193]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjrAj-0001Ie-DE for linux-arm-kernel@lists.infradead.org; Mon, 30 Nov 2020 21:57:26 +0000 Received: by mail-il1-f193.google.com with SMTP id f5so12859580ilj.9 for ; Mon, 30 Nov 2020 13:57:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Q/HzlOoNpMld/PKw4A/VNclXjAqEao2yRcGSeU0Y00A=; b=ehS5JP4AoyGb/QjKLN/uuR9rPow2bfnDAeTO2waOx2Eej8PsEesZAccFHS3C63o2bZ AbvjjAqs3glchHbi1bR0E0RINq5esEbEMjanmR9DSb9xCOH85SEvziebw2v3MLN7vGDh GBtlU4k9IpE4Cl1j3zlLFwhHfsJIikoO87vPvDbCpqEdLr+a/iQBqL1EPohQ9ORjL+5A Eg+u544HnTWP02ahgjFnmhtJEmEUNLpF5BSzZ1nNHCXCOsS6wsnfbEk6C2gC+SQ+HoMd FLnzuvJ1B+89+j8Tnx/4Z50uQ/BvLN9+P97A2fRRxAHPLizFAy8YVKEi0dz3PM7ugx8f KEvQ== X-Gm-Message-State: AOAM5308QfGC/O8sNDuQSr49sHXN+QnmVkcpoO20pu/I2rv9WTRo05KM 6tM1DaWMF9Yc5fOVQwgyGQ== X-Google-Smtp-Source: ABdhPJz63mwCftctBFHW1rb/euu8T+n1MpOhxShPnfXCX61MPx0puzzfFTGGCozE9bo4dgq1Q6HtMw== X-Received: by 2002:a05:6e02:168c:: with SMTP id f12mr10637919ila.105.1606773444789; Mon, 30 Nov 2020 13:57:24 -0800 (PST) Received: from xps15 ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id m19sm11143329ila.81.2020.11.30.13.57.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Nov 2020 13:57:23 -0800 (PST) Received: (nullmailer pid 3101256 invoked by uid 1000); Mon, 30 Nov 2020 21:57:21 -0000 Date: Mon, 30 Nov 2020 14:57:21 -0700 From: Rob Herring To: Alice Guo Subject: Re: [PATCH v6 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID Message-ID: <20201130215721.GA3090303@robh.at.kernel.org> References: <20201124015949.29262-1-alice.guo@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201124015949.29262-1-alice.guo@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201130_165725_522687_153E0D3E X-CRM114-Status: GOOD ( 21.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, peng.fan@nxp.com, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, krzk@kernel.org, linux-imx@nxp.com, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 24, 2020 at 09:59:46AM +0800, Alice Guo wrote: > Add DT Binding doc for the Unique ID of i.MX 8M series. > > Signed-off-by: Alice Guo > --- > > v2: remove the subject prefix "LF-2571-1" > v3: put it into Documentation/devicetree/bindings/arm/fsl.yaml No, I prefer this be a separate schema file and not clutter board/soc schemas with child nodes. > modify the description of nvmem-cells > use "make ARCH=arm64 dtbs_check" to test it and fix errors > v4: use allOf to limit new version DTS files for i.MX8M to include > "fsl,imx8mm/n/p/q-soc", nvmem-cells and nvmem-cells-names > v5: correct the error of using allOf > v6: none > > .../devicetree/bindings/arm/fsl.yaml | 47 +++++++++++++++++++ > 1 file changed, 47 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > index 67980dcef66d..7132ffd41abb 100644 > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > @@ -918,6 +918,53 @@ properties: > - fsl,s32v234-evb # S32V234-EVB2 Customer Evaluation Board > - const: fsl,s32v234 > > + soc: > + type: object > + properties: > + compatible: > + oneOf: > + - description: new version compatible for i.MX8M SoCs > + items: > + - enum: > + - fsl,imx8mm-soc > + - fsl,imx8mn-soc > + - fsl,imx8mp-soc > + - fsl,imx8mq-soc > + - const: simple-bus > + > + - description: old version compatible for i.MX8M SoCs > + items: > + - const: simple-bus Fix your dts files and drop this. > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - fsl,imx8mm > + - fsl,imx8mn > + - fsl,imx8mp > + - fsl,imx8mq > + > + then: > + patternProperties: > + "^soc@[0-9a-f]+$": And this is just wrong. First you say the node is 'soc' and then here it has a unit address. > + properties: > + compatible: > + items: > + - enum: > + - fsl,imx8mm-soc > + - fsl,imx8mn-soc > + - fsl,imx8mp-soc > + - fsl,imx8mq-soc > + - const: simple-bus > + > + required: > + - compatible > + - nvmem-cells > + - nvmem-cell-names > + > additionalProperties: true > > ... > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel