From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C858C64E7A for ; Tue, 1 Dec 2020 10:01:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 78527204FD for ; Tue, 1 Dec 2020 10:01:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="z1hdAyJ+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 78527204FD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RD/k7e7Hyz59gKFW0zrefGOK1xVwzVImn9doukKjKf8=; b=z1hdAyJ+fLGHAkXus7+9Qto4c yd9WRLdsO+TA0BBsP365wgmGEp/fchG6fd+OhNvJyT4pxqn8uOU4bTEuOCe/jx/P3iWqjLCJfTN2s 34jJ1QT21G3EEEIzjB6Rbs3tM4/YL4QbpJhdS+6euy8VL0giBfatwO6S/DYrfjo0CoqmN92598Ytv 12tAgksR/Neg+oykPrBAjDk7graKjM54+VE3O6GSyCq3I71Y5Andtg/Wi8lmY4doqA/Ghrw586wmq KgYhGfVAc42IUyv9DczzSc8If88D2a8cHaRI36vCEGb8nrTeU2mi3JR8tX0lQAtgoNE8xrzk7LduN 4gpD1JTAg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kk2Rg-0001Y9-6v; Tue, 01 Dec 2020 09:59:40 +0000 Received: from asavdk3.altibox.net ([109.247.116.14]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kk2Re-0001XA-0R; Tue, 01 Dec 2020 09:59:38 +0000 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id D17CC2001E; Tue, 1 Dec 2020 10:59:31 +0100 (CET) Date: Tue, 1 Dec 2020 10:59:30 +0100 From: Sam Ravnborg To: allen Subject: Re: [PATCH v5] drm/bridge: add it6505 driver Message-ID: <20201201095930.GA1981628@ravnborg.org> References: <20201201054454.51240-1-allen.chen@ite.com.tw> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201201054454.51240-1-allen.chen@ite.com.tw> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=Ibmpp1ia c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=Ns9eNvu6AAAA:8 a=mpaa-ttXAAAA:8 a=cm27Pg_UAAAA:8 a=1XWaLZrsAAAA:8 a=qw3Jv0Z29LwRxbBwalcA:9 a=CjuIK1q_8ugA:10 a=LZLx1i01EnjtqRv10NxV:22 a=6heAxKwa5pAsJatQ0mat:22 a=xmb-EsYY8bH0VWELuYED:22 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201201_045938_180279_CB3D2B82 X-CRM114-Status: GOOD ( 14.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kenneth Hung , Jitao Shi , Neil Armstrong , Yilun Lin , Jau-Chih Tseng , Jernej Skrabec , "open list:DRM DRIVERS" , open list , Andrzej Hajda , David Airlie , Hermes Wu , "moderated list:ARM/Mediatek SoC support" , Laurent Pinchart , Pi-Hsun Shih , Matthias Brugger , "moderated list:ARM/Mediatek SoC support" , Jonas Karlman Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Allen. On Tue, Dec 01, 2020 at 01:44:41PM +0800, allen wrote: > This adds support for the iTE IT6505. > This device can convert DPI signal to DP output. > > From: Allen Chen > Signed-off-by: Jitao Shi > Signed-off-by: Pi-Hsun Shih > Signed-off-by: Yilun Lin > Signed-off-by: Hermes Wu > Signed-off-by: Allen Chen I recall I provided the same comment as last time, but may remember wrong. New bridge drivers shall support that connector creation is optional. This driver does not do that - see following code snippet: + if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR) { + DRM_ERROR("Fix bridge driver to make connector optional!"); + return -EINVAL; + } + I did not check, but likely the drive needs to implment some of the connector hooks too. (detect, get_edid, etc). Please include a changelog too - it can be very hard to remember what feedback was provided when one reviews several patches/week. Sam _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel