From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CEFDC64E7A for ; Tue, 1 Dec 2020 10:44:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E4EB820809 for ; Tue, 1 Dec 2020 10:44:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Vr/xE6ry"; dkim=temperror (0-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="TTSDNj5Q"; dkim=temperror (0-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="lo/pEgHK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4EB820809 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HZMQC72Gzt68ov9wckiCvZ1uHa1/ZaFOQ8N1t5+6YeM=; b=Vr/xE6ryUKiBzPxXKF9w86zIi dvOuWs+WW2EuOPiWPn859sX+JwOQOPHAJDukCpiYNVW9WKrrtxv40Ws7piuOCS8oeziYRg/PHXJ5W dQHvR2b9p37v8h6B62gC6SOWiq/DcqQc5g6DhxYD6bLHpcDhlY4Y66GvgE1jFr+a7dDq9MWRu+ErH IgL7iTTCNX3OP9LToEtpC+CgAC+ufg/bVgQmY8+at438X5GPMoU6JqZxpVxONV+SEM2WJD9tJg1lv +zRbNWZHDFM+8Tacfy67AbTvFPiVO6pdbMyLDU5Rb0YHSEbTODLgoqsUCiAd8QTvJIn8Sl7iQV2uy RgqvBdQfw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kk384-000297-Cv; Tue, 01 Dec 2020 10:43:28 +0000 Received: from new3-smtp.messagingengine.com ([66.111.4.229]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kk382-00028g-Rs for linux-arm-kernel@lists.infradead.org; Tue, 01 Dec 2020 10:43:27 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 444B558030A; Tue, 1 Dec 2020 05:43:25 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Tue, 01 Dec 2020 05:43:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=cE2/BhUuBTM/tBl05gTg+SiiGeu zIsoIfzMBf7YnS2Y=; b=TTSDNj5Qz3HwMQkFp0pu8knvWV5N4sqPq/sKHPYdf2c GbUL4xSRcIs9uDGNX96An8+73C3033lk7Bwt6sCE9SyhaJMrGHq3B6OgY9DVvLIj fHSNRpIxflg4K5fr5u8L9vNZ4zKZ1bfRkW4nPpYxOHswd1/RPBU3EfZgHNRZKqFn /QfKRLQ+ohU+uoxvDHCmZQbHIankuJd5g1DlAVEKLD92ofrbd5czoKXbFjAwQSzk kt0TJW8eNpLwYev4kBEEPSAwnm/kdf6noJcDaNcfZ6j2Hux1GFzTuU/vbfKL/L5z ertYyPmsHN9wfiWubFYKWZ5PHNnsmdLgFruRrAO9Zyw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=cE2/Bh UuBTM/tBl05gTg+SiiGeuzIsoIfzMBf7YnS2Y=; b=lo/pEgHKY7eaZMbyFdSjVg /T1tVKX4yGE+SbCd3lP+ekKyKYfmIjdb5hGTG+axT3YcPp7/DaXeVK3KTUjI8QRt lppm3VR7e8aoj4wmlmpzCZyGyIgM9+fEv5IY+Vkv/t29rTtH2A7Q/weI57CGhTV6 ImZbmxn5S4M82K0kmk++GaKdbM8GdquO7ry6oP6lE+Qw4zk9BUr0N3tuj/0LT9ID KmpERhe/ksxC3Fw1/IKWEBg60YlVWNgKsmR2kcOp9so8NOudRCkHJx+Ma0Pjr/Ti q4hT7aheDlfunj2/KOSIAPim1Vudl8hc6xy7RkThzC+RQx5NLQsx8smA33OuwaBA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudeivddgvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgepudenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 8AA12108005E; Tue, 1 Dec 2020 05:43:22 -0500 (EST) Date: Tue, 1 Dec 2020 11:43:21 +0100 From: Maxime Ripard To: Paul Kocialkowski Subject: Re: [PATCH v2 06/19] dt-bindings: media: sun6i-a31-csi: Add MIPI CSI-2 input port Message-ID: <20201201104321.rl3ujt5pjre6xlmm@gilmour> References: <20201128142839.517949-1-paul.kocialkowski@bootlin.com> <20201128142839.517949-7-paul.kocialkowski@bootlin.com> MIME-Version: 1.0 In-Reply-To: <20201128142839.517949-7-paul.kocialkowski@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201201_054326_971288_759D139C X-CRM114-Status: GOOD ( 24.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dafna Hirschfeld , linux-doc@vger.kernel.org, linux-sunxi@googlegroups.com, Thomas Petazzoni , kevin.lhopital@hotmail.com, devel@driverdev.osuosl.org, Jonathan Corbet , Kishon Vijay Abraham I , Chen-Yu Tsai , Hans Verkuil , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Sakari Ailus , Helen Koike , Rob Herring , Yong Deng , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, Jernej Skrabec , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Vinod Koul , Philipp Zabel Content-Type: multipart/mixed; boundary="===============8690424440789712433==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8690424440789712433== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lun5d3kfon2axx3z" Content-Disposition: inline --lun5d3kfon2axx3z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Nov 28, 2020 at 03:28:26PM +0100, Paul Kocialkowski wrote: > The A31 CSI controller supports two distinct input interfaces: > parallel and an external MIPI CSI-2 bridge. The parallel interface > is often connected to a set of hardware pins while the MIPI CSI-2 > bridge is an internal FIFO-ish link. As a result, these two inputs > are distinguished as two different ports. >=20 > Note that only one of the two may be present on a controller instance. > For example, the V3s has one controller dedicated to MIPI-CSI2 and one > dedicated to parallel. >=20 > Update the binding with an explicit ports node that holds two distinct > port nodes: one for parallel input and one for MIPI CSI-2. >=20 > This is backward-compatible with the single-port approach that was > previously taken for representing the parallel interface port, which > stays enumerated as fwnode port 0. However, it is now marked as > deprecated and the multi-port approach should be preferred. >=20 > Note that additional ports may be added in the future, especially to > support feeding the CSI controller's output to the ISP. >=20 > Signed-off-by: Paul Kocialkowski > --- > .../media/allwinner,sun6i-a31-csi.yaml | 86 ++++++++++++++++--- > 1 file changed, 73 insertions(+), 13 deletions(-) >=20 > diff --git a/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-= csi.yaml b/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.= yaml > index 1fd9b5532a21..3bcee2d44f3c 100644 > --- a/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml > +++ b/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml > @@ -43,6 +43,7 @@ properties: > # See ./video-interfaces.txt for details > port: > type: object > + deprecated: true I'm not sure we want to deprecate it. There's some SoCs with the same controller but without the MIPI-CSI block where this would be completely valid > properties: > endpoint: > @@ -67,6 +68,59 @@ properties: > =20 > additionalProperties: false > =20 > + ports: > + type: object > + > + properties: > + port@0: > + type: object > + description: Parallel input port, connect to a parallel sensor > + > + properties: > + reg: > + const: 0 > + > + endpoint: > + type: object > + > + properties: > + remote-endpoint: true > + > + bus-width: > + enum: [ 8, 10, 12, 16 ] > + > + pclk-sample: true > + hsync-active: true > + vsync-active: true > + > + required: > + - bus-width > + - remote-endpoint > + > + required: > + - endpoint > + > + additionalProperties: false > + > + port@1: > + type: object > + description: MIPI CSI-2 bridge input port > + > + properties: > + reg: > + const: 1 > + > + endpoint: > + type: object > + > + properties: > + remote-endpoint: true > + > + required: > + - remote-endpoint > + > + additionalProperties: false There's a schema for the OF-graph now, you'll want to use it. Maxime --lun5d3kfon2axx3z Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX8YeSQAKCRDj7w1vZxhR xYT9AP0Uber0QsvWLD/B/ipxiWtm7WnSzo8VBPN3jw6D/qe1nQEAg9cRv6wvzoR4 aKRHG2EGIYA4/0s/XpYOYyVY5HBrwwg= =udSm -----END PGP SIGNATURE----- --lun5d3kfon2axx3z-- --===============8690424440789712433== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8690424440789712433==--