From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5EDBC64E7A for ; Tue, 1 Dec 2020 11:28:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 386E820709 for ; Tue, 1 Dec 2020 11:28:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gkmCIatx"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="BojY9Lhb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 386E820709 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=alien8.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RBCVu36avzLS7HOMHYYAvTj/7/M3qX+s7zvOPobfL3A=; b=gkmCIatxeHlLvYeCkvGP0jd7o 3yrTdc8Yx+sQwNolZ3afNoKuYh3fhmDK2Q405Y//lAxaS/EVMYq4znxJuTWYLVgO73kEXPy20vstJ lmX7VXtsY5eZ+dO3KlCcsZ6qBeTpwfwCYRT/XWjBdfUg9auK1InrQfJu/j9JDForSE4cGmMifrTKA 8zvVEeXzCFBeyNR3nbOMZ97WD90VFM0Z4P2wR06vb7yCVbvg15fIOBAF1gWUdGJE0a0tAnAM/7BpS rgGCAR8O91UEzaboCVrCIfu0Xf0LvUS2mwxF2I3zxpcYyEqBTamHoRY8scV8DqWRf/+ECejYnVV6T qDLtGSo8Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kk3oB-0008BQ-Af; Tue, 01 Dec 2020 11:26:59 +0000 Received: from mail.skyhub.de ([2a01:4f8:190:11c2::b:1457]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kk3o7-0008As-SJ for linux-arm-kernel@lists.infradead.org; Tue, 01 Dec 2020 11:26:57 +0000 Received: from zn.tnic (p200300ec2f0e6a00835f506c18984427.dip0.t-ipconnect.de [IPv6:2003:ec:2f0e:6a00:835f:506c:1898:4427]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id A33A01EC03CE; Tue, 1 Dec 2020 12:26:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1606822011; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=kG05JigLq40d1naxqpJ6O+B10zBDQJXKWSq7mQrphYg=; b=BojY9LhbBSwQ8ArzVxrc7xJmMa4uIFOav+p30OL3Syx6JraGb//TATTYxZZJFIjUiez9A2 09xGNqYRskkRNf8Xc1CMYnDSWvJuTK+AxDFujk4khnAeCy1t2Vo04v1Br8C9dwrmoUNa3h q7gIMGzlZ3iVWvjaihbgym07HcKoVjU= Date: Tue, 1 Dec 2020 12:26:47 +0100 From: Borislav Petkov To: wangrongwei Subject: Re: [PATCH 0/3] arm64:msr: Add MSR driver Message-ID: <20201201112647.GA22927@zn.tnic> References: <20201130174833.41315-1-rongwei.wang@linux.alibaba.com> <20201130190331.GI6019@zn.tnic> <8724DF91-5BF0-4265-8091-F9E0C7DC2F1A@linux.alibaba.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8724DF91-5BF0-4265-8091-F9E0C7DC2F1A@linux.alibaba.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201201_062656_085076_EBEADAA3 X-CRM114-Status: GOOD ( 14.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gshan@redhat.com, Anson.Huang@nxp.com, geert+renesas@glider.be, catalin.marinas@arm.com, masahiroy@kernel.org, linux-kernel@vger.kernel.org, michael@walle.cc, krzk@kernel.org, bjorn.andersson@linaro.org, vkoul@kernel.org, olof@lixom.net, shawnguo@kernel.org, vincenzo.frascino@arm.com, Will Deacon , ardb@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 01, 2020 at 11:44:52AM +0800, wangrongwei wrote: > Indeed, I have read the commit message, and it seems that writes data > to a system register may cause many problems. Actually, we have taken > this into account. In the current version, we have separated the read > and write functions to the system registers into two commands, There's rdmsr and wrmsr in msr-tools on x86 too. > In providing the WRASR function, we consider that users should bear > the consequences of rewriting registers during the debugging phase. In > fact, most of the time we rarely use WRASR, and only use it when we > are very confident. As I said, there should never never ever be a tool which allows writing of registers from userspace. If I could go back in time, I'd stop this on x86 but it is too late now. Not for ARM though. Also, do you see how all the people who replied to your mail, put the text under the quoted text. Do that too, pls, from now on, and refrain from top-posting. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel