From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97DE9C64E7B for ; Tue, 1 Dec 2020 12:32:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0E4BE206E0 for ; Tue, 1 Dec 2020 12:32:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="J25v+aPQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E4BE206E0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=reMvyDYRUIENKcHUDOhPxXD23mbeDSA2zOvdAOVOU4w=; b=J25v+aPQm7BSNKEPfGQFSj+yB 0dVKCRq5UDsS7MskU3rllLvNW63kEuhd7cYq1KjO+0yU87ink07Q8+2yOhHBHWriDnZc4v+kLymIg wj+IUxrcbf8qTO7REbkGNHYJH0J8UDyyFnn6VlEtWnvtPe6USJA2GsrMClEGTVNtm0E9SRbCzZQxi 6qzi8fUvODCLtVZNehpCa073PrkrXckJ54jfHGgLJor5hAY6wWVCU46cQblh7tbvjECxpGFOJyxiQ DAFAKJo79I+NuubPLseRVKCyjf5gR0JBRRvSKRJDFn9dbJm4V9sN8hnF2qWIwKkuI+RQA+48SRorM p/Sum+6jA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kk4nx-00019e-4Z; Tue, 01 Dec 2020 12:30:49 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kk4nu-00019I-C3 for linux-arm-kernel@lists.infradead.org; Tue, 01 Dec 2020 12:30:47 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1D4C0101E; Tue, 1 Dec 2020 04:30:44 -0800 (PST) Received: from C02TD0UTHF1T.local (unknown [10.57.30.155]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A9A8E3F718; Tue, 1 Dec 2020 04:30:41 -0800 (PST) Date: Tue, 1 Dec 2020 12:30:37 +0000 From: Mark Rutland To: James Morse Subject: Re: [PATCHv4 14/17] arm64: uaccess: remove set_fs() Message-ID: <20201201123037.GC81672@C02TD0UTHF1T.local> References: <20201113124937.20574-1-mark.rutland@arm.com> <20201113124937.20574-15-mark.rutland@arm.com> <827c7b13-4a23-f68f-d9ac-ddfef9e1bd56@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <827c7b13-4a23-f68f-d9ac-ddfef9e1bd56@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201201_073046_485483_EF933BA4 X-CRM114-Status: GOOD ( 17.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: catalin.marinas@arm.com, will@kernel.org, hch@lst.de, linux-arm-kernel@lists.infradead.org, robin.murphy@arm.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 26, 2020 at 06:42:26PM +0000, James Morse wrote: > On 13/11/2020 12:49, Mark Rutland wrote: > > Now that the uaccess primitives dont take addr_limit into acccount, we > > (account) I've fixed that up locally. [...] > > @@ -193,8 +193,7 @@ struct pt_regs { > > s32 syscallno; > > u32 unused2; > > #endif > > - > > - u64 orig_addr_limit; > > + u64 sdei_ttbr1; > > /* Only valid when ARM64_HAS_IRQ_PRIO_MASKING is enabled. */ > > u64 pmr_save; > > u64 stackframe[2]; > > Hmmm, > > /* > > - * Use reg->interrupted_regs.addr_limit to remember whether to unmap > > - * the kernel on exit. > > + * Remember whether to unmap the kernel on exit. > > */ > > -1: str x4, [x1, #(SDEI_EVENT_INTREGS + S_ORIG_ADDR_LIMIT)] > > +1: str x4, [x1, #(SDEI_EVENT_INTREGS + S_SDEI_TTBR1)] > > > > #ifdef CONFIG_RANDOMIZE_BASE > > adr x4, tramp_vectors + PAGE_SIZE > > @@ -1023,7 +1010,7 @@ NOKPROBE(__sdei_asm_entry_trampoline) > > * x4: struct sdei_registered_event argument from registration time. > > */ > > SYM_CODE_START(__sdei_asm_exit_trampoline) > > - ldr x4, [x4, #(SDEI_EVENT_INTREGS + S_ORIG_ADDR_LIMIT)] > > + ldr x4, [x4, #(SDEI_EVENT_INTREGS + S_SDEI_TTBR1)] > > cbnz x4, 1f > > > > tramp_unmap_kernel tmp=x4 > > Ah, that. This was previously abusing orig_addr_limit as the space was already there, and > if you squint.... > > Now it seems odd to waste that space in every pt_regs given its only needed in here, but > its still needed for padding. If more padding ever turns up I'll add cleaning this up to > my todo list. Mhmm. For now, I've added a comment to the commit message to point out what going on here. > Acked-by: James Morse Thanks! Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel