From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45CD1C64E7B for ; Tue, 1 Dec 2020 13:56:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C3538206A5 for ; Tue, 1 Dec 2020 13:56:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AZ3YIebo"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="eUJWOYMj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C3538206A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fQ6D0DZnaeQxGJKReMXoQ0rd9HKx6LwJtKOcrA5PXNE=; b=AZ3YIebomqK03lazoeTbOF6X5 TrO2DqaF+Qhp5KDL0ZPW9LpeInDfUK0wr4sFa7Gc6+z2dSZycuIIqhnkU9GbFiZtQBGitDAawqMq9 rEXAjgqVIWpP4FJlimCMbgt25payGLPBjdsJP47OOF5wNWh1CyDi6bNQVN6xG19s3P5+h4K/5hODA pV5SzDOh83l9iFw1tAXtbgZhdcaesbPOwL0dqMKNZf6qZH1goYOgy5p8wt0edxffGGHtKgGsCCSwo XvPglUh5FcDKE4FfQWOULVihktxuF5ZXFxubsZhECADO6o7qVO977+L13v1XF6PuC/pLD/yswW2AV IVa3YpKHA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kk67m-0002bi-W6; Tue, 01 Dec 2020 13:55:23 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kk67k-0002aR-Oz for linux-arm-kernel@lists.infradead.org; Tue, 01 Dec 2020 13:55:21 +0000 Received: by mail-wm1-x341.google.com with SMTP id x22so2964676wmc.5 for ; Tue, 01 Dec 2020 05:55:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+PwXtTlcdJC6Kz6wHrFVenV3uj6g4mhzGOO7PCwpUDQ=; b=eUJWOYMj7hUEXl+QsjBQLb4Ml91vgJpJhCrjpxbqM+50vIH2ZQr0o0DZ8eYxOZyD2o qwK6VPbpB7r9OpI2pQzstBVO51hojkHH/0EuWCbkVWnDnxeTGQwxo7VZuIIWqFp8HMiM HVgkn/F6eMzurxhiSQXvv2Die4eIq572mY627xAt4ltupWKvoFDcjH8wfMXyaRjTxDbK P2fC1SvegV0bW8P/NfopNX6pZGUs2h4/HoDwq+NF7H6ZGOjbQupT8yplG2TwaL5YU7QG 05vaH8BrE584TyNyIOq9F5K2WiZHXZ6N946VYV9SAcc566zeIk1Xid5fVDSMBBlJVcV6 Khrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+PwXtTlcdJC6Kz6wHrFVenV3uj6g4mhzGOO7PCwpUDQ=; b=FJHuc4v/Pi8cKNR0jPpVE0/u1Ty7+a0MAYbn/HGSZeUgPytfZVwpPV2VaWVLLb2y0Z AJTazNMqdXSZqDcwELmTcTK/D1pajmQyD/wc+AvHJ+bjscAlgEc7UD21z0BeEIC9npz1 ULjrpFSWwFitZA8Q66IOFzkGPCqmxAGr7HZeArsxiBdymePJV2k65qhuiMSGvbnNAWAF MmTpWl9ck2kk+yk+udErWNyyoYI2FuXhtWreAUi8Ym6k/yEvAWmZ+J6YNOjOrNCgIKVz vR1kt+B2Ce6hcHI4zGWULNYIlHycnES7NfWeZFANUIv8fcnWPQJuNmAejeshb81H+9c9 K4Qw== X-Gm-Message-State: AOAM5304Eo3ZugTvOjpxrS0jYfAhkcF6B5QwRCZiYsMlvmsYhrZJkAVr NwcRRgoOGvjaB5DL7bFeknPSSA== X-Google-Smtp-Source: ABdhPJx0qfzSScy1bKvaj9lSd/UJsODYPKOs6sdmtZoDpxlKzd7namARNALtRyqKWoGJ6kLRj1q4lA== X-Received: by 2002:a1c:e042:: with SMTP id x63mr2861883wmg.68.1606830918697; Tue, 01 Dec 2020 05:55:18 -0800 (PST) Received: from google.com ([2a01:4b00:8523:2d03:7c5f:5ab5:ac1f:89ce]) by smtp.gmail.com with ESMTPSA id b12sm10194961wmj.2.2020.12.01.05.55.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Dec 2020 05:55:17 -0800 (PST) Date: Tue, 1 Dec 2020 13:55:16 +0000 From: David Brazdil To: Mark Rutland Subject: Re: [PATCH v3 05/23] arm64: Extract parts of el2_setup into a macro Message-ID: <20201201135516.3ksifw3ynlxyok7k@google.com> References: <20201126155421.14901-1-dbrazdil@google.com> <20201126155421.14901-6-dbrazdil@google.com> <20201126180608.GF38486@C02TD0UTHF1T.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201126180608.GF38486@C02TD0UTHF1T.local> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201201_085520_930427_BEED1113 X-CRM114-Status: GOOD ( 14.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , kernel-team@android.com, Jonathan Corbet , Catalin Marinas , Suzuki K Poulose , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Sudeep Holla , James Morse , linux-arm-kernel@lists.infradead.org, Marc Zyngier , Tejun Heo , Dennis Zhou , Christoph Lameter , Will Deacon , kvmarm@lists.cs.columbia.edu, Julien Thierry Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hey Mark, > In the head.S code, this was under an ifdef CONFIG_ARM_GIC_V3, but that > ifdef wasn't carried into the macro here, or into its use below. I'm not > sure of the impact, but that does seem to be a functional change. > > > + > > +.macro __init_el2_hstr > > + msr hstr_el2, xzr // Disable CP15 traps to EL2 > > +.endm > > Likewise, this used to be be guarded by CONFIG_COMPAT, but that's not > carried into the macro or its use. > > If the intent was to remove the conditionality, then that should be > mentioned in the commit message, since it is a potential functional > change. Apologies, and well spotted. Marc suggested removing the ifdefs as redundant during his review of v2. I'll update the commit message to reflect that. David _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel