From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F41ABC64E7A for ; Tue, 1 Dec 2020 16:58:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 69DEA20758 for ; Tue, 1 Dec 2020 16:58:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UGiaBghi"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="cerhKoK4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 69DEA20758 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xhwu5bm5wJfDPXm49iDI6KSeQRl7Bmifm2NkzP/78lA=; b=UGiaBghinecVR2g1kmBTx9Qkn GCK/qfGTTYhyevgx5L/JoqEc5EzLerOVXRe24ByvT84GULjblcc42KJv7KOgx6b6oRze8ainFckag H2qhN7YlvOR3Rp+YTktwps15HjlSBRcOdX2bTmEPpte2ZrIm2GiJZezPg03P8WZjjp8sm8Qnn0lSK gfU0fnAqfST1yvfghmOxt+D4+OKxVrgkePVMmCjsUIJM9MgEcEIH2fGFUxaCAc4H5aq9ML4arbQFi RvTfM/jdnSLNjusc4A3s2M4j/ys5R3Z3agOU8SlgZHEAfNZF+VeAENHif3jd99AHkNvaE+Aupr/oz RndvjZOOw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kk8xs-00040f-9O; Tue, 01 Dec 2020 16:57:20 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kk8xn-0003yi-Rs for linux-arm-kernel@lists.infradead.org; Tue, 01 Dec 2020 16:57:16 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BF72D208FE; Tue, 1 Dec 2020 16:57:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606841835; bh=TD1OZINnY67L3Dc0uTdiWI+k0pIiWGWqD8B7hdSEwtY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cerhKoK4Goj22/4KIM/bZh+JacRzL+mMtrkqnS6nd/4K2XghIlz8IpR945QMidmyU Bv/DyiZUVDLW/UDzs5/v77e4wKdS05kZ6yP0QTdtUrTFOi7XCR9G5bD1WLtJruPVuH XPEPDg1fqmG/FzNrr/srx2Q9oL89rLAXy6TgnlHI= Date: Tue, 1 Dec 2020 16:57:08 +0000 From: Will Deacon To: Marc Zyngier Subject: Re: [PATCH v4 03/14] KVM: arm64: Kill 32-bit vCPUs on systems with mismatched EL0 support Message-ID: <20201201165707.GF27783@willie-the-truck> References: <20201124155039.13804-1-will@kernel.org> <20201124155039.13804-4-will@kernel.org> <9bd06b193e7fb859a1207bb1302b7597@kernel.org> <20201127115304.GB20564@willie-the-truck> <583c4074bbd4cf8b8085037745a5d1c0@kernel.org> <20201127172434.GA984327@google.com> <9de8639549040b4478b312503fd5a23f@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9de8639549040b4478b312503fd5a23f@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201201_115716_036505_7B9392CA X-CRM114-Status: GOOD ( 19.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Juri Lelli , kernel-team@android.com, Vincent Guittot , Quentin Perret , Peter Zijlstra , Catalin Marinas , Johannes Weiner , linux-kernel@vger.kernel.org, Qais Yousef , Ingo Molnar , Li Zefan , Greg Kroah-Hartman , Tejun Heo , Suren Baghdasaryan , Morten Rasmussen , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 27, 2020 at 06:16:35PM +0000, Marc Zyngier wrote: > On 2020-11-27 17:24, Quentin Perret wrote: > > On Friday 27 Nov 2020 at 17:14:11 (+0000), Marc Zyngier wrote: > > [...] > > > > Yeah, the sanitized read feels better, if only because that is > > > what we are going to read in all the valid cases, unfortunately. > > > read_sanitised_ftr_reg() is sadly not designed to be called on > > > a fast path, meaning that 32bit guests will do a bsearch() on > > > the ID-regs every time they exit... > > > > > > I guess we will have to evaluate how much we loose with this. > > > > Could we use the trick we have for arm64_ftr_reg_ctrel0 to speed this > > up? > > Maybe. I want to first verify whether this has any measurable impact. > Another possibility would be to cache the last read_sanitised_ftr_reg() > access, just to see if that helps. There shouldn't be that many code > paths hammering it. We don't have huge numbers of ID registers, so the bsearch shouldn't be too expensive. However, I'd like to remind myself why we can't index into the feature register array directly as we _should_ know all of this stuff at compile time, right? Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel