linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Peter Collingbourne <pcc@google.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Andrey Konovalov <andreyknvl@google.com>,
	Mark Brown <broonie@kernel.org>, Will Deacon <will@kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 2/2] arm64: stacktrace: Relax frame record alignment requirement to 8 bytes
Date: Tue, 1 Dec 2020 17:28:53 +0000	[thread overview]
Message-ID: <20201201172852.GF31404@gaia> (raw)
In-Reply-To: <CAMn1gO5vmPvJdGa1c=qiGePrB4ofKYn4gew7+-4=W_rzDyCTxA@mail.gmail.com>

On Fri, Nov 20, 2020 at 06:32:35PM -0800, Peter Collingbourne wrote:
> On Mon, Oct 26, 2020 at 2:00 PM Peter Collingbourne <pcc@google.com> wrote:
> > The AAPCS places no requirements on the alignment of the frame
> > record. In theory it could be placed anywhere, although it seems
> > sensible to require it to be aligned to 8 bytes. With an upcoming
> > enhancement to tag-based KASAN Clang will begin creating frame records
> > located at an address that is only aligned to 8 bytes. Accommodate
> > such frame records in the stack unwinding code.
> >
> > As pointed out by Mark Rutland, the userspace stack unwinding code
> > has the same problem, so fix it there as well.
> 
> As a reminder, this series is required in order to avoid breaking
> stack traces once [1] is applied.
> 
> Peter
> 
> [1] https://lore.kernel.org/linux-arm-kernel/20201120230211.584929-1-pcc@google.com/T/

While this series looks fine, on its own it doesn't solve any issue we
currently have. So, could you please post this series together with the
outlined tags mismatch checks patch? I think they should be merged
together.

Thanks.

-- 
Catalin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-12-01 17:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-26 20:59 [PATCH v2 1/2] arm64: Change the on_*stack functions to take a size argument Peter Collingbourne
2020-10-26 20:59 ` [PATCH v2 2/2] arm64: stacktrace: Relax frame record alignment requirement to 8 bytes Peter Collingbourne
2020-11-21  2:32   ` Peter Collingbourne
2020-12-01 17:28     ` Catalin Marinas [this message]
2020-12-03  5:15       ` Peter Collingbourne
2020-11-23 18:21   ` Andrey Konovalov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201201172852.GF31404@gaia \
    --to=catalin.marinas@arm.com \
    --cc=andreyknvl@google.com \
    --cc=broonie@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=pcc@google.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).