From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 060BAC64E7B for ; Tue, 1 Dec 2020 17:30:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 80F9A2151B for ; Tue, 1 Dec 2020 17:30:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="yBxPyXRD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 80F9A2151B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=H/3w+aQK2j+hy9dhJqZeIhawVfl07uaJVA6DFpaHfAE=; b=yBxPyXRDysw+xzT1DhjdHnqaF aYKu3MbVbZcbxWGUTR4BAaNKRj8ctiEKT/qecUTKaQGAHxDVdbPwmIGiJEmYQsckfEi2Hu01ICsV9 WfHojghOHA7O+BBOcd4vFEGdqotRNsLU84HzFFY/fqWdgVyW6ESpgMdv1ZV0eRVKv8TUqc6/pI81d 7j2Qn5d2phP627mI6JhfytigT36wX+sqDC1ojM7vJqMBRkp8bW26fGCElgO++IJtmtF3iSsJvomj6 V4M5BjXMinftbJX/X+BQBMzIsEUUwil/WAHaF9eYUlV613RP9Sh8zMi6gTCfAZn6pdIj8/KFlBAB2 OpZ/Pcdcg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kk9SW-0007fz-VV; Tue, 01 Dec 2020 17:29:00 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kk9SU-0007fH-DD for linux-arm-kernel@lists.infradead.org; Tue, 01 Dec 2020 17:28:59 +0000 Received: from gaia (unknown [95.146.230.165]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C268C2151B; Tue, 1 Dec 2020 17:28:55 +0000 (UTC) Date: Tue, 1 Dec 2020 17:28:53 +0000 From: Catalin Marinas To: Peter Collingbourne Subject: Re: [PATCH v2 2/2] arm64: stacktrace: Relax frame record alignment requirement to 8 bytes Message-ID: <20201201172852.GF31404@gaia> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201201_122858_546064_76965D1B X-CRM114-Status: GOOD ( 18.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Andrey Konovalov , Mark Brown , Will Deacon , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 20, 2020 at 06:32:35PM -0800, Peter Collingbourne wrote: > On Mon, Oct 26, 2020 at 2:00 PM Peter Collingbourne wrote: > > The AAPCS places no requirements on the alignment of the frame > > record. In theory it could be placed anywhere, although it seems > > sensible to require it to be aligned to 8 bytes. With an upcoming > > enhancement to tag-based KASAN Clang will begin creating frame records > > located at an address that is only aligned to 8 bytes. Accommodate > > such frame records in the stack unwinding code. > > > > As pointed out by Mark Rutland, the userspace stack unwinding code > > has the same problem, so fix it there as well. > > As a reminder, this series is required in order to avoid breaking > stack traces once [1] is applied. > > Peter > > [1] https://lore.kernel.org/linux-arm-kernel/20201120230211.584929-1-pcc@google.com/T/ While this series looks fine, on its own it doesn't solve any issue we currently have. So, could you please post this series together with the outlined tags mismatch checks patch? I think they should be merged together. Thanks. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel