From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03A93C64E7B for ; Tue, 1 Dec 2020 18:06:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7F7E5206D5 for ; Tue, 1 Dec 2020 18:06:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LAG9LqF5"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Q+QSLRrN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F7E5206D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID:Subject:To:From: Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References:List-Owner; bh=GLdvQdaM5M3kQAKqMhYSa0glLRnt/rY8+0vZQU+p41s=; b=LAG9LqF50yQ9LxjafbXUpDueR vrGZqagqT7RLNDsGdT275mi8bsTLiSMDof9JVsbmz1+71bD0uDQ/0APDuiPNJhk21ni3+KrdMaw4A G+iVhBppJWJKq6oFxWgokV8b8XK+T8wfYnOOOGQ1xBLt4zkdOrlTryzQJwuvcT4zo1vKYavgAVlr1 6Aj5baGr2WZRVuSfiCzk5wzu1B/tQTGLGlwaZOsSgnr8/+Mmx+/bNu4JCWi5px45cgOdtOtaWjuJS WddtvrsFXpiC9mJkB/IvSPye0AybSixhRTZvNMY+TS0y/u4RhcBfExvlCYhe06FPBrEBw1KQfbjOY 7NXQYKkjg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkA1W-0004PF-EJ; Tue, 01 Dec 2020 18:05:10 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkA1T-0004Ob-E0; Tue, 01 Dec 2020 18:05:08 +0000 Received: from localhost (129.sub-72-107-112.myvzw.com [72.107.112.129]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AF0CD206E0; Tue, 1 Dec 2020 18:05:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606845905; bh=NDbqdi1dY0jePUs1m+Df4GZMk8/N7wk7RMYH342WSRE=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=Q+QSLRrNGaqVdwqvELVyoAGnIEyYdBsPIpCjKV1IQIOkHkOWQDY/Y3YmIWVeCAEx7 4VxxBgWm+Vzx1qb04KtqjZ53ccfD++0XYOKCZNaQLsAd77DRr6bht1zzgNRrgaqbxr MwtPmSrB6KHkZNJ43lj7RDMTubHcIbz+xueWOiSQ= Date: Tue, 1 Dec 2020 12:05:03 -0600 From: Bjorn Helgaas To: Jim Quinlan Subject: Re: [PATCH v2 5/6] PCI: brcmstb: Add panic/die handler to RC driver Message-ID: <20201201180503.GA1321042@bjorn-Precision-5520> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201130211145.3012-6-james.quinlan@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201201_130507_579318_EB741192 X-CRM114-Status: GOOD ( 11.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , Rob Herring , Lorenzo Pieralisi , linux-pci@vger.kernel.org, open list , broonie@kernel.org, bcm-kernel-feedback-list@broadcom.com, "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , Bjorn Helgaas , Florian Fainelli , Nicolas Saenz Julienne Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 30, 2020 at 04:11:42PM -0500, Jim Quinlan wrote: > Whereas most PCIe HW returns 0xffffffff on illegal accesses and the like, > by default Broadcom's STB PCIe controller effects an abort. This simple > handler determines if the PCIe controller was the cause of the abort and if > so, prints out diagnostic info. What happens during enumeration? pci_bus_generic_read_dev_vendor_id() assumes a read of Vendor ID returns 0xffffffff if the device doesn't exist. I assume this case doesn't cause the abort you're referring to here, or nothing would work. I think this enumeration case results in PCIe Unsupported Request errors (PCIe r5.0, sec 2.3.2 implementation note). Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel