From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 332D7C64E8A for ; Wed, 2 Dec 2020 03:17:10 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AF85E221E9 for ; Wed, 2 Dec 2020 03:17:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF85E221E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ejt+CAXrXWlq6eRMLaQbzxbBp2LR8Uul4FCWxDlqKow=; b=huouivyShwEsLQM4udYyDVAKv c5pbp0Xl2nskDd4qQhesAmTj7ufbxzEg6Sbn62jH5sL6DnKGYx8dcH47sKH4hxB6nhx8n95Z3Sww7 QE32DEoo94GKJsHD9BfCKrTFJPxS6N203aOyMAt7iXHn4kMs00wjo0Srzs3efHT6+oV2vGZBWnkNl UgRej11ynBNVoj2RkjABn1+AWLjHJZwgVdjvzsvnhD1uGThTCI4ci/Cd7qI0nB+zKCe2ZZLAwXV88 lCfeIL2zOxkMINSzLW5erhS0OD8S90kPqkJt8loqh8RI1vPhNw7Wh00FS5Gq5H5tnp+miuw1xIt8/ niPhW+FMQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkIcJ-00005a-EN; Wed, 02 Dec 2020 03:15:43 +0000 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkIcG-000054-3e for linux-arm-kernel@lists.infradead.org; Wed, 02 Dec 2020 03:15:41 +0000 Received: by mail-pg1-x542.google.com with SMTP id e23so188750pgk.12 for ; Tue, 01 Dec 2020 19:15:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=Rks9iDroLs07BseqwMKTnyj2oPFRu7kKJBxKHhohW3Q=; b=tYZ3XDneslqcNycAwErMGSPtcmyn6QyCYlZjMqtABmGeJSMh4QaqvT/BvtRrMGm6w/ Uto87yAEshsmC4mywBLQCs0lki4jqa8tPDrtxLvUchOI5jUjl/kmYeNZL3PuSbIzlq7v jo8kap+g11+Bil+T4+LhZ8izzgroS41c2uIR0LJ4pkaNcHrSd6b4j5qeMgO0IrWzzym2 vWq29t9mnKYLQyjuvIFXpOMpfJ5WXODLbl0BeHV7OQBKli/qhZk3JtGXU4HwafcTftqT H/UBiKZB6Eeyg33gPMjp169qvPaI6fNRxyoxD197PhqWzZqTtBa7K0FPcrOOiWwRnxcx p+uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Rks9iDroLs07BseqwMKTnyj2oPFRu7kKJBxKHhohW3Q=; b=fMez7iALoMXt8EwWZDF4C2vbLAYnlHnA5VwA6+/pcNsfH6kIX8kZWPMjhkXYdfwtdF pJifqGg4lKmSEFKJgI5LJJVhuB9D/dLbDhJwhW6O3s7soX0TCIoKK3ai7ScDkmMbaSmP FJeKrt5le1q1bRUDxD4K9zZQmLQkO379SKsxXLB+CEMjeqCaUTnwX9qP0VEtaX8h24Ir tO//psDcqXp3sXTreECG1YCQcEwcWQ6ayhFPaWZtXILqiyHSSE95WP/lUV1NVlaVxN3y 4mzXiQV2Di5UpUMXaEMNekaCQS74TLvElXIaqXVoNHtsXKW6rXZXBF+dNrFXMgAholKt xfRQ== X-Gm-Message-State: AOAM5314b1CO8Qtd6IKAyvq1HyLufmhwx9UryeoyM7hJ7ZBgWyhJy2oI CQorMLJWGdnC+/atSp0e98Q= X-Google-Smtp-Source: ABdhPJxroK6P2BQXgv2VpfeIbksxJUHHk9S5Q/bM8txGqYEVVcrU8dIwIzykaWi/IStzDM6HBGqvSg== X-Received: by 2002:a05:6a00:16c5:b029:19b:696:28a0 with SMTP id l5-20020a056a0016c5b029019b069628a0mr606759pfc.9.1606878936058; Tue, 01 Dec 2020 19:15:36 -0800 (PST) Received: from dtor-ws ([2620:15c:202:201:a6ae:11ff:fe11:fcc3]) by smtp.gmail.com with ESMTPSA id nm6sm148370pjb.25.2020.12.01.19.15.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Dec 2020 19:15:35 -0800 (PST) Date: Tue, 1 Dec 2020 19:15:32 -0800 From: Dmitry Torokhov To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH] ARM: sa11111: make sa1111 bus's remove callback return void Message-ID: <20201202031532.GY2034289@dtor-ws> References: <20201126114724.2028511-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201126114724.2028511-1-u.kleine-koenig@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201201_221540_193545_9795565B X-CRM114-Status: GOOD ( 14.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, Russell King , Dominik Brodowski , Alan Stern , kernel@pengutronix.de, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 26, 2020 at 12:47:24PM +0100, Uwe Kleine-K=F6nig wrote: > The driver core ignores the return value of struct device_driver::remove > because there is only little that can be done. To simplify the quest to > make this function return void, let struct sa1111_driver::remove return > void, too. All users already unconditionally return 0, this commit makes > it obvious that returning an error code is a bad idea and ensures future > users behave accordingly. > = > Signed-off-by: Uwe Kleine-K=F6nig > --- > arch/arm/common/sa1111.c | 6 +++--- > arch/arm/include/asm/hardware/sa1111.h | 2 +- > drivers/input/serio/sa1111ps2.c | 4 +--- Acked-by: Dmitry Torokhov Thanks. -- = Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel