From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F4064C64E7C for ; Wed, 2 Dec 2020 12:21:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 767B7221FE for ; Wed, 2 Dec 2020 12:21:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 767B7221FE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=s8PE2KjEUnFvNmi0n0hI6sYJwLfsgWkLrJ69RHcJiig=; b=kTsSfSQbSVFCOe5QpyHRiGZG/ eRniiY0nSlVo0H322SQ0zp4j4GG0t9M/q7F8tb5nxvqPC6Arj5+EYxqYOpL1JEdCvvzwqNGz8WFqa XJUQ0hb9nv7k7eouiFxaqIJvI6AdYz63OjqRNSFrvY6pj5KP7nXfqX3breNZmdaghlww2p9vtQp3j qdcKn2q7KlFyfdSFLaVk5/P69JIKD16tt9O8vZt+7vYUNDgXIPA/D0Ad5hsEEGfREpeyMQBWhMGpR Av+Ww5p3DMZRdEi9ONyWkFhW1dTko2dLRhJxm5bFouQdj2aowZ9RueJ+UCR7WHJF/zlcoi1Uc1awS woW0wFkXg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkR74-0005Qj-Ic; Wed, 02 Dec 2020 12:20:02 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkR71-0005Pb-W6 for linux-arm-kernel@lists.infradead.org; Wed, 02 Dec 2020 12:20:00 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DAAD2101E; Wed, 2 Dec 2020 04:19:57 -0800 (PST) Received: from C02TD0UTHF1T.local (unknown [10.57.23.201]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 65BC43F718; Wed, 2 Dec 2020 04:19:56 -0800 (PST) Date: Wed, 2 Dec 2020 12:19:50 +0000 From: Mark Rutland To: James Morse Subject: Re: [PATCHv4 12/17] arm64: uaccess: split user/kernel routines Message-ID: <20201202121950.GA66611@C02TD0UTHF1T.local> References: <20201113124937.20574-1-mark.rutland@arm.com> <20201113124937.20574-13-mark.rutland@arm.com> <315fbabd-629d-e513-95f6-3d251f225779@arm.com> <20201201110323.GA81672@C02TD0UTHF1T.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201201110323.GA81672@C02TD0UTHF1T.local> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201202_072000_108914_0DACE393 X-CRM114-Status: GOOD ( 16.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: catalin.marinas@arm.com, will@kernel.org, hch@lst.de, linux-arm-kernel@lists.infradead.org, robin.murphy@arm.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 01, 2020 at 11:03:23AM +0000, Mark Rutland wrote: > On Thu, Nov 26, 2020 at 06:42:24PM +0000, James Morse wrote: > > On 13/11/2020 12:49, Mark Rutland wrote: > > > +#define __get_kernel_nofault(dst, src, type, err_label) \ > > > +do { \ > > > + int __gkn_err = 0; \ > > > + \ > > > + __raw_get_mem("ldr", *((type *)(dst)), \ > > > + (__force type __user *)(src), __gkn_err); \ > > > > Is the __user needed as you moved __chk_user_ptr() out of __raw_get_mem() in the previous > > patch? > > You're right; the __user portion can go as neither __raw_get_mem() or > __get_mem_asm() needs that. Likewise for __put_kernel_nofault(), > __raw_put_mem(), and __put_mem_asm(). > > I've removed those. > > > (your branch on kernel.org does something different here, not sure if its ahead or behind v4) > > AFAICT this portion of the patch is up-to-date with what's on > kernel.org. I might have pushed that out-of-order with posting the > series -- does this look the same now, or am I missing something? So I can update the branch, I've tagged the version I was referring to above as arm64-set-fs-removal-20201113. The HEAD commit was: c765cd9bec3bfac8 ("arm64: uaccess: remove vestigal UAO support") Thanks, Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel