From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14F86C64E7C for ; Wed, 2 Dec 2020 15:58:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A0A0B206A5 for ; Wed, 2 Dec 2020 15:58:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A0A0B206A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mnzT4IGBmo1XpTSMMp+C2MZ0sXpMJFLr6NL9hPAdLH0=; b=qyk87gTYJ9wt69oaS110cUGtW 4NZ/2oMh599bD6MMqwJRXs+TJ++nRnhuZUC/H6Hl4CvoT8tDKmsY8aGO6F/TZcJGf0sOOc39xDdgp cxHqjO6X6FDInCtZouQr+3ZwdXftd55E3Cgd+kCGM+AUUj/r2elBT/mstorMdrqE6Euq+zGn7rnR9 hr8F0tyED524I3Bz/WvU6X1JL356uly2ydrFOB4JjTftamspAUX/N+67YwOK7JlRjXThHb1MIwWKN 41wSBirAeoQMXlZTne1vcQ/YI1Pfw/ulNfaVYiEa8bChBOX2v1GnwSCcuk8gY3V3CWKx4xkGo0h4X uitnpa8gA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkUV1-0006VI-J0; Wed, 02 Dec 2020 15:56:59 +0000 Received: from new2-smtp.messagingengine.com ([66.111.4.224]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkUUz-0006Uq-LQ for linux-arm-kernel@lists.infradead.org; Wed, 02 Dec 2020 15:56:58 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 1C4B458033F; Wed, 2 Dec 2020 10:56:56 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 02 Dec 2020 10:56:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=voFpRetlbBwCZg41ULNXnGM0fG4 XnIsMUrQNMwOslPo=; b=NwWbuoPEJcB2DbUf4340sNGSVyhJY4TMAa88T6asSGn QShwv6H4WeXjv+7G9yrla94szKX9qiSvroFxa3iS4wPDuUNY4yBbEbfuZT1ztA7v H7hL2SiLBjHU92Cxdx0QKDV6xcnJ3ZbDXHoDjLT28zIYS4lW1T/4hp/UXKwrWqTv BYgw+kpr597ttygKX9Ab7DQzg9Xwg0NcX29s7Yek2rWZCUtzTHfhjdCZfxNAKPlq LM3i782MKNHS7lO1i/iHbUNMVwY9R7pmiqdKxIHzNH1k9H/QM0PQJrn0WQJAxEhp bM6qMUOw9hqYmRwRiSouX1WrBCPDDJXOaHBoKki9oSw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=voFpRe tlbBwCZg41ULNXnGM0fG4XnIsMUrQNMwOslPo=; b=BD5Y/qG9bYresDqqUmyxRY JOd3xGakUnrn1r8jCeeJ/MSc9aRW3K+fU4X/I/ed+wc26RK/5n+5fVzEt9zGZO0b U/qkpzIbvFrFV7/gE/U7Zz+J7ka4LtPi/bjcFGAo8hYg003Sx7xwaJDLkc8vCslc l6IjYBSbl8e1X+G+NTlNZcGWtjNYDZUv1HqXv5+iJhFzeaZcOqaCvohsBhv1wGqa WT8BGq5DuW5d2s/I2FBDvVGvDrUR9r9HGp9SQMbqxwliT5AyVwPCu2EpnMKziAzJ UPKcWWcQi+sTCNoY03i+sZgONZOLpHD2Bm8/fo9nuklJ7AISBnYrYYJiW0fmX7vQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudeigedgkeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 1C40B240059; Wed, 2 Dec 2020 10:56:53 -0500 (EST) Date: Wed, 2 Dec 2020 16:56:51 +0100 From: Maxime Ripard To: Andre Przywara Subject: Re: [PATCH 5/8] clk: sunxi-ng: Add support for the Allwinner H616 CCU Message-ID: <20201202155651.vgbkrrrxlw55yq7x@gilmour> References: <20201202135409.13683-1-andre.przywara@arm.com> <20201202135409.13683-6-andre.przywara@arm.com> MIME-Version: 1.0 In-Reply-To: <20201202135409.13683-6-andre.przywara@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201202_105657_814883_9AC89B42 X-CRM114-Status: GOOD ( 11.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , Philipp Zabel , Stephen Boyd , Linus Walleij , linux-clk@vger.kernel.org, linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, Chen-Yu Tsai , Rob Herring , Icenowy Zheng , Yangtao Li , Michael Turquette , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============1118764849920257189==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1118764849920257189== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ynofnaw5enhpd4at" Content-Disposition: inline --ynofnaw5enhpd4at Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi On Wed, Dec 02, 2020 at 01:54:06PM +0000, Andre Przywara wrote: > While the clocks are fairly similar to the H6, many differ in tiny > details, so a separate clock driver seems indicated. >=20 > Derived from the H6 clock driver, and adjusted according to the manual. >=20 > Signed-off-by: Andre Przywara The patch itself looks ok, but there's a bunch of checkpatch warning you'll want to fix. Maxime --ynofnaw5enhpd4at Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX8e5QwAKCRDj7w1vZxhR xaeDAP0VXbK3/zS+gC9m2/thTZDBih7mPelLmESXwK8URJQS7QEAl3yzyzqpWNGk hkZe4Ua2yIFWQsZNw996qUTnSVnFmg8= =02s5 -----END PGP SIGNATURE----- --ynofnaw5enhpd4at-- --===============1118764849920257189== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1118764849920257189==--