From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6B83C64E7B for ; Wed, 2 Dec 2020 17:27:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3E063221FB for ; Wed, 2 Dec 2020 17:27:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E063221FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=k28qJ2m3Zu3pCWs3GNsQvqoDUt2Y9U3UlptYygPQfxY=; b=afVzhbZLeb2/jL+BGTFhIdykL m7ARqO9m1ye5OOThV1hAlop0rNyvdIYOC2eNTf130opYdVOZCqkafG9RACgyTp3yGw4znb+72c3ix WswfPIQ/SuNfJO3fd22V5Z35IskBc+eiRMpbZqgNMsAlR2HYq4MMl5+zkCHMQz9zo7Jl/13fbRdcg IKUGbkPSzDc6pNtgQ+ia4mO22dhsHV77vrdqcHqOczNxO5utb0Sv21YltNKFKzJTSqTykF6mLIhCY HRWpgE5h8Jz2bTMOlkXZnNsxWuGFqIoHnov4dv/wgyHKbl6fW5ZGDw8leU7bQzdOts3dPhWKv5D1F 6ukaqyayg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkVtR-0002Ms-NU; Wed, 02 Dec 2020 17:26:17 +0000 Received: from mail-ed1-f67.google.com ([209.85.208.67]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkVtO-0002L6-5E for linux-arm-kernel@lists.infradead.org; Wed, 02 Dec 2020 17:26:15 +0000 Received: by mail-ed1-f67.google.com with SMTP id c7so4814853edv.6 for ; Wed, 02 Dec 2020 09:26:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=NZKppA2o4fStxdLjfjRZ7S2o2vOkpaIWjvkic2iBJ2o=; b=fj0LdmLDPUAO9b7A5IxTHCUnbazQ00gzl++qbsW4d1cGkGPC8V0oydkVbu3uZ9KW1T bCdJSVvHxgNkR+VYWwKq32GdGdt73R324ZeP1sC/ke5cxHA7thEX819PUJ8Hb+tDgyU8 oGAz8Naa2H8UyXZiS1PiFNmtEp9n+BSR8nrvBvptvyJ9s5KhwZUaN9n4D4IGc11G5Dae f+iZNVN17FWCWM5Lyy3Tpf0qRJrHRuNB3lbkEaPlVpuB28fszM2F/uc+i27sVOb+qeHb lUAdl5eBgy6xXuTR/n986u91MEgSXG44IQqOvIdUI28pO+tcPfovzhGeOmMQMIwipC7y E4ZA== X-Gm-Message-State: AOAM533OL4Aq9f87//VBXUsalHtqGDgJ5WNz+VB38sWDGp25axYh698s OAQFxDUDUnY9IFBFaCxPriw= X-Google-Smtp-Source: ABdhPJxdaORGvlxmB1auKltfPkpySKQVxtcRpIMsn7/rGJ5juA54CQrEQkeOpggkaJPTCfdgu/9sUg== X-Received: by 2002:a50:998d:: with SMTP id m13mr982165edb.143.1606929972528; Wed, 02 Dec 2020 09:26:12 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id g9sm405995edw.67.2020.12.02.09.26.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Dec 2020 09:26:11 -0800 (PST) Date: Wed, 2 Dec 2020 19:26:10 +0200 From: Krzysztof Kozlowski To: Jagan Teki Subject: Re: [PATCH 03/10] arm64: dts: imx: Add Engicam EDIMM2.2 Starter Kit Message-ID: <20201202172610.GC3490@kozik-lap> References: <20201202121241.109952-1-jagan@amarulasolutions.com> <20201202121241.109952-4-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201202121241.109952-4-jagan@amarulasolutions.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201202_122614_264217_19BF8F66 X-CRM114-Status: GOOD ( 22.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Matteo Lisi , Shawn Guo , linux-kernel@vger.kernel.org, Li Yang , Rob Herring , NXP Linux Team , Fabio Estevam , linux-amarula@amarulasolutions.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 02, 2020 at 05:42:34PM +0530, Jagan Teki wrote: > Engicam EDIMM2.2 Starter Kit is an EDIMM 2.2 Form Factor Capacitive > Evaluation Board. > > Genaral features: > - LCD 7" C.Touch > - microSD slot > - Ethernet 1Gb > - Wifi/BT > - 2x LVDS Full HD interfaces > - 3x USB 2.0 > - 1x USB 3.0 > - HDMI Out > - Mini PCIe > - MIPI CSI > - 2x CAN > - Audio Out > > SOM's like i.Core MX8M Mini needs to mount on top of this Evaluation > board for creating complete i.Core MX8M Mini EDIMM2.2 Starter Kit. > > Add support for it. > > Signed-off-by: Matteo Lisi > Signed-off-by: Jagan Teki > --- > .../dts/freescale/imx8mm-engicam-common.dtsi | 24 +++++++++++++++++++ > .../freescale/imx8mm-engicam-edimm2.2.dtsi | 7 ++++++ > 2 files changed, 31 insertions(+) > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-common.dtsi > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-common.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-engicam-common.dtsi > new file mode 100644 > index 000000000000..67c1a3fe26bc > --- /dev/null > +++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-common.dtsi > @@ -0,0 +1,24 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (c) 2020 Engicam srl > + * Copyright (c) 2020 Amarula Solutions(India) > + */ > + > +&uart2 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_uart2>; > + status = "okay"; > +}; > + > +/* SD */ > +&usdhc1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_usdhc1>, <&pinctrl_usdhc1_gpio>; > + cd-gpios = <&gpio1 6 GPIO_ACTIVE_LOW>; > + max-frequency = <50000000>; > + bus-width = <4>; > + no-1-8-v; > + pm-ignore-notify; > + keep-power-in-suspend; > + status = "okay"; > +}; > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > new file mode 100644 > index 000000000000..294df07289a2 > --- /dev/null > +++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > @@ -0,0 +1,7 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (c) 2020 Engicam srl > + * Copyright (c) 2020 Amarula Solutions(India) > + */ > + > +#include "imx8mm-engicam-common.dtsi" A DTSI file only with UART and SD. You mentioned several features in the commit msg but none of them are implemented here. There aren't even CPUs... Maybe this is only a problem of your patch ordering but as of now - this looks like bogus/empty DTSI which should not be in its own commit. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel