From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64693C64E7B for ; Wed, 2 Dec 2020 17:39:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E07CB208FE for ; Wed, 2 Dec 2020 17:39:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E07CB208FE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tYsid5jIF3SJH1GhSUdn4ySTJGkUzd34kQRIA7UgGWM=; b=woQfW3OEgYJsk75XSKSHS6XGy PpOJlUcj8LGoRARRCZW9Dqj4XDKhBXDda3ANb2HVmJW/ypqiu1tAn/5ptAWrzhOj+mtmsMzF9EzrA DWCYyOYKFm2ZhdIQridBrreeW4MdRGUJPlEFNfXUQOmUwqHIPec5Lh/DjAGxZO7vXKCvQcvc7XBid dLDb4zA6IIsYR9QtyaMhrYzlMNhmx1OQRdSlwgtmt/4Gx6OCUxk9j1mNpkBPfKySKdzb11Eq+2s15 K+8UYKCHsrm+eNNN1E0anvWpejbNeMNXnVZVYBY3B4F3/+XUJNzaNj94jYYh3GR4srA4iqTrdx/KG v2IlLKOuQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkW52-0005dw-Jf; Wed, 02 Dec 2020 17:38:16 +0000 Received: from mail-ed1-f65.google.com ([209.85.208.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkW50-0005cq-3C for linux-arm-kernel@lists.infradead.org; Wed, 02 Dec 2020 17:38:15 +0000 Received: by mail-ed1-f65.google.com with SMTP id y22so4921927edv.1 for ; Wed, 02 Dec 2020 09:38:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8nI+6gnsqA0IBuGLzSn2crkcyrZrwcKzwQx02XE2RqY=; b=mKIwE1uIljV2dOrp8NtQrqEC0K2devwVew1c7UUIZwOyek/Ri9iCF6wBX3ox6JaCGT tR7xPABRomZQetwYYUOfHwE6FpdpRmdCkIs8a5YlE1Sr5IUWMpupAfewYuysQBdDO8r1 F6q5Itd4+RmhP0UfEsVojrKRPV+D1HafQkGJBha6+k/KdeFf1MaQ8tqR88LlL0IMhVtO wECzmnyxsuEf3cT5iux1L3VO3XuNlut+s/voaLoyc0h93EgoE+sSqF8D7VXc3o0i81S3 ZD5VvBY8wrNgrBQbnLup9wMabzte+9VuFNKs5OlDIaLmFXbgEGfNjd6pIiH6n5VwH8fH DZHA== X-Gm-Message-State: AOAM530CwUQs0skvgDyBJHb8O+OWQX/dhIzvEj6iwdzft3UqKgh6fF4Q d+Cs2Qw7/21PyROcuijcL60= X-Google-Smtp-Source: ABdhPJxqi50UI8aLSgEmGsBtJDWUOzEayK9dobVLiJzYbWqPzNM3fIkbreMmbb/vpGeMA6cPWJugpg== X-Received: by 2002:a50:e68a:: with SMTP id z10mr1089522edm.66.1606930692913; Wed, 02 Dec 2020 09:38:12 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id 91sm505977edy.45.2020.12.02.09.38.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Dec 2020 09:38:11 -0800 (PST) Date: Wed, 2 Dec 2020 19:38:09 +0200 From: Krzysztof Kozlowski To: Jagan Teki Subject: Re: [PATCH 05/10] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit Message-ID: <20201202173809.GE3490@kozik-lap> References: <20201202121241.109952-1-jagan@amarulasolutions.com> <20201202121241.109952-6-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201202121241.109952-6-jagan@amarulasolutions.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201202_123814_180213_63E61281 X-CRM114-Status: GOOD ( 20.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Matteo Lisi , Shawn Guo , linux-kernel@vger.kernel.org, Li Yang , Rob Herring , NXP Linux Team , Fabio Estevam , linux-amarula@amarulasolutions.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 02, 2020 at 05:42:36PM +0530, Jagan Teki wrote: > i.Core MX8M Mini is an EDIMM SOM based on NXP i.MX8MM from Engicam. > > EDIMM2.2 Starter Kit is an EDIMM 2.2 Form Factor Capacitive > Evaluation Board from Engicam. > > i.Core MX8M Mini needs to mount on top of this Evaluation board for > creating complete i.Core MX8M Mini EDIMM2.2 Starter Kit. > > Add support for it. > > Signed-off-by: Matteo Lisi > Signed-off-by: Jagan Teki > --- > arch/arm64/boot/dts/freescale/Makefile | 1 + > .../imx8mm-engicam-icore-mx8mm-edimm2.2.dts | 21 +++++++++++++++++++ > 2 files changed, 22 insertions(+) > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-icore-mx8mm-edimm2.2.dts > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > index 6f0777ee6cd6..4369d783dade 100644 > --- a/arch/arm64/boot/dts/freescale/Makefile > +++ b/arch/arm64/boot/dts/freescale/Makefile > @@ -30,6 +30,7 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-rdb.dtb > dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2162a-qds.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-engicam-icore-mx8mm-edimm2.2.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-icore-mx8mm-edimm2.2.dts b/arch/arm64/boot/dts/freescale/imx8mm-engicam-icore-mx8mm-edimm2.2.dts > new file mode 100644 > index 000000000000..a8afc0998fcd > --- /dev/null > +++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-icore-mx8mm-edimm2.2.dts > @@ -0,0 +1,21 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (c) 2019 NXP > + * Copyright (c) 2019 Engicam srl > + * Copyright (c) 2020 Amarula Solutions(India) > + */ > + > +/dts-v1/; > +#include "imx8mm.dtsi" imx8mm should be included in the SoM, not here. It's really wrong that you override some nodes in imx8mm-engicam-icore-mx8mm.dtsi which do not exist there (not included). > +#include "imx8mm-engicam-edimm2.2.dtsi" > +#include "imx8mm-engicam-icore-mx8mm.dtsi" > + > +/ { > + model = "Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit"; > + compatible = "engicam,icore-mx8mm-edimm2.2", "engicam,icore-mx8mm", This won't validate against your own bindings. Please fix either the DTS or the bindings. Then run dtbs_check. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel