From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A98EC64E7B for ; Wed, 2 Dec 2020 17:47:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A814E2086A for ; Wed, 2 Dec 2020 17:47:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A814E2086A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bDeviyw5CFMuoTHO5EkxnIORzA4du3i5qhc1CmNA6Lo=; b=zq8rl+1unSsxrjKbYOstqdXiY i38s4ho9XoFJytb2Ly6DQ5ifKkRSo7k6R/yuVdJK46/En+j+faD8R42v8iwotVx9vVJDC953iagHW OKJYQASy4RQiYzLZu5T7XsFN6El30Pll4yzJk61+0TYWjfbl0RWJ3oDJTsySL2v83yFvKgXHeGB/G a3KV1W3O+nvj3XDvX5pBUr5DSNDW0HKTk4OlBjoUoG/fdrJOLe5B7FtlHKN6WVeR045PHaqO3wXHA 0TowHf58IWIEbbOiHy2fpjeLEWf+2qHTr0mmkzVE8btoXUMNUu8AUwG4cVg5G3uyu7Bn6b/+WWRxP +i2sPdn4Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkWCO-0007ad-Tp; Wed, 02 Dec 2020 17:45:52 +0000 Received: from mail-ed1-f65.google.com ([209.85.208.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkWCD-0007Yh-Op for linux-arm-kernel@lists.infradead.org; Wed, 02 Dec 2020 17:45:42 +0000 Received: by mail-ed1-f65.google.com with SMTP id u19so4925775edx.2 for ; Wed, 02 Dec 2020 09:45:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=KQujH+DgczKfL4cTVLHPoonrrbdR99NcEgX+XcWOKS8=; b=fqVuSHMS2yNCscbi0VKYxu+sEb0sO1Ytm9ONKLV8VZrGUblJT7Va0QFHrvZUWGIo7T 6cF/1Q95z7GYcjXci5HXHOox7Kq9I+r7hiuXgMZ3rIFpuy8GoPF9s7kSC6u838O+6ZMC ZDc/kv8Nc9UkPzm61lNa/TZcp2n7Cdj5zL05qUnbgNkHU910w+zJze393Y9PKrTw4+4b EyNS+IFy3I+xYO7VlD2dEymBjUlWOWy6GLUCGahYWzEWb2K+fn2Vpq8Yj0AVBISFmwXn FZU2+xMlylQx8bh9X21dReKDhzV8jZtPzWKG4uHnM8q6DNYWtVWhhI5V7sY2KiOUk+fU WUXA== X-Gm-Message-State: AOAM531w3lCmdgTaMfrjOVViMuMFK3oDrZp00/s86j3VrDy/YHZCPeC9 Uhj2tk9XqKp+B0tan5xceMk= X-Google-Smtp-Source: ABdhPJxuPLbF0cdq0buzQ0cI4ciwXJndnNuVlUAc6BZuWmYu2a3yp+6MfdvNvA0vBVsRz1qFHp7YRQ== X-Received: by 2002:a50:e18c:: with SMTP id k12mr1090339edl.58.1606931140639; Wed, 02 Dec 2020 09:45:40 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id be6sm471571edb.29.2020.12.02.09.45.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Dec 2020 09:45:39 -0800 (PST) Date: Wed, 2 Dec 2020 19:45:38 +0200 From: Krzysztof Kozlowski To: Jagan Teki Subject: Re: [PATCH 08/10] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini C.TOUCH 2.0 Message-ID: <20201202174538.GH3490@kozik-lap> References: <20201202121241.109952-1-jagan@amarulasolutions.com> <20201202121241.109952-9-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201202121241.109952-9-jagan@amarulasolutions.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201202_124541_835234_8D3DCA2F X-CRM114-Status: GOOD ( 21.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Matteo Lisi , Shawn Guo , linux-kernel@vger.kernel.org, Li Yang , Rob Herring , NXP Linux Team , Fabio Estevam , linux-amarula@amarulasolutions.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 02, 2020 at 05:42:39PM +0530, Jagan Teki wrote: > i.Core MX8M Mini is an EDIMM SOM based on NXP i.MX8MM from Engicam. > > C.TOUCH 2.0 is a general purpose carrier board with capacitive > touch interface support. > > i.Core MX8M Mini needs to mount on top of this Carrier board for > creating complete i.Core MX8M Mini C.TOUCH 2.0 board. > > Add support for it. > > Signed-off-by: Matteo Lisi > Signed-off-by: Jagan Teki > --- > arch/arm64/boot/dts/freescale/Makefile | 1 + > .../imx8mm-engicam-icore-mx8mm-ctouch2.dts | 21 +++++++++++++++++++ > 2 files changed, 22 insertions(+) > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-icore-mx8mm-ctouch2.dts > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > index 4369d783dade..8191db4c64fa 100644 > --- a/arch/arm64/boot/dts/freescale/Makefile > +++ b/arch/arm64/boot/dts/freescale/Makefile > @@ -30,6 +30,7 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-rdb.dtb > dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2162a-qds.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-engicam-icore-mx8mm-ctouch2.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mm-engicam-icore-mx8mm-edimm2.2.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-icore-mx8mm-ctouch2.dts b/arch/arm64/boot/dts/freescale/imx8mm-engicam-icore-mx8mm-ctouch2.dts > new file mode 100644 > index 000000000000..aa3c03ad3109 > --- /dev/null > +++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-icore-mx8mm-ctouch2.dts > @@ -0,0 +1,21 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (c) 2019 NXP > + * Copyright (c) 2019 Engicam srl > + * Copyright (c) 2020 Amarula Solutions(India) > + */ > + > +/dts-v1/; > +#include "imx8mm.dtsi" You have multiple DTSI files to only include one DTSI. I was trying to follow the logic here but I failed... This is ctouch, so it should include SoM, which you call icore. But it also includes ctouch2 which *only* includes common DTSI. It's then exactly the same as starter kit which includes edimm (which includes common) and icore. Best regards, Krzysztof > +#include "imx8mm-engicam-ctouch2.dtsi" > +#include "imx8mm-engicam-icore-mx8mm.dtsi" > + > +/ { _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel