From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40E01C64E7B for ; Wed, 2 Dec 2020 17:51:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C1813217A0 for ; Wed, 2 Dec 2020 17:51:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C1813217A0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jSGyhf7QGu43AY9TYrKMcBrD0sbEtZBHDd6RLhBE3Ms=; b=vgan73jUiETpVBmfmxfrulMpL MZnyyUOZDTnLkSdK52toSp8v1cNGpOSd4NJTAfN4K4hqRPlwXIA4srfPOxNjYNDvD3U7GkjbneAbz MhF6FpuThCCHUl7u7Rw6XiAS94O8di/AlQ1JsHZSc263CeZeXYhltWha8+t1ignyU+1AWzNXlywDW IbsADVSkG80AKENXQ3bscWr9fmUtvwUyH/vZx2v15ummGQmBq+riKTmiFNRafklxbpVgsvNEZERXk Gh7adon+/zK2rLq+s0L/MfySxPeAYtxVbUoVOudJd2y84gsGnXkh6C24NSAfMMekjRwntvTYkdQ// 0tp7hFYEw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkWGF-0000lI-VS; Wed, 02 Dec 2020 17:49:52 +0000 Received: from mail-ej1-f67.google.com ([209.85.218.67]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkWG4-0000ha-Tl for linux-arm-kernel@lists.infradead.org; Wed, 02 Dec 2020 17:49:48 +0000 Received: by mail-ej1-f67.google.com with SMTP id ga15so5701798ejb.4 for ; Wed, 02 Dec 2020 09:49:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=TDQjWAWmhj2xYlTiLACdO4qIK/Fg0l3r/vpySRnLe3A=; b=HXcQSNWOuYPmj2QmULIzPcfh9VUOQUjMLuufZc335EYtFTANiDXNsowzkjpe8b1af4 yY+nPgCSYrbyUrS1IAFvXSWLAKx36Trvhj4XZWonejThA6qPZW9M8CB0slEd/d8SEab6 EsIv2O7/USgAz5TOFMXTfGHEzydIY6udhLm9lgZSHUzTgCxFkN6UyGEIqh+Fry1F3juW /pMCdFh+N6msHxgWqeRTPkTYWsccA57Lkog9F0uqD3ioJBDzhmg50d6ysisiDJezni74 neS4OqcTru0ahm0gfiGH87iqdSSJvimmY/uDiXdcfRhzKfowoMFg4ma934Cs8/8IyuIs RYwg== X-Gm-Message-State: AOAM530g8FwEdvKmF8aTp0Imw8w9jWNCrbSKWJaU4qMQtNct4rP9oUex +OSSJnVApfEx1Yl+Vf7W4TQ= X-Google-Smtp-Source: ABdhPJxIRtSrKyLfHBqLlF3OwYuA9KDGYI2zjcz/jj4YEP19WK3/PTEUN9KJafVDHg0WIUI7jfEo+g== X-Received: by 2002:a17:906:f2c3:: with SMTP id gz3mr911054ejb.448.1606931379227; Wed, 02 Dec 2020 09:49:39 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id j7sm473332edp.52.2020.12.02.09.49.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Dec 2020 09:49:37 -0800 (PST) Date: Wed, 2 Dec 2020 19:49:35 +0200 From: Krzysztof Kozlowski To: Jagan Teki Subject: Re: [PATCH 10/10] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini C.TOUCH 2.0 10.1" OF Message-ID: <20201202174935.GA4413@kozik-lap> References: <20201202121241.109952-1-jagan@amarulasolutions.com> <20201202121241.109952-11-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201202121241.109952-11-jagan@amarulasolutions.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201202_124941_034541_67419F4C X-CRM114-Status: GOOD ( 20.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Matteo Lisi , Shawn Guo , linux-kernel@vger.kernel.org, Li Yang , Rob Herring , NXP Linux Team , Fabio Estevam , linux-amarula@amarulasolutions.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 02, 2020 at 05:42:41PM +0530, Jagan Teki wrote: > i.Core MX8M Mini is an EDIMM SOM based on NXP i.MX8MM from Engicam. > > C.TOUCH 2.0 is a general purpose carrier board with capacitive > touch interface support. > > 10.1" OF is a capacitive touch 10.1" Open Frame panel solutions. > > i.Core MX8M Mini needs to mount on top of C.TOUCH 2.0 carrier with > pluged 10.1" OF for creating complete i.Core MX8M Mini C.TOUCH 2.0 > 10.1" Open Frame solution board. > > Add support for it. > > Signed-off-by: Matteo Lisi > Signed-off-by: Jagan Teki > --- > arch/arm64/boot/dts/freescale/Makefile | 1 + > ...mx8mm-engicam-icore-mx8mm-ctouch2-of10.dts | 21 +++++++++++++++++++ > 2 files changed, 22 insertions(+) > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-icore-mx8mm-ctouch2-of10.dts > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > index 8191db4c64fa..9725bbc0f268 100644 > --- a/arch/arm64/boot/dts/freescale/Makefile > +++ b/arch/arm64/boot/dts/freescale/Makefile > @@ -31,6 +31,7 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2162a-qds.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mm-engicam-icore-mx8mm-ctouch2.dtb > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-engicam-icore-mx8mm-ctouch2-of10.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mm-engicam-icore-mx8mm-edimm2.2.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-icore-mx8mm-ctouch2-of10.dts b/arch/arm64/boot/dts/freescale/imx8mm-engicam-icore-mx8mm-ctouch2-of10.dts > new file mode 100644 > index 000000000000..0124ba5ec69c > --- /dev/null > +++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-icore-mx8mm-ctouch2-of10.dts > @@ -0,0 +1,21 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (c) 2019 NXP > + * Copyright (c) 2019 Engicam srl > + * Copyright (c) 2020 Amarula Solutions(India) > + */ > + > +/dts-v1/; > +#include "imx8mm.dtsi" > +#include "imx8mm-engicam-ctouch2.dtsi" > +#include "imx8mm-engicam-icore-mx8mm.dtsi" > + > +/ { > + model = "Engicam i.Core MX8M Mini C.TOUCH 2.0 10.1\" Open Frame"; > + compatible = "engicam,icore-mx8mm-ctouch2-of10", "engicam,icore-mx8mm", > + "fsl,imx8mm"; No. You created 3 DTS and 3 DTSI which are all the same. The output DTB is probably the same for all three DTS files. Only one DTSI has anything inside, all others are just copy paste. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel