From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B10AC64E7C for ; Wed, 2 Dec 2020 18:25:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E9EBF22248 for ; Wed, 2 Dec 2020 18:25:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E9EBF22248 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=alien8.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=F6khh7dBfFmdwI2AL5PLFLzCZ7jvgKYwFUVWW0LKasU=; b=nVfCHqI6fyUfzUiEZL/wi88QQ yIl6DoA9hisLHzPQ49h/knVfwYkwmueuMaJsvS7SItKYudvUYzvXUYMXQ2oOob3k+3bvn+lMRB0y1 5qUnq+HpeDraKB5YLxiT5TaRq91xMAtbVILPjaJ+7f11P2du5YJDLX5moBZDLJswUAtPv1SoZeYKg mw6vVzVnqRkHj+gYnTQK5Dg3r6QvzS/iXVLXlj/DJRpvOL/Nl5WQPxJOCux1R1UpZMfNXL8xFosbG p3FJn/XSwSQNH/lGGTiJMr0Unnsse6LQe25ELyWGKZyQOPPiOLhIyUff2g1kYUdPRHa2zmo54xIMj Jq4GVaQDg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkWnL-0005QF-Mj; Wed, 02 Dec 2020 18:24:03 +0000 Received: from mail.skyhub.de ([2a01:4f8:190:11c2::b:1457]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkWnI-0005PB-Uc for linux-arm-kernel@lists.infradead.org; Wed, 02 Dec 2020 18:24:01 +0000 Received: from zn.tnic (p200300ec2f161b00329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ec:2f16:1b00:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 7193B1EC04DB; Wed, 2 Dec 2020 19:23:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1606933433; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=4K5oryCh4lYprceHfJITgYNxkJkNbvO0oAmzKtsMskk=; b=eyF7oJ8jzZXnSjEQtaZrUqi4mwuWKRWOIW9O8LaGm8MqDGJY2ivCpGoIYOt1Z6+twhPWwg BD27rstCZtNJappHLb/XnRJL/bLtkDIm1ccUAtRxsnvNQZrxM7nK48jtE06jmDLK5BhWQv ogqK7rU9rqVC++YIVNJfV+c9klFxF94= Date: Wed, 2 Dec 2020 19:23:49 +0100 From: Borislav Petkov To: Andrew Jeffery Subject: Re: [PATCH v2 3/3] edac: Supporting AST2400 and AST2600 edac driver Message-ID: <20201202182349.GJ2951@zn.tnic> References: <20201202063612.21241-1-troy_lee@aspeedtech.com> <20201202063612.21241-3-troy_lee@aspeedtech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201202_132401_124093_3EB2EFC5 X-CRM114-Status: GOOD ( 18.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Tony Luck , Ryan Chen , "moderated list:ARM/ASPEED MACHINE SUPPORT" , Troy Lee , open list , Rob Herring , "leetroy@gmail.com" , Robert Richter , James Morse , Joel Stanley , Stefan M Schaeckeler , Mauro Carvalho Chehab , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "open list:EDAC-CORE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Dec 03, 2020 at 01:32:44AM +1030, Andrew Jeffery wrote: > On Wed, 2 Dec 2020, at 19:11, Troy Lee wrote: > > Hi Joel, > > > > Thanks for the suggestion, I'll fix the review and create an new patch > > against > > latest Linux branch. Those exported function will be referenced in > > other driver yet > > to be upstream, so should I move those exported functions out of this > > patch? > > > > Yes, let's leave the exports out of this patch, and add them in when you send > the patch that depends on them. And when you do, almost all new exports are EXPORT_SYMBOL_GPL - not EXPORT_SYMBOL. Also, I'd like to see how those exports are going to be used. An EDAC driver function exported to another driver sounds strange. We have only one other case like this in the EDAC tree: drivers/edac/amd64_edac.c:554:EXPORT_SYMBOL_GPL(amd64_get_dram_hole_info); and even that is not really needed... Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel