From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 742F3C64E7C for ; Wed, 2 Dec 2020 19:26:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0858D205F4 for ; Wed, 2 Dec 2020 19:26:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0858D205F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ga6YkckI2pu+B3LfDJWI6zcdG6O1MD3RZ0w8n3GqHGE=; b=qBOxfYTHo0gdeAT4/wDuLWeyU VgQGR/Rm/IQlcriSfBE0lpkKDeTuv9B9UrtFJF+jqcvUJIonquVjtGfIZQO6kvrH8d5mn4Phwj+xO QrdEcrMA70JeX/HnDm6dBffvoOqtrBYBrfsl6Q6HR2RxTF73gy83wHn6p675AkoiM1jlysa6tFKKl bhNaHvOmYjNns+9726E5HmEQKAurguPYvTJpNgRH1qgbB0L3s+OT8G+psUF63/rThPzCvQ8zDhD28 txU6nyUUTz67ixzxTARo2h69DP6vF7K1LeJX/p4Kex8IyGL+QZdyMUTe0x/jndd/SMxS6cHh5P8s4 PWfMqRchw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkXl7-0001PZ-G7; Wed, 02 Dec 2020 19:25:49 +0000 Received: from mail-ed1-f65.google.com ([209.85.208.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkXl5-0001P0-2m for linux-arm-kernel@lists.infradead.org; Wed, 02 Dec 2020 19:25:48 +0000 Received: by mail-ed1-f65.google.com with SMTP id k4so5288777edl.0 for ; Wed, 02 Dec 2020 11:25:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=eYcaogqYzN6ZUt28+vyieuwTVixxxaeMvV8MlkHBuEo=; b=pQJNs57Tk86EgTGtUwZCtOC8+biQEx63gO5tlwe6fRX4i2wS8lkFlTWhNrRLnksBv3 MYXaBjZJ7fDFwitZMN93oN6/T2SOKhq3dnfYvG+KnvDaxWk5Kkdcm2kC4jnUuKlOxWQm IahR7omcYYbH5iHtrT5FkL3u+yvx5ljfpqr2Zvdca8m6gZKlgg/le/kZfZT3aJYsgQoH rkzWrnH1jpv3dhbemdEAxoqokpzP8WbOLRor0uw4udYCiPrebm+6IBbdzeg7AFhR7nDn W81rXSp2JWpPULNndEoPICpoRyypONey6M9iWklzZY6S29bTGwjsaoEtdrmaa+izvKlk ME0g== X-Gm-Message-State: AOAM530nwJrJiVOQzsFEo3U23/3NLrq56niLFBag/boGWCxIP+Z4h+Dn F9+PkTrw6ng2EJaMunoo/BY= X-Google-Smtp-Source: ABdhPJxagTWtEJZPAPkpLJVZKLSduip+7GVycNBghRDTPBs9MQMJGf/06IKdC4IlOggUC5dAuIsXnA== X-Received: by 2002:a50:e0ce:: with SMTP id j14mr1531711edl.18.1606937145269; Wed, 02 Dec 2020 11:25:45 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id c25sm533612ejx.39.2020.12.02.11.25.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Dec 2020 11:25:43 -0800 (PST) Date: Wed, 2 Dec 2020 21:25:42 +0200 From: Krzysztof Kozlowski To: Jagan Teki Subject: Re: [PATCH 08/10] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini C.TOUCH 2.0 Message-ID: <20201202192542.GA85884@kozik-lap> References: <20201202121241.109952-1-jagan@amarulasolutions.com> <20201202121241.109952-9-jagan@amarulasolutions.com> <20201202174538.GH3490@kozik-lap> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201202_142547_155246_40A95024 X-CRM114-Status: GOOD ( 36.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Matteo Lisi , Shawn Guo , linux-kernel , Li Yang , Rob Herring , NXP Linux Team , Fabio Estevam , linux-amarula , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Dec 03, 2020 at 12:50:37AM +0530, Jagan Teki wrote: > Hi Krzysztof, > > On Wed, Dec 2, 2020 at 11:15 PM Krzysztof Kozlowski wrote: > > > > On Wed, Dec 02, 2020 at 05:42:39PM +0530, Jagan Teki wrote: > > > i.Core MX8M Mini is an EDIMM SOM based on NXP i.MX8MM from Engicam. > > > > > > C.TOUCH 2.0 is a general purpose carrier board with capacitive > > > touch interface support. > > > > > > i.Core MX8M Mini needs to mount on top of this Carrier board for > > > creating complete i.Core MX8M Mini C.TOUCH 2.0 board. > > > > > > Add support for it. > > > > > > Signed-off-by: Matteo Lisi > > > Signed-off-by: Jagan Teki > > > --- > > > arch/arm64/boot/dts/freescale/Makefile | 1 + > > > .../imx8mm-engicam-icore-mx8mm-ctouch2.dts | 21 +++++++++++++++++++ > > > 2 files changed, 22 insertions(+) > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-icore-mx8mm-ctouch2.dts > > > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > > > index 4369d783dade..8191db4c64fa 100644 > > > --- a/arch/arm64/boot/dts/freescale/Makefile > > > +++ b/arch/arm64/boot/dts/freescale/Makefile > > > @@ -30,6 +30,7 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-rdb.dtb > > > dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2162a-qds.dtb > > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb > > > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-engicam-icore-mx8mm-ctouch2.dtb > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-engicam-icore-mx8mm-edimm2.2.dtb > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-icore-mx8mm-ctouch2.dts b/arch/arm64/boot/dts/freescale/imx8mm-engicam-icore-mx8mm-ctouch2.dts > > > new file mode 100644 > > > index 000000000000..aa3c03ad3109 > > > --- /dev/null > > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-icore-mx8mm-ctouch2.dts > > > @@ -0,0 +1,21 @@ > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > +/* > > > + * Copyright (c) 2019 NXP > > > + * Copyright (c) 2019 Engicam srl > > > + * Copyright (c) 2020 Amarula Solutions(India) > > > + */ > > > + > > > +/dts-v1/; > > > +#include "imx8mm.dtsi" > > > > You have multiple DTSI files to only include one DTSI. I was trying to > > follow the logic here but I failed... > > > > This is ctouch, so it should include SoM, which you call icore. But it > > also includes ctouch2 which *only* includes common DTSI. It's then > > exactly the same as starter kit which includes edimm (which includes > > common) and icore. > > I hope you have checked the cover letter where I have mentioned all > the combinations. > > 1. SoM, Starter Kit, Carrier Board, Open Frame are three different hardware. > > 2. i.Core MX8M Mini is SoM > > 3. EDIMM 2.2 is Starter Kit > > 4. C.TOUCH 2.0 is Carrier board > > 5. 10"1 Open Frame board for LVDS > > The combination of respective hardware mounting is, > > 1. SOM+Starter Kitt => i.Core MX8M Mini EDIMM 2.2 Starter Kit > > 2. SOM+C.TOUCH 2.0 => i.Core MX8M Mini C.TOUCH 2.0 Carrier board > > 3. SOM+C.TOUCH 2.0+10.1" OF => i.Core MX8M Mini C.TOUCH 2.0 10.1" Open > Frame board It does not explain why you created 3 empty DTSI and 2 empty DTS files. > > About the bindings, (please check the > arch/arm64/boot/dts/rockchip/px30-engicam-*), It's been discussed > before with Rob for these boards bindings. Refer to my specific comments about bindings. > > To, compare with what we have described with rockchip > > SoM binding, > - engicam,icore-mx8mm is binding for i.Core MX8M Mini SoM > - engicam,px30-core is binding for PX30.Core SoM > > EDIMM 2.2 is Starter Kit binding, > - engicam,icore-mx8mm-edimm2.2 is binding for EDIMM 2.2 is Starter Kit > in i.MX8MM > - engicam,px30-core-edimm2.2 is binding for EDIMM 2.2 is Starter Kit in PX30 > > C.TOUCH 2.0 is Carrier board binding, > - engicam,icore-mx8mm-ctouch2 is binding for C.TOUCH 2.0 is Carrier > board in i.MX8MM > - engicam,px30-core-ctouch2 is binding for C.TOUCH 2.0 is Carrier board in PX30 > > C.TOUCH 2.0 10"1 OF binding, > - engicam,icore-mx8mm-ctouch2-of10 is binding for C.TOUCH 2.0 10"1 in imx8MM > - engicam,px30-core-ctouch2-of10 for C.TOUCH 2.0 10"1 in PX30 > > So, there are 3 board combinations of which each board has a binding > of SoM and respective carrier binding like i.Core MX8M Mini EDIMM 2.2 > Starter Kit has > "engicam,icore-mx8mm-edimm2.2", "engicam,icore-mx8mm" > "engicam,icore-mx8mm-ctouch2", "engicam,icore-mx8mm" > "engicam,icore-mx8mm-ctouch2-of10", "engicam,icore-mx8mm" > > Some of the DTS files are using the engicam-common.dtsi nodes and for > ie reason those are empty and some need to have lvds display node > which is still underworking. Therefore add them when you have any contents for these DTS files. > > Hope this information helpful. Let me know for further inputs. Thanks for the information but it was not much helpful. It does not answer at all why you have so many empty files, why you include imx8mm.dtsi not in the SoM but somewhere else. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel