From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BF22C64E7C for ; Wed, 2 Dec 2020 19:56:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 83B0422201 for ; Wed, 2 Dec 2020 19:56:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83B0422201 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jwgZfFRWT92f8qHU9kANbeUbjacvo/GDrL0Ernt8Z+c=; b=y4lKCEZKueAZ6MvVTAv/YAmUh iNGIE15VB9rOpSfQpK2FaIgspeszkIh8KWAe9NvDQ6WIbe/4axrfKqPHVavghMuDwPZ2BsSaNc8gt BjK0crYCNGlKs81fpyUMDIyuoTJ91/8WFfmKEk/QnkNn936ppsrytAq+2OygDqavJFpEyI70P97I1 s2wDkocUVDrhkoKwdhC4MN6gODChKY5OgXjl7ULGaOIfVq2pt+zAM7RA3aKuEDg0OYu9VfSm+Avio vcZbc/evzxw7uBTZaoh0B9qAR0zE5E8mf5kYCnO1+1kK510XH6yHR1CAP/fQH2dZzYepv2vO/nN27 JbRrg1MnA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkYDX-0004w8-KP; Wed, 02 Dec 2020 19:55:11 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkYDT-0004vV-Dv for linux-arm-kernel@lists.infradead.org; Wed, 02 Dec 2020 19:55:08 +0000 Received: by mail-wr1-x443.google.com with SMTP id u12so5417966wrt.0 for ; Wed, 02 Dec 2020 11:55:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=aNoM4IqXq01bkYqDeaXvKaD1icGKLJmAsZsYIC/EEjw=; b=ng8PX7be85fBIRDsqYE2zkD2KjoUUeYc3nYCTOsEBVAJgWXQ0EekJzJgDH1HvMJ58j Cd80zkjNPVpvceNPjFfhIAB2str7ZUgMPKnEO51TgO1CGDgo9LgprsveY9uDos85Wi2M pJwtqo/ecUIbBcQz63XmF8c5ZP6jpT+JWwYv4k7bKX1pxW806yXYJmNsAV0TIzadjcv8 JsuVuzHJFDjZP8P4ISkLkZ+1vih8nbcOSh3gkf6r9cWGiHGsv47TLqgOkSL414hwGcao Ab23pYG/DdAUuFMJKhwhc27kQN+5KdFIcs+XDjyOH2XKp/AG4FcomOnjj6SOzoysQs+x KsUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=aNoM4IqXq01bkYqDeaXvKaD1icGKLJmAsZsYIC/EEjw=; b=l0IQ1r0o6w2TOvqjiOzfquLFP8JR6WTBeOrAn3pW4LaP3iVybDODBbiHTgYDY3EzAV 2YWga22G4ugt4buRZACNEdfr6N/nNqnn1gIN/On92spVTJv/lZEBZxBQw1CVbu2uckkc 8LDpCcHkf3qKpaLmE0+FB7RHPCmhrS1l/V+lByvOsLO+QlCzcBedZbGG7ULIACCc8Ui8 0l6V7wyW7k/CMF43vwTuXqOXpy5Sas2cct3mZi9nednMPSzxLHO1YGIQdJnZCJ7D6ATk cSoNUj6Qvo77n7VFSpg2s5CtaJf7o++xvIdZl22bxpGurVj9vKVzx8GpIyQAiIWPy+51 Q6vA== X-Gm-Message-State: AOAM532VJCZ4Gsu4PAQMe1cfFlOsp2nzAynvoHmY4UT1NdEXueTZH0R1 QJsKTq7C//6U8VKGnUN7oeE= X-Google-Smtp-Source: ABdhPJwqHIvBAF/G9nJcz8Xpe9GT5cHM1NQLRanGpFHTUuVOnBsdr0JkdgVIjMsZpZ5B6JhN+dvajA== X-Received: by 2002:adf:ec0d:: with SMTP id x13mr5482267wrn.207.1606938904915; Wed, 02 Dec 2020 11:55:04 -0800 (PST) Received: from Red ([2a01:cb1d:3d5:a100:264b:feff:fe03:2806]) by smtp.googlemail.com with ESMTPSA id i11sm3277356wro.85.2020.12.02.11.55.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Dec 2020 11:55:04 -0800 (PST) Date: Wed, 2 Dec 2020 20:55:01 +0100 From: Corentin Labbe To: Thomas Gleixner Subject: Re: crypto: sun4i-ss: error with kmap Message-ID: <20201202195501.GA29296@Red> References: <20201201130102.GA23461@Red> <87ft4phcyx.fsf@nanos.tec.linutronix.de> <20201201135252.GA9584@Red> <87y2ihfw6z.fsf@nanos.tec.linutronix.de> <20201201144529.GA6786@Red> <87v9dlfthf.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87v9dlfthf.fsf@nanos.tec.linutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201202_145507_589980_0B7AB45A X-CRM114-Status: GOOD ( 24.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: herbert@gondor.apana.org.au, linux-kernel@vger.kernel.org, mripard@kernel.org, wens@csie.org, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 01, 2020 at 04:15:08PM +0100, Thomas Gleixner wrote: > On Tue, Dec 01 2020 at 15:45, Corentin Labbe wrote: > > On Tue, Dec 01, 2020 at 03:16:36PM +0100, Thomas Gleixner wrote: > > In fact the warn was a bit later so I added: > > preempt_disable(); > > idx = arch_kmap_local_unmap_idx(kmap_local_idx(), addr); > > - WARN_ON_ONCE(addr != __fix_to_virt(FIX_KMAP_BEGIN + idx)); > > + if (WARN_ON_ONCE(addr != __fix_to_virt(FIX_KMAP_BEGIN + idx))) > > + pr_err("kunmap_local: vaddr %lx\n", (unsigned long) vaddr); > > > > arch_kmap_local_pre_unmap(addr); > > pte_clear(&init_mm, addr, kmap_pte - idx); > > > > and this give kunmap_local: vaddr ffefe000 > > which looks like a valid one. > > Can you apply the patch below and add 'ftrace_dump_on_oops' on the > command line or enable it in /proc/sys/kernel/ftrace_dump_on_oops before > starting the test. > > That should spill out the trace after crashing. > > Thanks, > > tglx > --- > diff --git a/mm/highmem.c b/mm/highmem.c > index b49364a306b8..461fe2c26107 100644 > --- a/mm/highmem.c > +++ b/mm/highmem.c > @@ -485,6 +485,7 @@ static inline bool kmap_high_unmap_local(unsigned long vaddr) > { > #ifdef ARCH_NEEDS_KMAP_HIGH_GET > if (vaddr >= PKMAP_ADDR(0) && vaddr < PKMAP_ADDR(LAST_PKMAP)) { > + trace_printk("kunmap_high: %lx\n", vaddr); > kunmap_high(pte_page(pkmap_page_table[PKMAP_NR(vaddr)])); > return true; > } > @@ -520,6 +521,7 @@ void *__kmap_local_pfn_prot(unsigned long pfn, pgprot_t prot) > preempt_disable(); > idx = arch_kmap_local_map_idx(kmap_local_idx_push(), pfn); > vaddr = __fix_to_virt(FIX_KMAP_BEGIN + idx); > + trace_printk("kmap_local_pfn: %d %lx\n", idx, (unsigned long) vaddr); > BUG_ON(!pte_none(*(kmap_pte - idx))); > pteval = pfn_pte(pfn, prot); > set_pte_at(&init_mm, vaddr, kmap_pte - idx, pteval); > @@ -545,8 +547,10 @@ void *__kmap_local_page_prot(struct page *page, pgprot_t prot) > > /* Try kmap_high_get() if architecture has it enabled */ > kmap = arch_kmap_local_high_get(page); > - if (kmap) > + if (kmap) { > + trace_printk("kmap_local_high_get: %lx\n", (unsigned long) kmap); > return kmap; > + } > > return __kmap_local_pfn_prot(page_to_pfn(page), prot); > } > @@ -578,6 +582,7 @@ void kunmap_local_indexed(void *vaddr) > > preempt_disable(); > idx = arch_kmap_local_unmap_idx(kmap_local_idx(), addr); > + trace_printk("kunmap_local: %i %lx\n", idx, (unsigned long) vaddr); > WARN_ON_ONCE(addr != __fix_to_virt(FIX_KMAP_BEGIN + idx)); > > arch_kmap_local_pre_unmap(addr); > The result could be seen at http://kernel.montjoie.ovh/129768.log The log is 9Mb, but the ftrace dump seems not terminated, tell me if you need more. Regards _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel