From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AACE9C64E7A for ; Thu, 3 Dec 2020 13:27:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3B7C325259 for ; Thu, 3 Dec 2020 13:27:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B7C325259 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bgNtrR/YB0jb44/KiFhIgnQJ15YJ8AFQ7RJWIxGkfMM=; b=1ghaeyOQAiWnT+Nui1frl36un o1SnEe/pYSqN3A/LdLtekA1bawqK2j1MPx8Xe54TUVPn2DwsEmpbdr2SxUQBM9nCqCKxljY+o2M1k FVN4Jo1X/6qaMY4ZVhcdyRQY7V3CXoJgYn+kfa2ohb3JxQxRPbuIskX71PUlTBC+wueh0dtOCcEyi OgDxDmk2foBRD9SMIqjI2qZhXrHcRu+ZqFn5QP1kHGQ7QJMTj/o5MA78DprCRanpqSdJppUhxk4Mo kdkAdc+5MjgfnpXcOM9wA60D1YBvV3HB+BbEJLuH6KaXG20YEKob17C7CntkBOZLBvFEBJ1AGhMT5 DM2JiyryA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkocW-0000u9-NL; Thu, 03 Dec 2020 13:26:04 +0000 Received: from new4-smtp.messagingengine.com ([66.111.4.230]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkocM-0000pN-6q; Thu, 03 Dec 2020 13:25:56 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 55F6E58040E; Thu, 3 Dec 2020 08:25:48 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 03 Dec 2020 08:25:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm1; bh=90XNSE2gFpYOo BrkrrVTSK1qJNmeSfYrGPvxUj62/YE=; b=sdKcuB7bPk9Fo/Sf8FIivYRbDria+ Q5/BRAOosPXn6KQX3LkvooRxh3RNxHMg/IQwy9LVlOzHyV/caFhC3ANHpSV8EByg 9Zw5uJReKVGzIIHVSVGhw/GeuWSMhcJtrIFOzH8pO5LnxdCSTRxC7Ttqu9xFTKmq QFJwesP9gEvRmAF7KHUXfg/N2aXH/F8j4ScWl4BWLcr4TFVGUBjS078IXa9RD6+S 56HsD69UXFqnL93tCIqaBZ9SeVi5Ws/qFvOFSxiPMuuublrb9x7QoLORxYWjJ38G 8W9b/hv5YVqB1EWu1x1Ns4R5/ltkq1V1+Ot0qFZXz08No+0aiOj7Y+5mg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=90XNSE2gFpYOoBrkrrVTSK1qJNmeSfYrGPvxUj62/YE=; b=ocdAm6Nm ZHRSXT+AqoBzmKNjxKeL87gbVz0QtcMi+Y649IIuoeHDDWRunz+k6Oz8utIwSN+3 rtTifSS4Be8/3pxkhC6fOb8FektjGwmTjYPQEr8r+gBz1JR02MWE83rAORh4t/sF xNA3evcwS2s6ZYjrjGkoC0NU11xat4jRR8+HqOJrkiySjGU81b+VTZ2Tcsg+Md1P NUtt5RphKRfCS0us745KFQke8P8uhyPXbdmeRmYIOZGs0Ka1X9D/lIlTnvkFcpn/ TLkXm3zkQJiXvQFQTKX+29Y4omfPYxtY0Se+XBljcf4cfA6QiebV3HDvVGIWRGh6 JZcctqlwFTsJ3A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudeiiedgheefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepvdekleevfeffkeejhfffueelteelfeduieefheduudfggffhhfffheevveeh hedvnecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id D83B1240062; Thu, 3 Dec 2020 08:25:47 -0500 (EST) From: Maxime Ripard To: Eric Anholt , Maarten Lankhorst , Thomas Zimmermann , Maxime Ripard , Daniel Vetter , David Airlie Subject: [PATCH 2/8] drm/vc4: dsi: Correct DSI register definition Date: Thu, 3 Dec 2020 14:25:37 +0100 Message-Id: <20201203132543.861591-3-maxime@cerno.tech> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201203132543.861591-1-maxime@cerno.tech> References: <20201203132543.861591-1-maxime@cerno.tech> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201203_082554_376990_C714255C X-CRM114-Status: GOOD ( 11.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Dave Stevenson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Dave Stevenson The DSI1_PHY_AFEC0_PD_DLANE1 and DSI1_PHY_AFEC0_PD_DLANE3 register definitions were swapped, so trying to use more than a single data lane failed as lane 1 would get powered down. (In theory a 4 lane device would work as all lanes would remain powered). Correct the definitions. Signed-off-by: Dave Stevenson Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_dsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c index b1d8765795f1..bb316e6cc12b 100644 --- a/drivers/gpu/drm/vc4/vc4_dsi.c +++ b/drivers/gpu/drm/vc4/vc4_dsi.c @@ -306,11 +306,11 @@ # define DSI0_PHY_AFEC0_RESET BIT(11) # define DSI1_PHY_AFEC0_PD_BG BIT(11) # define DSI0_PHY_AFEC0_PD BIT(10) -# define DSI1_PHY_AFEC0_PD_DLANE3 BIT(10) +# define DSI1_PHY_AFEC0_PD_DLANE1 BIT(10) # define DSI0_PHY_AFEC0_PD_BG BIT(9) # define DSI1_PHY_AFEC0_PD_DLANE2 BIT(9) # define DSI0_PHY_AFEC0_PD_DLANE1 BIT(8) -# define DSI1_PHY_AFEC0_PD_DLANE1 BIT(8) +# define DSI1_PHY_AFEC0_PD_DLANE3 BIT(8) # define DSI_PHY_AFEC0_PTATADJ_MASK VC4_MASK(7, 4) # define DSI_PHY_AFEC0_PTATADJ_SHIFT 4 # define DSI_PHY_AFEC0_CTATADJ_MASK VC4_MASK(3, 0) -- 2.28.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel