From: Catalin Marinas <catalin.marinas@arm.com>
To: Peter Collingbourne <pcc@google.com>
Cc: Andrey Konovalov <andreyknvl@google.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm64: mte: remove an ISB on kernel exit
Date: Thu, 3 Dec 2020 14:41:21 +0000 [thread overview]
Message-ID: <20201203144120.GA2830@gaia> (raw)
In-Reply-To: <20201203073458.2675400-1-pcc@google.com>
On Wed, Dec 02, 2020 at 11:34:58PM -0800, Peter Collingbourne wrote:
> This ISB is unnecessary because we will soon do an ERET.
>
> Signed-off-by: Peter Collingbourne <pcc@google.com>
> Link: https://linux-review.googlesource.com/id/I69f1ee6bb09b1372dd744a0e01cedaf090c8d448
> ---
> arch/arm64/kernel/entry.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/kernel/entry.S b/arch/arm64/kernel/entry.S
> index 07646ef4f184..f8ad8d7fb1a2 100644
> --- a/arch/arm64/kernel/entry.S
> +++ b/arch/arm64/kernel/entry.S
> @@ -182,7 +182,6 @@ alternative_else_nop_endif
> mrs_s \tmp2, SYS_GCR_EL1
> bfi \tmp2, \tmp, #0, #16
> msr_s SYS_GCR_EL1, \tmp2
> - isb
> #endif
> .endm
>
> @@ -194,6 +193,7 @@ alternative_else_nop_endif
> ldr_l \tmp, gcr_kernel_excl
>
> mte_set_gcr \tmp, \tmp2
> + isb
> 1:
> #endif
> .endm
It makes sense. I'll apply it after -rc1 once the MTE+kasan patches go
in.
Thanks.
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-03 14:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 7:34 [PATCH] arm64: mte: remove an ISB on kernel exit Peter Collingbourne
2020-12-03 14:41 ` Catalin Marinas [this message]
2021-01-04 11:49 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201203144120.GA2830@gaia \
--to=catalin.marinas@arm.com \
--cc=andreyknvl@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=pcc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).