* [PATCH] arm64: mte: remove an ISB on kernel exit
@ 2020-12-03 7:34 Peter Collingbourne
2020-12-03 14:41 ` Catalin Marinas
2021-01-04 11:49 ` Catalin Marinas
0 siblings, 2 replies; 3+ messages in thread
From: Peter Collingbourne @ 2020-12-03 7:34 UTC (permalink / raw)
To: Andrey Konovalov, Catalin Marinas; +Cc: Peter Collingbourne, Linux ARM
This ISB is unnecessary because we will soon do an ERET.
Signed-off-by: Peter Collingbourne <pcc@google.com>
Link: https://linux-review.googlesource.com/id/I69f1ee6bb09b1372dd744a0e01cedaf090c8d448
---
arch/arm64/kernel/entry.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/kernel/entry.S b/arch/arm64/kernel/entry.S
index 07646ef4f184..f8ad8d7fb1a2 100644
--- a/arch/arm64/kernel/entry.S
+++ b/arch/arm64/kernel/entry.S
@@ -182,7 +182,6 @@ alternative_else_nop_endif
mrs_s \tmp2, SYS_GCR_EL1
bfi \tmp2, \tmp, #0, #16
msr_s SYS_GCR_EL1, \tmp2
- isb
#endif
.endm
@@ -194,6 +193,7 @@ alternative_else_nop_endif
ldr_l \tmp, gcr_kernel_excl
mte_set_gcr \tmp, \tmp2
+ isb
1:
#endif
.endm
--
2.29.2.454.gaff20da3a2-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: mte: remove an ISB on kernel exit
2020-12-03 7:34 [PATCH] arm64: mte: remove an ISB on kernel exit Peter Collingbourne
@ 2020-12-03 14:41 ` Catalin Marinas
2021-01-04 11:49 ` Catalin Marinas
1 sibling, 0 replies; 3+ messages in thread
From: Catalin Marinas @ 2020-12-03 14:41 UTC (permalink / raw)
To: Peter Collingbourne; +Cc: Andrey Konovalov, Linux ARM
On Wed, Dec 02, 2020 at 11:34:58PM -0800, Peter Collingbourne wrote:
> This ISB is unnecessary because we will soon do an ERET.
>
> Signed-off-by: Peter Collingbourne <pcc@google.com>
> Link: https://linux-review.googlesource.com/id/I69f1ee6bb09b1372dd744a0e01cedaf090c8d448
> ---
> arch/arm64/kernel/entry.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/kernel/entry.S b/arch/arm64/kernel/entry.S
> index 07646ef4f184..f8ad8d7fb1a2 100644
> --- a/arch/arm64/kernel/entry.S
> +++ b/arch/arm64/kernel/entry.S
> @@ -182,7 +182,6 @@ alternative_else_nop_endif
> mrs_s \tmp2, SYS_GCR_EL1
> bfi \tmp2, \tmp, #0, #16
> msr_s SYS_GCR_EL1, \tmp2
> - isb
> #endif
> .endm
>
> @@ -194,6 +193,7 @@ alternative_else_nop_endif
> ldr_l \tmp, gcr_kernel_excl
>
> mte_set_gcr \tmp, \tmp2
> + isb
> 1:
> #endif
> .endm
It makes sense. I'll apply it after -rc1 once the MTE+kasan patches go
in.
Thanks.
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: mte: remove an ISB on kernel exit
2020-12-03 7:34 [PATCH] arm64: mte: remove an ISB on kernel exit Peter Collingbourne
2020-12-03 14:41 ` Catalin Marinas
@ 2021-01-04 11:49 ` Catalin Marinas
1 sibling, 0 replies; 3+ messages in thread
From: Catalin Marinas @ 2021-01-04 11:49 UTC (permalink / raw)
To: Peter Collingbourne, Andrey Konovalov; +Cc: Will Deacon, Linux ARM
On Wed, 2 Dec 2020 23:34:58 -0800, Peter Collingbourne wrote:
> This ISB is unnecessary because we will soon do an ERET.
Applied to arm64 (for-next/fixes), thanks!
[1/1] arm64: mte: remove an ISB on kernel exit
https://git.kernel.org/arm64/c/b614231dec78
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-04 11:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-03 7:34 [PATCH] arm64: mte: remove an ISB on kernel exit Peter Collingbourne
2020-12-03 14:41 ` Catalin Marinas
2021-01-04 11:49 ` Catalin Marinas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).