* [PATCH] phy: mediatek: allow compile-testing the hdmi phy
@ 2020-12-03 22:54 Arnd Bergmann
2020-12-04 1:47 ` Chunfeng Yun
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2020-12-03 22:54 UTC (permalink / raw)
To: Chunfeng Yun, Kishon Vijay Abraham I, Vinod Koul,
Matthias Brugger, Chun-Kuang Hu, CK Hu
Cc: Florian Fainelli, Arnd Bergmann, linux-kernel,
Krzysztof Kozlowski, linux-mediatek, linux-arm-kernel
From: Arnd Bergmann <arnd@arndb.de>
Compile-testing the DRM_MEDIATEK_HDMI driver leads to a harmless
warning:
WARNING: unmet direct dependencies detected for PHY_MTK_HDMI
Depends on [n]: ARCH_MEDIATEK [=n] && OF [=y]
Selected by [y]:
- DRM_MEDIATEK_HDMI [=y] && HAS_IOMEM [=y] && DRM_MEDIATEK [=y]
The driver builds fine, so allow compile-testing it as well
to get rid of the warning.
Fixes: b28be59a2e26 ("phy: mediatek: Move mtk_hdmi_phy driver into drivers/phy/mediatek folder")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/phy/mediatek/Kconfig | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/phy/mediatek/Kconfig b/drivers/phy/mediatek/Kconfig
index 65ed26e40c9f..29a85b2738f8 100644
--- a/drivers/phy/mediatek/Kconfig
+++ b/drivers/phy/mediatek/Kconfig
@@ -40,7 +40,9 @@ config PHY_MTK_XSPHY
config PHY_MTK_HDMI
tristate "MediaTek HDMI-PHY Driver"
- depends on ARCH_MEDIATEK && OF
+ depends on ARCH_MEDIATEK || COMPILE_TEST
+ depends on COMMON_CLK
+ depends on OF
select GENERIC_PHY
help
Support HDMI PHY for Mediatek SoCs.
--
2.27.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] phy: mediatek: allow compile-testing the hdmi phy
2020-12-03 22:54 [PATCH] phy: mediatek: allow compile-testing the hdmi phy Arnd Bergmann
@ 2020-12-04 1:47 ` Chunfeng Yun
2020-12-04 13:53 ` Arnd Bergmann
0 siblings, 1 reply; 3+ messages in thread
From: Chunfeng Yun @ 2020-12-04 1:47 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Chun-Kuang Hu, Florian Fainelli, Arnd Bergmann, linux-kernel,
Krzysztof Kozlowski, Kishon Vijay Abraham I, CK Hu, Vinod Koul,
linux-mediatek, Matthias Brugger, linux-arm-kernel
On Thu, 2020-12-03 at 23:54 +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Compile-testing the DRM_MEDIATEK_HDMI driver leads to a harmless
> warning:
>
> WARNING: unmet direct dependencies detected for PHY_MTK_HDMI
> Depends on [n]: ARCH_MEDIATEK [=n] && OF [=y]
> Selected by [y]:
> - DRM_MEDIATEK_HDMI [=y] && HAS_IOMEM [=y] && DRM_MEDIATEK [=y]
>
> The driver builds fine, so allow compile-testing it as well
> to get rid of the warning.
>
> Fixes: b28be59a2e26 ("phy: mediatek: Move mtk_hdmi_phy driver into drivers/phy/mediatek folder")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/phy/mediatek/Kconfig | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/phy/mediatek/Kconfig b/drivers/phy/mediatek/Kconfig
> index 65ed26e40c9f..29a85b2738f8 100644
> --- a/drivers/phy/mediatek/Kconfig
> +++ b/drivers/phy/mediatek/Kconfig
> @@ -40,7 +40,9 @@ config PHY_MTK_XSPHY
>
> config PHY_MTK_HDMI
> tristate "MediaTek HDMI-PHY Driver"
> - depends on ARCH_MEDIATEK && OF
> + depends on ARCH_MEDIATEK || COMPILE_TEST
> + depends on COMMON_CLK
Seems no need add COMMON_CLK here
> + depends on OF
> select GENERIC_PHY
> help
> Support HDMI PHY for Mediatek SoCs.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] phy: mediatek: allow compile-testing the hdmi phy
2020-12-04 1:47 ` Chunfeng Yun
@ 2020-12-04 13:53 ` Arnd Bergmann
0 siblings, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2020-12-04 13:53 UTC (permalink / raw)
To: Chunfeng Yun
Cc: Chun-Kuang Hu, Florian Fainelli, Arnd Bergmann,
linux-kernel@vger.kernel.org, Krzysztof Kozlowski,
Kishon Vijay Abraham I, CK Hu, Vinod Koul,
moderated list:ARM/Mediatek SoC..., Matthias Brugger, Linux ARM
On Fri, Dec 4, 2020 at 2:47 AM Chunfeng Yun <chunfeng.yun@mediatek.com> wrote:
> > diff --git a/drivers/phy/mediatek/Kconfig b/drivers/phy/mediatek/Kconfig
> > index 65ed26e40c9f..29a85b2738f8 100644
> > --- a/drivers/phy/mediatek/Kconfig
> > +++ b/drivers/phy/mediatek/Kconfig
> > @@ -40,7 +40,9 @@ config PHY_MTK_XSPHY
> >
> > config PHY_MTK_HDMI
> > tristate "MediaTek HDMI-PHY Driver"
> > - depends on ARCH_MEDIATEK && OF
> > + depends on ARCH_MEDIATEK || COMPILE_TEST
> > + depends on COMMON_CLK
> Seems no need add COMMON_CLK here
My mistake, I had squashed two build fixes for the same driver but
forgot to update the changelog with the other output. This is what
happens without CONFIG_COMMON_CLK:
arm-linux-gnueabi-ld: drivers/phy/mediatek/phy-mtk-hdmi.o: in function
`mtk_hdmi_phy_probe':
phy-mtk-hdmi.c:(.text+0xd8): undefined reference to `__clk_get_name'
arm-linux-gnueabi-ld: phy-mtk-hdmi.c:(.text+0x12c): undefined
reference to `devm_clk_register'
arm-linux-gnueabi-ld: phy-mtk-hdmi.c:(.text+0x250): undefined
reference to `of_clk_add_provider'
arm-linux-gnueabi-ld: phy-mtk-hdmi.c:(.text+0x298): undefined
reference to `of_clk_src_simple_get'
I'll resend with that added in.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-04 13:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-03 22:54 [PATCH] phy: mediatek: allow compile-testing the hdmi phy Arnd Bergmann
2020-12-04 1:47 ` Chunfeng Yun
2020-12-04 13:53 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).