* [PATCH] clk: samsung: mark PM functions as __maybe_unused
@ 2020-12-03 22:53 Arnd Bergmann
2020-12-04 8:36 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2020-12-03 22:53 UTC (permalink / raw)
To: Sylwester Nawrocki, Tomasz Figa, Chanwoo Choi, Michael Turquette,
Stephen Boyd, Krzysztof Kozlowski
Cc: linux-arm-kernel, linux-samsung-soc, linux-clk, Arnd Bergmann,
linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
drivers/clk/samsung/clk-exynos-clkout.c:219:12: error: 'exynos_clkout_resume' defined but not used [-Werror=unused-function]
219 | static int exynos_clkout_resume(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~~
drivers/clk/samsung/clk-exynos-clkout.c:210:12: error: 'exynos_clkout_suspend' defined but not used [-Werror=unused-function]
210 | static int exynos_clkout_suspend(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/clk/samsung/clk-exynos-clkout.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/samsung/clk-exynos-clkout.c b/drivers/clk/samsung/clk-exynos-clkout.c
index 9ec2f40cc400..e6d6cbf8c4e6 100644
--- a/drivers/clk/samsung/clk-exynos-clkout.c
+++ b/drivers/clk/samsung/clk-exynos-clkout.c
@@ -207,7 +207,7 @@ static int exynos_clkout_remove(struct platform_device *pdev)
return 0;
}
-static int exynos_clkout_suspend(struct device *dev)
+static int __maybe_unused exynos_clkout_suspend(struct device *dev)
{
struct exynos_clkout *clkout = dev_get_drvdata(dev);
@@ -216,7 +216,7 @@ static int exynos_clkout_suspend(struct device *dev)
return 0;
}
-static int exynos_clkout_resume(struct device *dev)
+static int __maybe_unused exynos_clkout_resume(struct device *dev)
{
struct exynos_clkout *clkout = dev_get_drvdata(dev);
--
2.27.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] clk: samsung: mark PM functions as __maybe_unused
2020-12-03 22:53 [PATCH] clk: samsung: mark PM functions as __maybe_unused Arnd Bergmann
@ 2020-12-04 8:36 ` Krzysztof Kozlowski
2020-12-04 9:13 ` Arnd Bergmann
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2020-12-04 8:36 UTC (permalink / raw)
To: Arnd Bergmann
Cc: linux-samsung-soc, Arnd Bergmann, Stephen Boyd, Michael Turquette,
Tomasz Figa, linux-kernel, Chanwoo Choi, Sylwester Nawrocki,
linux-clk, linux-arm-kernel
On Thu, Dec 03, 2020 at 11:53:11PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
I understand this happens with !PM builds. It would be good to mention
this in commit msg. With commit msg improved:
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
> drivers/clk/samsung/clk-exynos-clkout.c:219:12: error: 'exynos_clkout_resume' defined but not used [-Werror=unused-function]
> 219 | static int exynos_clkout_resume(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~~~
> drivers/clk/samsung/clk-exynos-clkout.c:210:12: error: 'exynos_clkout_suspend' defined but not used [-Werror=unused-function]
> 210 | static int exynos_clkout_suspend(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/clk/samsung/clk-exynos-clkout.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/samsung/clk-exynos-clkout.c b/drivers/clk/samsung/clk-exynos-clkout.c
> index 9ec2f40cc400..e6d6cbf8c4e6 100644
> --- a/drivers/clk/samsung/clk-exynos-clkout.c
> +++ b/drivers/clk/samsung/clk-exynos-clkout.c
> @@ -207,7 +207,7 @@ static int exynos_clkout_remove(struct platform_device *pdev)
> return 0;
> }
>
> -static int exynos_clkout_suspend(struct device *dev)
> +static int __maybe_unused exynos_clkout_suspend(struct device *dev)
> {
> struct exynos_clkout *clkout = dev_get_drvdata(dev);
>
> @@ -216,7 +216,7 @@ static int exynos_clkout_suspend(struct device *dev)
> return 0;
> }
>
> -static int exynos_clkout_resume(struct device *dev)
> +static int __maybe_unused exynos_clkout_resume(struct device *dev)
> {
> struct exynos_clkout *clkout = dev_get_drvdata(dev);
>
> --
> 2.27.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] clk: samsung: mark PM functions as __maybe_unused
2020-12-04 8:36 ` Krzysztof Kozlowski
@ 2020-12-04 9:13 ` Arnd Bergmann
0 siblings, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2020-12-04 9:13 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES,
Arnd Bergmann, Stephen Boyd, Michael Turquette, Tomasz Figa,
linux-kernel@vger.kernel.org, Chanwoo Choi, Sylwester Nawrocki,
linux-clk, Linux ARM
On Fri, Dec 4, 2020 at 9:36 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Thu, Dec 03, 2020 at 11:53:11PM +0100, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
>
> I understand this happens with !PM builds. It would be good to mention
> this in commit msg. With commit msg improved:
>
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Thanks for taking a look.
I had meant to add a changelog text and failed to notice that this only
had the warning message and neither a Fixes tag nor a description when
I sent it out.
v2 coming.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-04 9:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-03 22:53 [PATCH] clk: samsung: mark PM functions as __maybe_unused Arnd Bergmann
2020-12-04 8:36 ` Krzysztof Kozlowski
2020-12-04 9:13 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).