From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D115C433FE for ; Fri, 4 Dec 2020 09:28:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D10A225AB for ; Fri, 4 Dec 2020 09:28:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D10A225AB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WlHEca+L7jve55IRHmrYE5fNO5LGL35/zcY8usKzR/I=; b=m3cyUzqX8OzncdqcQ7WDMgQPu He/2hiZuTIpHI4iQL0PhqWel+lROqBNrsOnzDAXWaAZXPdK2k+9+fNbitzU+n80gFiTbtQdPKgJ/Z UNMCwcC+2DMeLldeXmhCWsOEzHNIx3VU4gXmGgFteycP7Qe2wByhTOs6qt4VTAYzKTTUoHAxXuk45 88qZkdN1jwGtqHZaApXAfaszEQUgTTHyLQCKv1mE4OijfQnDnrkyUvax6pu5ysXdEJERiRconkCKY edwFs1Q1CI/UgJFuN9PHbMvHj/zQfFm0OUB9UN0N2bQo62WhTJ/QAhUJ9WRgms9K6mwCP8q5RJL8s sdkeg2KCg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kl7N2-0005xA-FM; Fri, 04 Dec 2020 09:27:20 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kl7Mz-0005wl-SO for linux-arm-kernel@lists.infradead.org; Fri, 04 Dec 2020 09:27:18 +0000 Date: Fri, 4 Dec 2020 09:27:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607074037; bh=tPpTC9bhjEVC0buQbJ+dbgcUuj+eIqVrhNolNhZi/CI=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=UwiVTr5JnpOgoH6ylOS9zHMRAAIc3D+H0fU8Qf7/R91fAOtiXYYHvNBOswxFDlUX6 eB5U31VJUyLgces75b4hOKJin38ki4Dx6fUrLU+W16RKrFdIiqjf3r3VfufoycFpxz 5rwdfcF9ocNDiJxkiqajvK9uJ4QgtIRX1q/fpppSLXbrkCMT09I+SoNfx97FIZsHIn szc2V14UjvLNE3SHkx3vRep5t4omptB5z1HDyhzjnEkN++vjgjcyi7JrYGZBol7VEr SPiGA8S97kQDsdNHx6lzAIiTx0Y7eH5DvSUDvMu34V5P0HQiFpoPUQ+ZJCTnZxIZLe IUvlAl2kxI/0g== From: Will Deacon To: Arnd Bergmann Subject: Re: [PATCH] arm64: fix HARDLOCKUP_DETECTOR dependency Message-ID: <20201204092711.GA461@willie-the-truck> References: <20201203222800.1009987-1-arnd@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201203222800.1009987-1-arnd@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201204_042718_031056_E0406DBA X-CRM114-Status: GOOD ( 18.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sumit Garg , Arnd Bergmann , Catalin Marinas , linux-kernel@vger.kernel.org, Mark Brown , Andrew Morton , Vincenzo Frascino , Alexandru Elisei , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Arnd, On Thu, Dec 03, 2020 at 11:27:26PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > When CONFIG_HW_PERF_EVENTS is disabled, the hardware lockup detector > fails to link: > > ld.lld: error: undefined symbol: hw_nmi_get_sample_period > >>> referenced by watchdog_hld.c > >>> watchdog_hld.o:(hardlockup_detector_event_create) in archive kernel/built-in.a > > Fix the dependency to refer to the Kconfig symbol that actually controls > the feature. > > Fixes: 367c820ef080 ("arm64: Enable perf events based hard lockup detector") > Signed-off-by: Arnd Bergmann > --- > arch/arm64/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 7599ad86e9a8..ecd900ad7755 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -176,7 +176,7 @@ config ARM64 > select HAVE_PATA_PLATFORM > select HAVE_PERF_EVENTS > select HAVE_PERF_EVENTS_NMI if ARM64_PSEUDO_NMI > - select HAVE_HARDLOCKUP_DETECTOR_PERF if PERF_EVENTS && HAVE_PERF_EVENTS_NMI > + select HAVE_HARDLOCKUP_DETECTOR_PERF if HW_PERF_EVENTS && HAVE_PERF_EVENTS_NMI > select HAVE_PERF_REGS > select HAVE_PERF_USER_STACK_DUMP > select HAVE_REGS_AND_STACK_ACCESS_API Cheers, although I already have a fix for this one queued locally [1]. I'll push it out in sec (ran out of time yesterday). Will [1] https://lore.kernel.org/r/202012031509.4O5ZoWNI-lkp@intel.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel