Re: [PATCH 1/2] dt-bindings: phy: add Amlogic G12A Analog MIPI D-PHY bindings

Neil Armstrong
2020-12-08T07:54:30Z

On 07/12/2020 23:44, Rob Herring wrote:
> On Mon, Nov 23, 2020 at 03:51:56PM +0100, Neil Armstrong wrote:
>> The Amlogic G12A SoCs embeds an Analog MIPI D-PHY to communicate with DSI
>> panels, this adds the bindings.
>>
>> This Analog D-PHY works with a separate Digital MIPI D-PHY.
>>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> ---
>> .../phy/amlogic,g12a-mipi-dphy-analog.yaml | 40 +++++++++++++++++++
>> 1 file changed, 40 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/phy/amlogic,g12a-mipi-dphy-analog.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/phy/amlogic,g12a-mipi-dphy-analog.yaml b/Documentation/devicetree/bindings/phy/amlogic,g12a-mipi-dphy-analog.yaml
>> new file mode 100644
>> index 000000000000..28663552f05b
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/phy/amlogic,g12a-mipi-dphy-analog.yaml
>> @@ -0,0 +1,40 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: "http://devicetree.org/schemas/phy/amlogic,g12a-mipi-dphy-analog.yaml#"
>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
>> +
>> +title: Amlogic G12A MIPI analog PHY
>> +
>> +maintainers:
>> + - Neil Armstrong <narmstrong@baylibre.com>
>> +
>> +description: |+
>> + The Everything-Else Power Domains node should be the child of a syscon
>
> Everything-Else Power Domains node??

Indeed, it's a typo

>
>> + node with the required property:
>> +
>> + - compatible: Should be the following:
>> + "amlogic,meson-gx-hhi-sysctrl", "simple-mfd", "syscon"
>> +
>> + Refer to the the bindings described in
>> + Documentation/devicetree/bindings/mfd/syscon.yaml
>> +
>> +properties:
>> + compatible:
>> + const: amlogic,g12a-mipi-dphy-analog
>> +
>> + "#phy-cells":
>> + const: 0
>> +
>> +required:
>> + - compatible
>> + - "#phy-cells"
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + mpphy: phy {
>> + compatible = "amlogic,g12a-mipi-dphy-analog";
>> + #phy-cells = <0>;
>> + };
>> --
>> 2.25.1
>>