From: Sean Young <sean@mess.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org,
f.fainelli@gmail.com, sbranden@broadcom.com, rjui@broadcom.com,
linux-kernel@vger.kernel.org,
Lino Sanfilippo <LinoSanfilippo@gmx.de>,
thierry.reding@gmail.com, linux-rpi-kernel@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com, lee.jones@linaro.org,
nsaenzjulienne@suse.de
Subject: Re: [PATCH v2] pwm: bcm2835: Support apply function for atomic configuration
Date: Sun, 6 Dec 2020 14:19:41 +0000 [thread overview]
Message-ID: <20201206141941.GA24807@gofer.mess.org> (raw)
In-Reply-To: <20201205192510.o76pjs3yc524nwvm@pengutronix.de>
Hello Uwe,
On Sat, Dec 05, 2020 at 08:25:10PM +0100, Uwe Kleine-König wrote:
> On Sat, Dec 05, 2020 at 05:34:44PM +0000, Sean Young wrote:
> > What real life uses-cases are there for round down? If you want to round
> > down, is there any need for round up?
>
> The scenario I have in mind is for driving a motor. I have to admit
> however that usually the period doesn't matter much and it's the
> duty_cycle that defines the motor's speed. So for this case the
> conservative behaviour is round-down to not make the motor run faster
> than expected.
I am reading here that for driving motors, only the duty cycle matters,
not the period.
> For other usecases (fan, backlight, LED) exactness typically doesn't
> matter that much.
So, the use-cases you have are driving motor, fan, backlight, and led.
And in all these cases the exact Hz does not matter.
The only uses case where the exact Hz does matter is pwm-ir-tx.
So, I gather there are no use-cases for round-down. Yes, should round-down
be needed, then this is more difficult to implement if the driver always
does a round-closest. But, since there is no reason to have round-down,
this is all academic.
Your policy of forcing new pwm drivers to use round-down is breaking
pwm-ir-tx.
Thanks,
Sean
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-06 14:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <202011281128.54eLfMWr-lkp@intel.com>
2020-11-28 12:02 ` [PATCH v2] pwm: bcm2835: Support apply function for atomic configuration Lino Sanfilippo
2020-11-29 18:10 ` Uwe Kleine-König
2020-12-03 23:42 ` Lino Sanfilippo
2020-12-04 8:44 ` Sean Young
2020-12-04 8:58 ` Sean Young
2020-12-04 11:13 ` Uwe Kleine-König
2020-12-04 11:38 ` Sean Young
2020-12-04 23:28 ` Uwe Kleine-König
2020-12-05 17:34 ` Sean Young
2020-12-05 19:25 ` Uwe Kleine-König
2020-12-06 14:19 ` Sean Young [this message]
2020-12-07 8:16 ` Uwe Kleine-König
2020-12-07 9:43 ` Sean Young
2020-12-07 13:52 ` Uwe Kleine-König
2020-12-07 15:29 ` Thierry Reding
2020-12-07 21:46 ` Uwe Kleine-König
2020-12-07 18:18 ` Sean Young
2020-12-08 0:00 ` Lino Sanfilippo
2020-12-08 9:07 ` Uwe Kleine-König
2020-12-04 23:16 ` Lino Sanfilippo
2020-12-04 11:21 ` Uwe Kleine-König
2020-12-04 11:40 ` Sean Young
2020-12-04 21:55 ` Uwe Kleine-König
2020-12-04 22:44 ` Sean Young
2020-12-04 23:25 ` Lino Sanfilippo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201206141941.GA24807@gofer.mess.org \
--to=sean@mess.org \
--cc=LinoSanfilippo@gmx.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=nsaenzjulienne@suse.de \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).