From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B508C4361B for ; Mon, 7 Dec 2020 10:55:16 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D960523341 for ; Mon, 7 Dec 2020 10:55:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D960523341 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=W1OZ3XO8O7ATxuFTQ5Aix7OmSO/oOkNoOzjBqcv9d18=; b=eBrc/N4DAl2TjnvOpIuGVp07L hhpgm+RXnP/ZL5HHWPKeogW3HecqzT3QuxKXFGBS7i/d1BW3i84BeiukEJhnaIP+f8n7LsG88yBQ+ hfm1FM+RcsfVDlsuIL1/6tTLXccycehRZuCopDkICZre6nrGXi12sxoGLyiOulY0aKM+DDjXk3vGX B6ZLOdgPRc+2F5eN4NUbweWxunu6MvnOU3MzS/jlftGVU+uswmeNVU/JwMGhwY1FIXZ1LM3FpuoFb /pFxSwYWWHZHwPlU7sRKd1v8RkeJx4CriMtFSVGII2sfZe8Da9ZrW98DY8kBDmTIVoiayqtj/fEZF l0G3JLyGA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmE9h-0000WN-Ci; Mon, 07 Dec 2020 10:54:09 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmE9e-0000V0-Um for linux-arm-kernel@lists.infradead.org; Mon, 07 Dec 2020 10:54:08 +0000 Date: Mon, 7 Dec 2020 10:53:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607338446; bh=1oou2RFP/SKwiJkBvHYPfbfrjSBKYsSmyIsovvwhrcQ=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=WwNHFxC2ppcoTe2xqpFwZMHqqkbdNDlPaUPPsivySCHE1x7htTD8AezIRtMQC8Xqk mx0rbCRLYPCgemajWzSjJsI5v8lddp1pxLoTa1PPGDLjqUnEAFDqlzrq2HNoH+mE3s z9kTKLRHQfX8hR0X0CfYVmp/t86IiNLY1J2nyeCX4CbAtO+RimMSrSEzVnNEv4iZ0o L4CHOd+T2hsh2IfiYkwidgvJdbT68AOvTVFUDEKoCutxEQUQTLBMMlLkxl9BAl/zVG OjfZB52wRaGT6MU2BuhtqGu/zDT2SXAgXJm4LwC+bSBDv8Vt2Os5jcrlc6IRHR6wYJ XgfdP8PJlp6cg== From: Will Deacon To: Chanho Park Subject: Re: [PATCH] perf arm pmu: fix build error on MUSL libc Message-ID: <20201207105359.GA4198@willie-the-truck> References: <20201206144527.1670483-1-chanho61.park@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201206144527.1670483-1-chanho61.park@samsung.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201207_055407_086333_EC5D7D3A X-CRM114-Status: GOOD ( 15.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , mathieu.poirier@linaro.org, suzuki.poulose@arm.com, Peter Zijlstra , coresight@lists.linaro.org, John Garry , linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Khem Raj , Ingo Molnar , Leo Yan , Namhyung Kim , Chanho Park , Jiri Olsa , linux-arm-kernel@lists.infradead.org, Mike Leach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Dec 06, 2020 at 11:45:27PM +0900, Chanho Park wrote: > __always_inline can cause build error on musl libc. The fix patch has > submitted but not merged yet[1]. To build perf tool with musl libc, > inclusion is necessary and it should be included before > perf_event.h. > > from /usr/include/linux/byteorder/little_endian.h:13, > from /usr/include/asm/byteorder.h:23, > from tools/include/uapi/linux/perf_event.h:20, > from arch/arm64/util/../../arm/util/pmu.c:9: > > /usr/include/linux/swab.h:171:8: error: unknown type name '__always_inline' > 171 | static __always_inline __u16 __swab16p(const __u16 *p) > | ^~~~~~~~~~~~~~~ > > [1]: https://lkml.org/lkml/2018/9/13/78 > Cc: Mathieu Poirier > Cc: Suzuki K Poulose > Cc: Mike Leach > Cc: Leo Yan > Cc: John Garry > Cc: Will Deacon > Cc: Peter Zijlstra > Cc: Ingo Molnar > Cc: Arnaldo Carvalho de Melo > Cc: Mark Rutland > Cc: Jiri Olsa > Cc: Namhyung Kim > Cc: Khem Raj > Signed-off-by: Chanho Park > --- > tools/perf/arch/arm/util/pmu.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tools/perf/arch/arm/util/pmu.c b/tools/perf/arch/arm/util/pmu.c > index bbc297a7e2e3..4c0357e8c0ab 100644 > --- a/tools/perf/arch/arm/util/pmu.c > +++ b/tools/perf/arch/arm/util/pmu.c > @@ -6,6 +6,9 @@ > > #include > #include > +#if !defined(__GLIBC__) > +#include > +#endif Looks like other files just include this unconditionally, but have a comment explaining why. See util/branch.h and util/event.h. Maybe we should do the same for util/pmu.h, which is already included here? Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel