From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA6BAC2BB3F for ; Mon, 7 Dec 2020 13:33:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 705F323372 for ; Mon, 7 Dec 2020 13:33:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 705F323372 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ck36QqIno6b4EgkTWLOMJOJElQ49Swqy8zh3C81gtxw=; b=mKOjtU0ohk76UkTDPT3TIdcIc EjPwzYZaDKuIcKjg4Fvf/2cOsllljwHXyUtOpfbbPt3uDTR2UPhHkw+iAAXn1GX2yQ1g7ASXMK/8H Z0uW4KewthEpd0z+upEyrNqzcSOmGf4ugHV2Myk00C1KIkaVe8KoqEqebYOZJD3blVlJW3+I9mkE3 6crtAqc8mEOtuFGDY2shRpTl+d479iYlVaYJIgXihsb3Qb3HKXe6yADcnYZnJ0mfZMw9//DfCdVrT S6hQEm3Hywa6YBx+SLlcsQhNCmWc5W9iQEs8B36ammMRsCSBDkWr8DtrRAzw44sYPNH9xIOMSA+iV WmEH7RP9g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmGct-0008Mb-VR; Mon, 07 Dec 2020 13:32:28 +0000 Received: from mail-wm1-f65.google.com ([209.85.128.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmGcr-0008MD-10 for linux-arm-kernel@lists.infradead.org; Mon, 07 Dec 2020 13:32:25 +0000 Received: by mail-wm1-f65.google.com with SMTP id g25so9573862wmh.1 for ; Mon, 07 Dec 2020 05:32:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RembZIikAsE5OexlUCmMaxB8Hxwcn1zAj8r/g95Ples=; b=HojdoTF38QlC60fAXelX+O3o6JkED+oLPRW6parZvUywsUIzlYMU3Rb3XDuCYFZyD0 kYVZ2PAsoknkh1xU54GI2tXpuF+pz4bLg/5krwYpWTxUG89MJuuCClhD6JPfendFRkIr srQ6NLlU9Wd/gLF8lDbVtD2RJ/nsMnYH9K4rixR204bFyqC7mH5uslHmZwqxNmAIW/7x jnG8Vp6Hq/gaqD/mxfKgIaHSjkC2BPUaZs80NrGrLg0n2k9zQU3aUWTizopWkIka7uYt 7eebhuue5MjghM37Ok/AuStff+FdkZrXnKcHGhqYay3EYFTt8TlGfqpx03zGmaKJ+/91 p+lA== X-Gm-Message-State: AOAM531RiWVrw3AbuMmGtsESmMZBzlRvTKG81VH0w4CxHyHbacenf6Bs mFHrRALvrU59RuzR/qzgCB+/XC8MQo8= X-Google-Smtp-Source: ABdhPJyuL/ez8mJ0q23T4aZfgVuL6x9VKr+VNNaVPLFEKOwvqeI1hYphd1rV0mYYmwzWeC3qZmjs7A== X-Received: by 2002:a1c:b402:: with SMTP id d2mr18163671wmf.38.1607347943775; Mon, 07 Dec 2020 05:32:23 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id t1sm2283843wro.27.2020.12.07.05.32.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Dec 2020 05:32:22 -0800 (PST) Date: Mon, 7 Dec 2020 14:32:21 +0100 From: Krzysztof Kozlowski To: Shengjiu Wang Subject: Re: [PATCH] arm64: dts: imx8mn: Fix duplicate node name Message-ID: <20201207133221.GA32877@kozik-lap> References: <1607324004-12960-1-git-send-email-shengjiu.wang@nxp.com> <20201207132140.GA31982@kozik-lap> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201207132140.GA31982@kozik-lap> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201207_083225_109525_F6A7F453 X-CRM114-Status: GOOD ( 22.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, festevam@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 07, 2020 at 02:21:40PM +0100, Krzysztof Kozlowski wrote: > On Mon, Dec 07, 2020 at 02:53:24PM +0800, Shengjiu Wang wrote: > > Error log: > > sysfs: cannot create duplicate filename '/bus/platform/devices/30000000.bus' > > > > The spba bus name is duplicate with aips bus name. > > Refine spba bus name to fix this issue. > > > > Fixes: 970406eaef3a ("arm64: dts: imx8mn: Enable Asynchronous Sample Rate Converter") > > Signed-off-by: Shengjiu Wang > > --- > > arch/arm64/boot/dts/freescale/imx8mn.dtsi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi > > index fd669c0f3fe5..30762eb4f0a7 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi > > @@ -246,7 +246,7 @@ aips1: bus@30000000 { > > #size-cells = <1>; > > ranges; > > > > - spba: bus@30000000 { > > + spba: spba-bus@30000000 { > > The proper node name is "bus" so basically you introduce wrong name to > other problem. Introducing wrong names at least requires a comment. I just noticed that my message was barely understandable... so let me fix it: The proper node name is "bus" so basically you introduce wrong name to _fix_ other problem. Introducing wrong names at least requires a comment. > However the actual problem here is not in node names but in addresses: > > aips1: bus@30000000 { > spba: bus@30000000 { > > You have to devices with the same unit address. How do you share the > address space? > > I think this should be rather fixed. And again, hungry keyboard ate a letter, so: You have _two_ devices with the same unit address. How do you share the address space? I think this should be rather fixed. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel