From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F19FAC433FE for ; Mon, 7 Dec 2020 13:51:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 96F80233ED for ; Mon, 7 Dec 2020 13:51:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 96F80233ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wdMsozKCvTgktGZvTLBOXnRCxk6vvSdsGkMh6jwZLm0=; b=LVmPfoOvpnK9Lc6Bv8M5B5ZzZ KI/oYRxky8dJv2WJ/UE31BdAhDaOrzrJJKTcOC1WEUP5U2x8ofYWBM3vH/2uFV/yg3JuEMJlom5WR iw503F7iQ3oqz7tEUg7EdD95HB6SGc5lXILKVpCf82Q3738rEtZFbBCuocez0Gt5J0fSgPCogZ21I Jd27LvlTwkm98IegwRDJTPr46mP1tjAB1CMwz1w7I7ZZMk+7F/L2R45iqT4wQzFPjRtlwzYI04O/S KcT6Inn4c8hVTJLPVanOBbL9RvlDHR8mEeRZ/1NsDf1KXKCJFIP5T1/OSW1eCkx/PRnVy7vACiIo+ A2N0Sx8LQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmGu7-0005BS-DJ; Mon, 07 Dec 2020 13:50:15 +0000 Received: from mail-wm1-f65.google.com ([209.85.128.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmGu4-0005AY-M8 for linux-arm-kernel@lists.infradead.org; Mon, 07 Dec 2020 13:50:13 +0000 Received: by mail-wm1-f65.google.com with SMTP id h21so13739363wmb.2 for ; Mon, 07 Dec 2020 05:50:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FftH6af/C4ijp9qZAXmpaXm/xsA7yaDpXA+L76ZmNPw=; b=pYSJER9bcx3yXYgPAgdzCM2sim/Qb60Gnl4vVPc5j8x6kmJJMg//9pll7VcDoGsQpT t/JCUVyhQetkcBZpyDaXRhRKIGQQTAh1h/R+k+pvqFn86EYMPnY5LFKKbDXi9INqxfPL TKYU1AXXWh+vUelKLJX71BAV9g4eIFzaUcTyYJ9NQZp+n2hhPbyopgUZ2NyHxnjZXPLN hiCXS1wpFKAJWZTXcwOFPKtcI+y7BMzaFaRNgWFXNO2KpJb/+z0DQKw+w+13wskUBSnd /gQYygPAoTW06Vlf/AAmbjrWP2jPAmr8OC4WN3XudgJMRQm/wIEHv8KVkXCcO9GwwaeN Z00w== X-Gm-Message-State: AOAM533Efzf5brJfIWmqchH5lUjrT88Hw+bLdR6rfV2NZngI8Jjnc2Lg WzN5hR3cisMhht63P5EJZVY= X-Google-Smtp-Source: ABdhPJy9WMUqw/xMWQUbnpndvxbL6i1Xb8vqxJB03XdFnfPtyCvXw4Vg8Nhx5udPvmfl6jK5WbYKQQ== X-Received: by 2002:a05:600c:258:: with SMTP id 24mr18886051wmj.16.1607349011527; Mon, 07 Dec 2020 05:50:11 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id r128sm15082189wma.5.2020.12.07.05.50.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Dec 2020 05:50:10 -0800 (PST) Date: Mon, 7 Dec 2020 14:50:04 +0100 From: Krzysztof Kozlowski To: Teresa Remmet Subject: Re: [PATCH 1/4] arm64: defconfig: Enable rv3028 i2c rtc driver Message-ID: <20201207135004.GA34599@kozik-lap> References: <1607113982-109524-1-git-send-email-t.remmet@phytec.de> <1607113982-109524-2-git-send-email-t.remmet@phytec.de> <20201207121029.GC27266@kozik-lap> <5b8617e4b6abe19750cec17f4d6e501fe957f193.camel@phytec.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5b8617e4b6abe19750cec17f4d6e501fe957f193.camel@phytec.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201207_085012_773139_3D15B4B1 X-CRM114-Status: GOOD ( 24.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Catalin Marinas , Sascha Hauer , Rob Herring , Fabio Estevam , Shawn Guo , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 07, 2020 at 02:38:51PM +0100, Teresa Remmet wrote: > Am Montag, den 07.12.2020, 13:10 +0100 schrieb Krzysztof Kozlowski: > > On Fri, Dec 04, 2020 at 09:32:59PM +0100, Teresa Remmet wrote: > > > Enable rv3028 i2c rtc driver populated on phyBOARD-Pollux-i.MX8M > > > Plus. > > > > > > Signed-off-by: Teresa Remmet > > > --- > > > arch/arm64/configs/defconfig | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/arch/arm64/configs/defconfig > > > b/arch/arm64/configs/defconfig > > > index 5cfe3cf6f2ac..2034fefb3f44 100644 > > > --- a/arch/arm64/configs/defconfig > > > +++ b/arch/arm64/configs/defconfig > > > @@ -818,6 +818,7 @@ CONFIG_RTC_DRV_MAX77686=y > > > CONFIG_RTC_DRV_RK808=m > > > CONFIG_RTC_DRV_PCF85363=m > > > CONFIG_RTC_DRV_RX8581=m > > > +CONFIG_RTC_DRV_RV3028=y > > > > This should be a module. > > with having this build in the clock out of this rtc will be disabled as > not using during boot up. The clock out is enabled as default and has > to be disabled explicit. But I guess the correct way would be to find a > solution in the rtc driver itself? Regardless whether it is built-in or module, the driver will behave the same. So either the driver disables the clock, or not. The only difference will be *when* the action happens. Choosing it as built-in for the purpose of disabling some clock is not a proper approach. The defconfig here serves only a development/debugging/reference purpose. It's not for production so anyway the effect on disabling some parts is not that important. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel