From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A9F5C433FE for ; Mon, 7 Dec 2020 18:20:44 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AFD4623877 for ; Mon, 7 Dec 2020 18:20:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AFD4623877 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=s8L0LH3juxbcNFvnC840722iY1Ntx5FO4zaw/FlGSoA=; b=Eohl4bJGScksS3dpO90yHoG3U w353U0AK8ou6GN/h3ekxQ1k9RaYCzbKJaIArmXEv2z+7JsV8zsoE6nE4On/nVh6gsDyotkmA4rFKX S9m5xDt+gIL37jT3Egif6853UIIryn1QnUDwBe4Pw5BnsjxU6DtafjvA6ViFJ2AqPI2ddow/Tz3we B8peR3ni13WIaofo8Rc48zCaw9Cvp3EFxSggm+pLUqdK+mO9FJru0zXHFHXlAye+C6nrlOAfcypSM EuUMJel+Tmu8FVTAibA99/Jn5Rb2oNzMIgFctXdOzm8zdAbL3c1xpqGRHQwsyGF8pScc2ZAm8hLEh PhWs65C8w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmL6p-0001bf-8z; Mon, 07 Dec 2020 18:19:39 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmL6n-0001b4-6U for linux-arm-kernel@lists.infradead.org; Mon, 07 Dec 2020 18:19:38 +0000 Date: Mon, 7 Dec 2020 18:19:31 +0000 From: Catalin Marinas To: Will Deacon Subject: Re: [PATCH] arm64: cpufeature: fix unused function warning Message-ID: <20201207181931.GE1526@gaia> References: <20201203223217.1238899-1-arnd@kernel.org> <20201204095909.GC461@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201204095909.GC461@willie-the-truck> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201207_131937_324222_B2FFECC2 X-CRM114-Status: GOOD ( 15.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Arnd Bergmann , Arnd Bergmann , Anshuman Khandual , Suzuki K Poulose , linux-kernel@vger.kernel.org, Kristina Martsenko , Mark Brown , Amit Daniel Kachhap , Ionela Voinescu , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 04, 2020 at 09:59:10AM +0000, Will Deacon wrote: > On Thu, Dec 03, 2020 at 11:32:11PM +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > The __system_matches_cap() function is now only used in an #ifdef > > section: > > > > arch/arm64/kernel/cpufeature.c:2649:13: error: unused function '__system_matches_cap' [-Werror,-Wunused-function] > > > > Move it into that #ifdef section. > > > > Fixes: 7cf283c7bd62 ("arm64: uaccess: remove redundant PAN toggling") > > Signed-off-by: Arnd Bergmann I already queued a fix from Mark: 701f49065e68 ("arm64: mark __system_matches_cap as __maybe_unused"). > Acked-by: Will Deacon > > We can probably go further and remove the helper altogether as I don't > think it really helps has_generic_auth(), but this should fix the warning. We could replace the ARM64_HAS_GENERIC_AUTH checks with a single helper function that tests for ARM64_HAS_GENERIC_AUTH_ARCH or ARM64_HAS_GENERIC_AUTH_IMP_DEF. Or you had a different idea? -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel