From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BA00C433FE for ; Tue, 8 Dec 2020 08:05:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A0D223A51 for ; Tue, 8 Dec 2020 08:05:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A0D223A51 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3QefR040Xdyes1EJLCJWGrjcMZwnn24pgiZOhN5ugq0=; b=3Z7OZNoxLULamRALsWI0Pqi/l DeDCU0oL2OSirzBzduyAm9MXX2xh1+AbHbqEvhjg/S0jlGYt4og/GFJ7IJjgCdcw7e6ZWGs7iYq2l wHBhtWCL3SQf7MiVS/QAYXB+SDJPDbfhaB6jFBuW7YLiGsQwa71PLANX6dAWPPP9EoA0OG9J1sfCp YyYcOigmKknQk1f7kPlF7xQqfmeqHJ+hXWqF7ktklq5j6GHgR05Nl8v5XaO5/G96dJC+dkJVmZHXP vlnAlao7efjklcxPWI3G3DigtqNXIWNdILg11X+O9q+/mLQH+mCcHJD5vKpn1Z/zi74VWQ0CtAOQL Z83QdCZ/w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmXyH-0003du-MN; Tue, 08 Dec 2020 08:03:41 +0000 Received: from mail-wr1-f66.google.com ([209.85.221.66]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmXyF-0003dV-M2 for linux-arm-kernel@lists.infradead.org; Tue, 08 Dec 2020 08:03:40 +0000 Received: by mail-wr1-f66.google.com with SMTP id m5so5651979wrx.9 for ; Tue, 08 Dec 2020 00:03:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=idKNMDUMpQRe7scdOjeO6VGYUZkB7f9r4VlFo9Ze3ns=; b=S2qOJGdGwOxbMBzGtIIlKQotHYs83kXX4bPiC2SdYgoXGa8Bxau4eV8ZSBhXTcwZaQ WKhbhZFAjHIulepjLyFmveiZVsln047QYeXDQkqE/5cPaq9csf26j5gEuMucPWSfyVmn LeF5VyKSU1ToZhhoId/AeVZi6q3RollNG8jE8lIQLEskhAKQaurbyRNYLBt3th0duccy 9RLENk7j0PNoBGqx3TvbP8KAOXfQGY1h3QQ1GcjZ8zhBmoK11Srix87EI5mYF6raBPd4 ff1Ef8fKVll+cFtgAgtkTg801zvw7/AjExooVb6VhBAX0y7ld6kH9jS7vy8R7aUdEXFv EZjg== X-Gm-Message-State: AOAM530Iv1tu1e+ILhdhuYGpZLNgD94EqkzEHVg+uvC7CK0KnjIBvbwr 3aOV7vZu2MrnoEEaWg5o9dM= X-Google-Smtp-Source: ABdhPJzwJd6F15wCZL2Lp1KwBbk5y/hxxQFNmnKudv1csJ/6yJOVqFELhAaaB1efyq77lHw3mPRYsg== X-Received: by 2002:adf:f44c:: with SMTP id f12mr23857523wrp.155.1607414617149; Tue, 08 Dec 2020 00:03:37 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id n14sm2169265wmi.1.2020.12.08.00.03.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Dec 2020 00:03:35 -0800 (PST) Date: Tue, 8 Dec 2020 09:03:34 +0100 From: Krzysztof Kozlowski To: "S.j. Wang" Subject: Re: [PATCH] arm64: dts: imx8mn: Fix duplicate node name Message-ID: <20201208080334.GA4026@kozik-lap> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201208_030339_754928_472C0039 X-CRM114-Status: GOOD ( 27.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , dl-linux-imx , "kernel@pengutronix.de" , "festevam@gmail.com" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 08, 2020 at 03:16:35AM +0000, S.j. Wang wrote: > Hi > > > > > On Mon, Dec 07, 2020 at 02:21:40PM +0100, Krzysztof Kozlowski wrote: > > > On Mon, Dec 07, 2020 at 02:53:24PM +0800, Shengjiu Wang wrote: > > > > Error log: > > > > sysfs: cannot create duplicate filename > > '/bus/platform/devices/30000000.bus' > > > > > > > > The spba bus name is duplicate with aips bus name. > > > > Refine spba bus name to fix this issue. > > > > > > > > Fixes: 970406eaef3a ("arm64: dts: imx8mn: Enable Asynchronous Sample > > > > Rate Converter") > > > > Signed-off-by: Shengjiu Wang > > > > --- > > > > arch/arm64/boot/dts/freescale/imx8mn.dtsi | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi > > > > b/arch/arm64/boot/dts/freescale/imx8mn.dtsi > > > > index fd669c0f3fe5..30762eb4f0a7 100644 > > > > --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi > > > > @@ -246,7 +246,7 @@ aips1: bus@30000000 { > > > > #size-cells = <1>; > > > > ranges; > > > > > > > > - spba: bus@30000000 { > > > > + spba: spba-bus@30000000 { > > > > > > The proper node name is "bus" so basically you introduce wrong name to > > > other problem. Introducing wrong names at least requires a comment. > > > > I just noticed that my message was barely understandable... so let me fix it: > > > > The proper node name is "bus" so basically you introduce wrong name to > > _fix_ other problem. Introducing wrong names at least requires a comment. > > > > > However the actual problem here is not in node names but in addresses: > > > > > > aips1: bus@30000000 { > > > spba: bus@30000000 { > > > > > > You have to devices with the same unit address. How do you share the > > > address space? > > > > > > I think this should be rather fixed. > > > > And again, hungry keyboard ate a letter, so: > > > > You have _two_ devices with the same unit address. How do you share the > > address space? > > I think this should be rather fixed. > > > > spba is the first block of aips1 space, so it has same start address as > aips1. The reference manual describes it "Reserved for SDMA2 internal memory", so indeed it is first address but does it have to be mapped? Anyway, why don't you use ranges to remove the conflict? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel