From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EEEEC433FE for ; Tue, 8 Dec 2020 08:51:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4BDFC23A79 for ; Tue, 8 Dec 2020 08:51:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4BDFC23A79 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cn5VyPOJR6GC/wKtu1Rwo/KB7OzJsR5TbuflgiKmNNg=; b=exNt+gcR2pq5fF1T7rBY6HF5w mHGUmZHY/TxD/wBWHoq9ekqecdKxW4bdKHs/zPQ/shQNRNQYBjqhmhXpOLKmZkKbuccjpjv1+Fqtj lHu2tX8ROIFWO5WxmpLO1vPDNZ65B3R9htjTNcBEVacTs5wycnJEwTD6x7zMQ6UnW08GYG8orB7WB dkmQ8bhP00Dx0RiyryRoHWk0NZXlskttEvaHI5hPzQbBCVBtN1Tnf9lVqeMF0mxcY4uK1Cjj4k4v/ qK+H/O45kgHtIVM7yHaBpFCuKM6nLkH1ktDQH2E/eyZpHbXut2YYFVRzLQ8NhJhpYmvhNyue0d9Eb bds1ePGqg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmYhI-0000NQ-19; Tue, 08 Dec 2020 08:50:12 +0000 Received: from mail-wr1-f65.google.com ([209.85.221.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmYhF-0000N1-9h for linux-arm-kernel@lists.infradead.org; Tue, 08 Dec 2020 08:50:10 +0000 Received: by mail-wr1-f65.google.com with SMTP id r7so4148930wrc.5 for ; Tue, 08 Dec 2020 00:50:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=y0koPcLMtfqbktCsAIiMm4tX7WZXNRVhbxZdAvcr+Xk=; b=ZLw2BLpQTHAg1E2IzdlossgyRgEhyhZ5GXu/M/+26rfMDGbtZn8Zx/l0sZxXEKf+or LX8x3lD0N/SlQPY+Tpa1dRRpTo5zGpZI7UcNq1xFFeNRy6a5dbucDLdkpIICUi6INX7T gS4WS0osSIYmypJxfJwJW8fHMkw3VJm17dGVbGVksp3R2g0fQcqRBUw8NZ6MdDJPCMkh 255G0vGNFaB86sjfgFprLnjjHHNgCixy4s6K3u6F+NhP0nBVK3XqfZNmjJ9QiEgEr8cW e0zKV16saDMyyzbJlZfpTerPpwvQDlxueDpnTl28JhWunsIFZa4vYX46LAlD1att1k7Y ZJxw== X-Gm-Message-State: AOAM5323i1wte0O6HfiKQ8Bhz7Gcq8Va0tmEcX0huC4w17EtRvRE+wr+ WY3+fgOde4Dvq1IIx8bkTKE= X-Google-Smtp-Source: ABdhPJxA6RS0R2gOVXWCWGnV+uh/3Kv14fuvnan/fEHEb7oQxahAQY+Bo0gM03s1veEtbBW1dE0DSA== X-Received: by 2002:a5d:5552:: with SMTP id g18mr24607916wrw.145.1607417408037; Tue, 08 Dec 2020 00:50:08 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id n14sm18421046wrx.79.2020.12.08.00.50.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Dec 2020 00:50:06 -0800 (PST) Date: Tue, 8 Dec 2020 09:50:05 +0100 From: Krzysztof Kozlowski To: "S.j. Wang" Subject: Re: [PATCH] arm64: dts: imx8mn: Fix duplicate node name Message-ID: <20201208085005.GA7654@kozik-lap> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201208_035009_392910_76689643 X-CRM114-Status: GOOD ( 35.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , dl-linux-imx , "kernel@pengutronix.de" , "festevam@gmail.com" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 08, 2020 at 08:44:51AM +0000, S.j. Wang wrote: > > > > > > > > > > On Mon, Dec 07, 2020 at 02:21:40PM +0100, Krzysztof Kozlowski wrote: > > > > > > On Mon, Dec 07, 2020 at 02:53:24PM +0800, Shengjiu Wang wrote: > > > > > > > Error log: > > > > > > > sysfs: cannot create duplicate filename > > > > > '/bus/platform/devices/30000000.bus' > > > > > > > > > > > > > > The spba bus name is duplicate with aips bus name. > > > > > > > Refine spba bus name to fix this issue. > > > > > > > > > > > > > > Fixes: 970406eaef3a ("arm64: dts: imx8mn: Enable Asynchronous > > > > > > > Sample Rate Converter") > > > > > > > Signed-off-by: Shengjiu Wang > > > > > > > --- > > > > > > > arch/arm64/boot/dts/freescale/imx8mn.dtsi | 2 +- > > > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi > > > > > > > b/arch/arm64/boot/dts/freescale/imx8mn.dtsi > > > > > > > index fd669c0f3fe5..30762eb4f0a7 100644 > > > > > > > --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi > > > > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi > > > > > > > @@ -246,7 +246,7 @@ aips1: bus@30000000 { > > > > > > > #size-cells = <1>; > > > > > > > ranges; > > > > > > > > > > > > > > - spba: bus@30000000 { > > > > > > > + spba: spba-bus@30000000 { > > > > > > > > > > > > The proper node name is "bus" so basically you introduce wrong > > > > > > name to other problem. Introducing wrong names at least requires a > > comment. > > > > > > > > > > I just noticed that my message was barely understandable... so let me > > fix it: > > > > > > > > > > The proper node name is "bus" so basically you introduce wrong > > > > > name to _fix_ other problem. Introducing wrong names at least > > requires a comment. > > > > > > > > > > > However the actual problem here is not in node names but in > > addresses: > > > > > > > > > > > > aips1: bus@30000000 { > > > > > > spba: bus@30000000 { > > > > > > > > > > > > You have to devices with the same unit address. How do you share > > > > > > the address space? > > > > > > > > > > > > I think this should be rather fixed. > > > > > > > > > > And again, hungry keyboard ate a letter, so: > > > > > > > > > > You have _two_ devices with the same unit address. How do you > > > > > share the address space? > > > > > I think this should be rather fixed. > > > > > > > > > > > > > spba is the first block of aips1 space, so it has same start address > > > > as aips1. > > > > > > The reference manual describes it "Reserved for SDMA2 internal > > > memory", so indeed it is first address but does it have to be mapped? > > > Anyway, why don't you use ranges to remove the conflict? > > > > The IO address space remapping could be a solution but there is another > > problem - the hardware representation in DT does not match what reference > > manual is saying. > > > > The AIPS bus @30000000 has several IPs: > > - SAI2@30020000 > > - ... > > - GPIO1@30200000 > > > > However in DTS you will find additional SPBA bus for 30000000 - 300c0000. > > It's not really the SDMA, as SDMA is at different address. It is rather an > > address space which SDMA should map... but it is not a bus with children. > > Adding spba-bus@30000000 with its children does not look like correct > > representation of HW in DTS. > > > > In the RM, it says AIPS-1 (s_b_1, via SPBA) Glob. Module Enable. > Range is (30000000 - 300FFFFF) No, AIPS-1 is till 303F_FFFF. > > SPBA is a sub-bus under AIPS1. The SAI2@30020000 - ASRC@300c0000 > Are the devices under SPBA bus. Where did you find SPBA bus description in the Reference Manual? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel