From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF5BCC4361B for ; Tue, 8 Dec 2020 09:04:38 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B0B7423A9A for ; Tue, 8 Dec 2020 09:04:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B0B7423A9A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=puri.sm Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=T2smvXc/TxyXwVH/pjHTIjcCAY9Ogl1PnoKRslW54ko=; b=OF2B1PdlnG69HXGte/jBLogEm VqXt0K8R9QnUOHZE7ieJimmPi9+PPc9mbqAqEkIDj6vpzMQ8Z3YlX8KQWJkJdJitdeLq9KZLYkxwV fbBmUGk9BAhIGvtSVjuBKQLbLCplIvCTyl26LuM5QUEk3ruNJbpEasivIBu7VdTWvbHF9msr/8Cy8 jUqhDp4mHXo+1KtwP0PM94feL89w5jbRDgo+Mx3NBLBPZddVGOgeim3EH9jz8luMxeG0uMYyKIjAf uuXxC/wDlG8JOPwePPmHFHumnCq1Z/Cq92/O9xdK8jiDk7fZzaeDJqLriJimRmYpCPwLgcIOkvKMO W9e3cUk+g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmYtn-0001Qz-Ol; Tue, 08 Dec 2020 09:03:07 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmYtm-0001QW-Bn for linux-arm-kernel@merlin.infradead.org; Tue, 08 Dec 2020 09:03:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Qw9oY/mJnvsMmy8/5uMDc8OuAMlZ7Zry6fohwymEyNM=; b=m8Vlp/T++TNH8JnCjY5EkPt9lz 3aeNzClj5rw3aO30/gK/WXMUO3ckS3GyUrUHkNXjFF6PfeYMbON2pipwJX3me5UhrPEu6PFQSd6SY 0WZbDdwzI63wp2wOyt+7HAm4M3C8dQniVlpac5JdJd+54s4kt+j4ZG9Lvmcb0HZSJ4RfqPGs3qSDD BPZwJEFsZa7RVIXH1PZXhcLzMNnL3UDo7WrtCZnfcyhNheUY8pULgyIHd2puUfk9gTtdfE6f/ktg9 NQJDsf5MmxakqS6CZ5mUCBiMzsJTI8cpU4yhBMayCEB9hgm8SIqUDmS97lJZetBlfaw5uHDqA29QS 9n8VA0Ag==; Received: from honk.sigxcpu.org ([24.134.29.49]) by casper.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmYtg-0007I4-Ev for linux-arm-kernel@lists.infradead.org; Tue, 08 Dec 2020 09:03:05 +0000 Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id 32A11FB03; Tue, 8 Dec 2020 10:02:46 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at honk.sigxcpu.org Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RGlDGe6CXV_f; Tue, 8 Dec 2020 10:02:44 +0100 (CET) Received: by bogon.sigxcpu.org (Postfix, from userid 1000) id 5EA9D4068D; Tue, 8 Dec 2020 10:02:44 +0100 (CET) Date: Tue, 8 Dec 2020 10:02:44 +0100 From: Guido =?iso-8859-1?Q?G=FCnther?= To: Liu Ying Subject: Re: [PATCH 0/4] phy: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp LVDS PHY mode support Message-ID: <20201208090244.GA20575@bogon.m.sigxcpu.org> References: <1607067224-15616-1-git-send-email-victor.liu@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1607067224-15616-1-git-send-email-victor.liu@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201208_090301_369208_DC82F05A X-CRM114-Status: GOOD ( 19.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, jernej.skrabec@siol.net, kernel@pengutronix.de, narmstrong@baylibre.com, airlied@linux.ie, festevam@gmail.com, s.hauer@pengutronix.de, jonas@kwiboo.se, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, kishon@ti.com, a.hajda@samsung.com, vkoul@kernel.org, robh+dt@kernel.org, Laurent.pinchart@ideasonboard.com, daniel@ffwll.ch, robert.chiras@nxp.com, martin.kepplinger@puri.sm, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Liu, On Fri, Dec 04, 2020 at 03:33:40PM +0800, Liu Ying wrote: > Hi, > > This series adds i.MX8qxp LVDS PHY mode support for the Mixel PHY in the > Freescale i.MX8qxp SoC. This looks good to me from the NWL and actual phy driver part. I'll comment in the individual patches but leave comments on the extension of the generic phy struct to someone knowledgeable with that part. What display controllers do you intend to drive that with? Cheers, -- Guido > > The Mixel PHY is MIPI DPHY + LVDS PHY combo, which can works in either > MIPI DPHY mode or LVDS PHY mode. The PHY mode is controlled by i.MX8qxp > SCU firmware. The PHY driver would call a SCU function to configure the > mode. > > The PHY driver is already supporting the Mixel MIPI DPHY in i.MX8mq SoC, > where it appears to be a single MIPI DPHY. > > > Patch 1/4 sets PHY mode in the Northwest Logic MIPI DSI host controller > bridge driver, since i.MX8qxp SoC embeds this controller IP to support > MIPI DSI displays together with the Mixel PHY. > > Patch 2/4 allows LVDS PHYs to be configured through the generic PHY functions > and through a custom structure added to the generic PHY configuration union. > > Patch 3/4 adds dt binding support for the Mixel combo PHY in i.MX8qxp SoC. > > Patch 4/4 adds the i.MX8qxp LVDS PHY mode support in the Mixel PHY driver. > > > Welcome comments, thanks. > > > Liu Ying (4): > drm/bridge: nwl-dsi: Set PHY mode in nwl_dsi_enable() > phy: Add LVDS configuration options > dt-bindings: phy: mixel: mipi-dsi-phy: Add Mixel combo PHY support for > i.MX8qxp > phy: freescale: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp LVDS PHY mode > support > > .../devicetree/bindings/phy/mixel,mipi-dsi-phy.txt | 8 +- > drivers/gpu/drm/bridge/nwl-dsi.c | 6 + > drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c | 266 ++++++++++++++++++++- > include/linux/phy/phy-lvds.h | 48 ++++ > include/linux/phy/phy.h | 4 + > 5 files changed, 320 insertions(+), 12 deletions(-) > create mode 100644 include/linux/phy/phy-lvds.h > > -- > 2.7.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel