From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C24AC4361B for ; Tue, 8 Dec 2020 15:40:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D017723A33 for ; Tue, 8 Dec 2020 15:40:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D017723A33 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Gaw9n2llpslNcfc9DlzKwAo2Qt3cgtjJ77XiEErLIAc=; b=tTW93puI+EVG4cqoliGLFmp/M NG/9X4MUkgu4JIoXXO5FiDg+ZNoKVIdLvpL5q8JIF+81rgczGn4ns+o4YXp/hbBmKmH20ooRh1IAh lJV+gcIsn+iWcc1Ho0rH5ucm9W+JC/UXj0QQDWpovnd/ZvUAWLPilAMoODzGXkWW/DYOuUNzwxPi1 qZgBTVzqQzF8QW8cP6kt/nenJC/3hlouDDcWOfwdIe54DOfKjqW7/oXNKArYkEjjlbKksiXr1IY0J 146vfZstGBrW8jVRuhs0XWcvvBjpSxEfOM7pzIHGWCnAF0SJGcb+S1CqrpVXSK7UJTxgP37KLl0yP eXXPGQDRw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmf5K-0007l4-RV; Tue, 08 Dec 2020 15:39:26 +0000 Received: from mail-oi1-f194.google.com ([209.85.167.194]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmf5G-0007jp-U7 for linux-arm-kernel@lists.infradead.org; Tue, 08 Dec 2020 15:39:23 +0000 Received: by mail-oi1-f194.google.com with SMTP id l207so16899484oib.4 for ; Tue, 08 Dec 2020 07:39:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=r4At2JRTffPDhNlHKCVUhQQs+9lnibYf2nVgEDOu8xg=; b=X5FlA5IKu9ZEYcvzMTmn3hd1ed83s64gX3NoTu7l6QDdyfa5gATjnTijM38uecOzQG rB7FlGoIJH2qKUc9j3LEWCm/l/wqOdYn24kJu+hUEH0P6+AGhb2pbtQ6j32q+JfwzDHd OPd+WB6Eq3MtTd2lTqrIq/jYUS2YnkyPvBtd/J31a/Z/I2NS6fM8OnA2iBWXRXGmd2hU Bc0rnaXnrJSE+YYfWisTt80HKVRuPZZiIcyQRazHH4Qmvj5MUOltZEsqDfFM0/ySoXmg VA7tFrIhLr5fQ+3OlO1R4+7vnIIYeM8so8CInopmPsslZJ0AAZAYoV7IY1X5rfXN2I51 XSWw== X-Gm-Message-State: AOAM533qMVTb/XVEiNw1tmpl8ESh1YFcKwxJtUcF72luMqVu11UcI7MJ N1iGHKuQaNMs6UYtcwM1mQ== X-Google-Smtp-Source: ABdhPJyKnbmKSDVPybWvTW80k+sHigOw9XIDTe2qJfgfN84Dh9l8C8fNgU9Lngc/r258HaY/1gYj1Q== X-Received: by 2002:aca:d706:: with SMTP id o6mr3184121oig.28.1607441961968; Tue, 08 Dec 2020 07:39:21 -0800 (PST) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id l5sm2727665ooo.2.2020.12.08.07.39.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Dec 2020 07:39:20 -0800 (PST) Received: (nullmailer pid 2567594 invoked by uid 1000); Tue, 08 Dec 2020 15:39:19 -0000 Date: Tue, 8 Dec 2020 09:39:19 -0600 From: Rob Herring To: Michael Klein Subject: Re: [PATCH v3 2/3] Documentation: DT: binding documentation for regulator-poweroff Message-ID: <20201208153919.GB2539955@robh.at.kernel.org> References: <20201128103958.q6glewhhch7vtczr@gilmour> <20201207142756.17819-1-michael@fossekall.de> <20201207142756.17819-3-michael@fossekall.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201207142756.17819-3-michael@fossekall.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201208_103923_008892_470457A6 X-CRM114-Status: GOOD ( 21.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Jernej Skrabec , linux-pm@vger.kernel.org, Sebastian Reichel , Maxime Ripard , linux-kernel@vger.kernel.org, Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 07, 2020 at 03:27:55PM +0100, Michael Klein wrote: > Add devicetree binding documentation for regulator-poweroff driver. > > Signed-off-by: Michael Klein > --- > .../power/reset/regulator-poweroff.yaml | 53 +++++++++++++++++++ > 1 file changed, 53 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/reset/regulator-poweroff.yaml > > diff --git a/Documentation/devicetree/bindings/power/reset/regulator-poweroff.yaml b/Documentation/devicetree/bindings/power/reset/regulator-poweroff.yaml > new file mode 100644 > index 000000000000..8c8ce6bb031a > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/reset/regulator-poweroff.yaml > @@ -0,0 +1,53 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/power/reset/regulator-poweroff.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Force-disable power regulators to turn the power off. > + > +maintainers: > + - Michael Klein > + > +description: | > + When the power-off handler is called, one more regulators are disabled > + by calling regulator_force_disable(). If the power is still on and the > + CPU still running after a 3000ms delay, a WARN_ON(1) is emitted. WARN_ON is a Linux thing. Bindings are independent from Linux. > + > +properties: > + compatible: > + const: "regulator-poweroff" > + > + regulator-names: We already have 'regulator-name' which is something different, and *-names already has a defined usage as a companion to other properties ('foo-names' goes with 'foos'). More on this below... > + description: > + Array of regulator names > + $ref: /schemas/types.yaml#/definitions/string-array > + > + REGULATOR-supply: > + description: > + For any REGULATOR listed in regulator-names, a phandle > + to the corresponding regulator node > + $ref: /schemas/types.yaml#/definitions/phandle *-supply already has a type. > + > + timeout-ms: > + description: > + Time to wait before asserting a WARN_ON(1). If nothing is > + specified, 3000 ms is used. > + $ref: /schemas/types.yaml#/definitions/uint32 Do we really need to tune the timeout just for an error message? > + > +required: > + - compatible > + - regulator-names > + - REGULATOR-supply > + > +additionalProperties: false > + > +examples: > + - | > + regulator-poweroff { > + compatible = "regulator-poweroff"; > + regulator-names = "vcc1v2", "vcc-dram"; > + vcc1v2-supply = <®_vcc1v2>; > + vcc-dram-supply = <®_vcc_dram>; -supply names are supposed to be named based on the consumer names (e.g. LDO1 regulator supplies vcc-supply). To avoid 'regulator-names' and simplifier the driver, I'd just define fixed, known names. Something like: power1-supply power2-supply ... Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel