From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6262C433FE for ; Tue, 8 Dec 2020 19:16:34 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7720C23B78 for ; Tue, 8 Dec 2020 19:16:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7720C23B78 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=F2GUY7yaZgW1+Su94iChgWXAXG3RTQ0vYYchsipuLWk=; b=PLKnNpeU6Izd4vfWs6XDarcXu eszRob9Y0NThdgItVE2DIx5jRR5b83U/U/Qi6KIyE6GIVsSCJxIzWmONAh7mDk4n8Ulx9QJCux45Q QN5378Xj/21no5Hf9BQ6FZXtjc4JL+GO+dBXDXUkwPWEkE749+qGh16bh8kDP/vSxsHO44zXefD2p ZDutuWK7cg7fUvHdVn7/h2chqg8ZXm3cgrSckavjneRA2tgNLGS8/PUPO4wBpL+wbsmaiW45xFAF6 sAnNMBX/ShrF6bukOup2xEyXaEPUUpVj4RfqN20nkRbZLKHnzKeFefmV0j8koutXNatknK7VmoFos F/vURnrFg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmiRp-0005V6-31; Tue, 08 Dec 2020 19:14:53 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmiRm-0005Uf-2p for linux-arm-kernel@lists.infradead.org; Tue, 08 Dec 2020 19:14:50 +0000 Received: by mail-wr1-x441.google.com with SMTP id y17so7974022wrr.10 for ; Tue, 08 Dec 2020 11:14:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=REHA7EmuVy2412k5JBZlHnXSXCITuu5RQOyBaXf28o8=; b=DgXW4UZBGLPpi3lT4JKM6pKgI6mSt/dk7wglJitvXIYua+es3r0i9AvLN/NQeGaP5U 0o39PUgticPGXS/fYZNwS8crslfcVJzP5XqpbflzbNi1WIPQQkwrD8L+PyURTqOQpZXK juYMowq4SdzpKYgYEWh9mjAqdMeSmT5AuzeomKp9OBkSwKn/nhgrCcRcloOpBNFyF+LS F7QTMAtYzWvCBhMO17hlxIie6tINGAutTZqZ+iA69roa3OxdwFqTXq3aWTLNOU3Nf25h h+HiI5SvMkOHNJE2debg9Vgm+45pfSNQ7dCEr+eKCAP0z5nl66gJpg6Khb1Qiev3/hZh EtJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=REHA7EmuVy2412k5JBZlHnXSXCITuu5RQOyBaXf28o8=; b=itb5xUvGp+Y1O6y2jFzudBUioE04n3siTM5geLMnKAeoFOUyraQRlpgCy3I4nHTJNk hize2rd/vJMmMYjL6+l4u6QiiJzIOXXuN+w+74xux0MhmQs7hJm45xAfBAlSvG/SeK4k 8JC9807PonxftWIIYrmQ1m9eyM2sbBkYL4WP/yh0AIY2PkUKnCcAgYdBbF3T0limq+3d 11qBTcxfNZH457+j6tALi71X3aVzVPhXWJT0Gypv+qnakOBuZcoU5/0zmgA79eHL7MeR 5iwk8fj7mToy/vo7ygSwk680nvm6VSNZkLqLwcx5xPTouwt1Y15Y/45iJE0lVZvKjBV+ qHWQ== X-Gm-Message-State: AOAM533Wg/fVJ8Rg5T0w3kCezIT+d6yST7Jr2o5zUI3yeXndAmO/KJUV zapDYmXuhfaSkH/AHK0QCy0rJQ== X-Google-Smtp-Source: ABdhPJzMvjijXhKf6UwzlQgGLdXNiyElYjmteXjfB+clUMsCI8Qf7bumNkex70eiOtelbQWNt3aQ2A== X-Received: by 2002:a5d:51d2:: with SMTP id n18mr19894485wrv.92.1607454888755; Tue, 08 Dec 2020 11:14:48 -0800 (PST) Received: from google.com ([2a01:4b00:8523:2d03:258e:cb26:cef:a620]) by smtp.gmail.com with ESMTPSA id i16sm2846391wrx.89.2020.12.08.11.14.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Dec 2020 11:14:47 -0800 (PST) Date: Tue, 8 Dec 2020 19:14:47 +0000 From: David Brazdil To: Marc Zyngier Subject: Re: [PATCH v4 00/26] Opt-in always-on nVHE hypervisor Message-ID: <20201208191447.47idqf7n2v3hvrdg@google.com> References: <20201202184122.26046-1-dbrazdil@google.com> <160702322202.1501317.9696987088711766533.b4-ty@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <160702322202.1501317.9696987088711766533.b4-ty@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201208_141450_161139_8C3CEC4D X-CRM114-Status: GOOD ( 19.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christoph Lameter , Lorenzo Pieralisi , linux-doc@vger.kernel.org, Catalin Marinas , Jonathan Corbet , linux-kernel@vger.kernel.org, Sudeep Holla , Tejun Heo , Dennis Zhou , kernel-team@android.com, Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hey Marc, On Thu, Dec 03, 2020 at 07:23:19PM +0000, Marc Zyngier wrote: > On Wed, 2 Dec 2020 18:40:56 +0000, David Brazdil wrote: > > As we progress towards being able to keep guest state private to the > > host running nVHE hypervisor, this series allows the hypervisor to > > install itself on newly booted CPUs before the host is allowed to run > > on them. > > > > All functionality described below is opt-in, guarded by an early param > > 'kvm-arm.mode=protected'. Future patches specific to the new protected > > mode should be hidden behind the same param. > > > > [...] > > Applied to kvm-arm64/psci-relay, thanks! > > Note that although I pushed it to -next, I still need people to > eyeball it and give it some Acks. The commit-IDs below will > thus change as I apply tags, if any. > I'm looking at -next and I think the merge with Mark Rutland's el2_setup refactor didn't go as planned. The `#ifdef CONFIG_ARM64_VHE` section needs to cover everything between init_el2 and init_el2_nvhe. Currently the code falls through into VHE init when CONFIG_ARM64_VHE is not set. Here's the snippet: SYM_INNER_LABEL(init_el2, SYM_L_LOCAL) #ifdef CONFIG_ARM64_VHE /* * Check for VHE being present. x2 being non-zero indicates that we * do have VHE, and that the kernel is intended to run at EL2. */ mrs x2, id_aa64mmfr1_el1 ubfx x2, x2, #ID_AA64MMFR1_VHE_SHIFT, #4 cbz x2, init_el2_nvhe #endif // <--- THIS <... initialize VHE ...> msr elr_el2, lr mov w0, #BOOT_CPU_MODE_EL2 eret // <--- NEEDS TO MOVE HERE SYM_INNER_LABEL(init_el2_nvhe, SYM_L_LOCAL) <... initialize nVHE ...> -David _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel