From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A88DC4361B for ; Wed, 9 Dec 2020 00:45:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB4B1238E5 for ; Wed, 9 Dec 2020 00:45:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB4B1238E5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qMpfIYqFBNkEtFic3x6H80jTR6XuBYQqrIm4r3FfujY=; b=xCSwnRfzf3z2K+1FlvuKtz6VM 2ptm9QcKMusti/VIJyr1ZwYhUDnmTCPvL5Euh4G1KROr4uENq7C8uCc7NaEp50RTPGxQ57Lz8aiIl wUDvGv89OVoTRsfMAmmxh7y5ao75xacEcOkfZl2qoC4Ziy/UvDU9+Q4nPLCjqgjq3lQy9OMNE1js5 LtHrmDagkUKB61in4ybRy2dLD9/3dSEo31stnSJ8APXVqhGV4+oujYsrqwZ+NHgv8Ub4rNo/LRkcB hbBI3P0p6n2B0hgcQYHfN9YwNc8LEHRRNNXN+5LOMI1rYoIHpzXUxI6TWaAhVg47VvgU8lIkp/snF wepJ6+Mvw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmnag-0000bL-Q1; Wed, 09 Dec 2020 00:44:22 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmnad-0000aq-MJ for linux-arm-kernel@lists.infradead.org; Wed, 09 Dec 2020 00:44:20 +0000 Received: by mail-wm1-x344.google.com with SMTP id a6so17601wmc.2 for ; Tue, 08 Dec 2020 16:44:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=WBbHO055TDdHkxOg7jOYFdPzCq3mNcsnhSnfew3Y1EY=; b=gkn9GnyQglKnUhjGGYCXIKsVi5wfV6l/qEI1a2+K2hvW+PzEBba0WRfUqG5WqleEHH rYvJAfFHvVA1vSFpUDhC9St39gWYoj9oFpMSVof8etKlbdIgrXP/Fe/VJAoTRe1NW53r oINMGfzdvTBk2+JPfj2iGvrr651ssjNGtsJy4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=WBbHO055TDdHkxOg7jOYFdPzCq3mNcsnhSnfew3Y1EY=; b=hP34urqUbVDNjvC3SU48a2mtSLnjY2x8/tQW76WqU4pTnezTX1d3+UbrkPPNOt5LCM oqv3CU7W6S9kQUIBbe1TmD+MeH/b+bmk+/ixk8aqMmg+cStQdI1ULZOm+aog5ukeMSA4 vnvd63TVPHQkmy5sVBR6BRD+2R6HDqOs1q+Vxp2o//FJKXWUVURHc58bhdxrRZsK2Tv5 V53+W2gbs9H2pvvfEPVgbtxqBAGPo7lMLmSYOEcLuvt04zymy8CaVCnowsG3E4bM4DxJ CcbAN2BRsAi6jzUxOTK76DDMcZ8G368bR6cqFqF2NOhlRotvJ/OklV4KCxPrmUztRDPE snOQ== X-Gm-Message-State: AOAM531Fspv7NOqvqZehwCFcLLmESOeSat9CXuk0bHpURFPzmuz0lV36 3KdwSG+qD0stVwsuPcqOIKmEEg== X-Google-Smtp-Source: ABdhPJxLmZZZDr4AskPctoFwXO0CXDkm7krmiIzueb/sJB51n47BczDttWqZl8WpkJ2EVS9oYPgS8A== X-Received: by 2002:a7b:c308:: with SMTP id k8mr44691wmj.76.1607474658253; Tue, 08 Dec 2020 16:44:18 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id 138sm37368wma.41.2020.12.08.16.44.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Dec 2020 16:44:17 -0800 (PST) Date: Wed, 9 Dec 2020 01:44:15 +0100 From: Daniel Vetter To: Liu Ying Subject: Re: [PATCH v3 4/6] drm/atomic: Avoid unused-but-set-variable warning on for_each_old_plane_in_state Message-ID: <20201209004415.GM401619@phenom.ffwll.local> Mail-Followup-To: Liu Ying , linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, p.zabel@pengutronix.de, airlied@linux.ie, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, robh+dt@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, laurentiu.palcu@oss.nxp.com References: <1607311260-13983-1-git-send-email-victor.liu@nxp.com> <1607311260-13983-5-git-send-email-victor.liu@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1607311260-13983-5-git-send-email-victor.liu@nxp.com> X-Operating-System: Linux phenom 5.7.0-1-amd64 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201208_194419_772352_B53954B4 X-CRM114-Status: GOOD ( 17.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mripard@kernel.org, devicetree@vger.kernel.org, daniel@ffwll.ch, tzimmermann@suse.de, airlied@linux.ie, festevam@gmail.com, s.hauer@pengutronix.de, maarten.lankhorst@linux.intel.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, robh+dt@kernel.org, linux-imx@nxp.com, p.zabel@pengutronix.de, laurentiu.palcu@oss.nxp.com, shawnguo@kernel.org, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 07, 2020 at 11:20:58AM +0800, Liu Ying wrote: > Artifically use 'plane' and 'old_plane_state' to avoid 'not used' warning. > The precedent has already been set by other macros in the same file. > > Signed-off-by: Liu Ying Acked-by: Daniel Vetter I'm assuming someone will push this to drm-misc or some other tree. Should probably land sooner than later. -Daniel > --- > v2->v3: > * Add a missing blank line. > > v1->v2: > * No change. > > include/drm/drm_atomic.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h > index 54e051a..2e087d7 100644 > --- a/include/drm/drm_atomic.h > +++ b/include/drm/drm_atomic.h > @@ -888,7 +888,10 @@ void drm_state_dump(struct drm_device *dev, struct drm_printer *p); > (__i)++) \ > for_each_if ((__state)->planes[__i].ptr && \ > ((plane) = (__state)->planes[__i].ptr, \ > - (old_plane_state) = (__state)->planes[__i].old_state, 1)) > + (void)(plane) /* Only to avoid unused-but-set-variable warning */, \ > + (old_plane_state) = (__state)->planes[__i].old_state, \ > + (void)(old_plane_state) /* Only to avoid unused-but-set-variable warning */, 1)) > + > /** > * for_each_new_plane_in_state - iterate over all planes in an atomic update > * @__state: &struct drm_atomic_state pointer > -- > 2.7.4 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel