From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79BA6C433FE for ; Wed, 9 Dec 2020 09:06:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2BF7423B79 for ; Wed, 9 Dec 2020 09:06:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2BF7423B79 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=techsingularity.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4ytony6Dhddx/PZqrsfvAXEXsIYu/TCN2BBcX/g2T3I=; b=ZNGDI5nTep/Yx7KJwITSOz6PA fIMjWO1tui4YQ1EWOSHc4hOFmxT9vgHAZ9c8YQrAhwQAASx7SAHRxCkIGch99HojFaLGX0xTLgM2a KNhdD66KoLQhHS0x0oOQjqCl5ZYNLMf7Ty0Ljo93UFnYchxjvzq4a209V84GYPVL/zUEZMqVMj3ZB s17LBbG43x9WUECjTKLqcKE877oZkdaE9J9Dre0tu7dMU/V9lkPCZfk3wGpdnpDc7dw0/m06u8ilk ieJi0hv7jPOKKzH9UIC1I40bg3lzGqEyvkYsJsMBLro1X7jjutQRmQSiprqIoTeAjRm0dmck9B7+i tgZzNM1Jg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmvPP-0000ID-Dl; Wed, 09 Dec 2020 09:05:15 +0000 Received: from outbound-smtp07.blacknight.com ([46.22.139.12]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmvPM-0000HR-Eb for linux-arm-kernel@lists.infradead.org; Wed, 09 Dec 2020 09:05:13 +0000 Received: from mail.blacknight.com (pemlinmail02.blacknight.ie [81.17.254.11]) by outbound-smtp07.blacknight.com (Postfix) with ESMTPS id 262F01C3DB1 for ; Wed, 9 Dec 2020 09:05:10 +0000 (GMT) Received: (qmail 7118 invoked from network); 9 Dec 2020 09:05:09 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.22.4]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 9 Dec 2020 09:05:09 -0000 Date: Wed, 9 Dec 2020 09:05:07 +0000 From: Mel Gorman To: "Li, Aubrey" Subject: Re: [PATCH 2/4] sched/fair: Move avg_scan_cost calculations under SIS_PROP Message-ID: <20201209090507.GM3371@techsingularity.net> References: <20201208153501.1467-1-mgorman@techsingularity.net> <20201208153501.1467-3-mgorman@techsingularity.net> <3255625e-fa92-dc09-9fab-5621122f4af0@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3255625e-fa92-dc09-9fab-5621122f4af0@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201209_040512_627878_96EEC22F X-CRM114-Status: GOOD ( 10.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Barry Song , Juri Lelli , Vincent Guittot , Peter Ziljstra , LKML , Ingo Molnar , Valentin Schneider , Linux-ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 09, 2020 at 01:28:11PM +0800, Li, Aubrey wrote: > >> nr = div_u64(span_avg, avg_cost); > >> else > >> nr = 4; > >> - } > >> - > >> - time = cpu_clock(this); > >> > >> - cpumask_and(cpus, sched_domain_span(sd), p->cpus_ptr); > >> + time = cpu_clock(this); > >> + } > >> > >> for_each_cpu_wrap(cpu, cpus, target) { > >> if (!--nr) > > nr is the key of this throttling mechanism, need to be placed under sched_feat(SIS_PROP) as well. > It isn't necessary as nr in initialised to INT_MAX if !SIS_PROP. -- Mel Gorman SUSE Labs _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel