From: Rob Herring <robh@kernel.org>
To: Jim Quinlan <james.quinlan@broadcom.com>
Cc: "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
linux-pci@vger.kernel.org,
open list <linux-kernel@vger.kernel.org>,
broonie@kernel.org, bcm-kernel-feedback-list@broadcom.com,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-rpi-kernel@lists.infradead.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Subject: Re: [PATCH v2 1/6] dt-bindings: PCI: Add bindings for Brcmstb EP voltage regulators
Date: Wed, 9 Dec 2020 08:01:22 -0600 [thread overview]
Message-ID: <20201209140122.GA331678@robh.at.kernel.org> (raw)
In-Reply-To: <20201130211145.3012-2-james.quinlan@broadcom.com>
On Mon, Nov 30, 2020 at 04:11:38PM -0500, Jim Quinlan wrote:
> Quite similar to the regulator bindings found in "rockchip-pcie-host.txt",
> this allows optional regulators to be attached and controlled by the
> PCIe RC driver.
>
> Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com>
> ---
> .../devicetree/bindings/pci/brcm,stb-pcie.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> index 807694b4f41f..baacc3d7ec87 100644
> --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> @@ -85,6 +85,18 @@ properties:
> minItems: 1
> maxItems: 3
>
> + vpcie12v-supply:
> + description: 12v regulator phandle for the endpoint device
> +
> + vpcie3v3-supply:
> + description: 3.3v regulator phandle for the endpoint device
12V and 3.3V are standard slot supplies, can you add them to
pci-bus.yaml. Then some day maybe we can have common slot handling code.
With that, here you just need:
vpcie3v3-supply: true
> +
> + vpcie1v8-supply:
> + description: 1.8v regulator phandle for the endpoint device
> +
> + vpcie0v9-supply:
> + description: 0.9v regulator phandle for the endpoint device
These are not standard. They go to a soldered down device or
non-standard connector? For the former, the device should really be
described in DT and the supplies added there.
Mini PCIe connector also has 1.5V supply.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-09 14:02 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 21:11 [PATCH v2 0/6] brcmstb: add EP regulators and panic handler Jim Quinlan
2020-11-30 21:11 ` [PATCH v2 1/6] dt-bindings: PCI: Add bindings for Brcmstb EP voltage regulators Jim Quinlan
2020-12-09 14:01 ` Rob Herring [this message]
2021-01-04 22:12 ` Jim Quinlan
2021-01-05 14:01 ` Mark Brown
2021-01-05 15:09 ` Jim Quinlan
2021-01-05 15:33 ` Mark Brown
2021-01-07 22:31 ` Rob Herring
2020-11-30 21:11 ` [PATCH v2 2/6] PCI: brcmstb: Add control of EP voltage regulator(s) Jim Quinlan
2020-11-30 21:32 ` Florian Fainelli
2020-11-30 21:11 ` [PATCH v2 3/6] PCI: brcmstb: Do not turn off regulators if EP can wake up Jim Quinlan
2020-11-30 21:29 ` Florian Fainelli
2020-11-30 21:11 ` [PATCH v2 4/6] PCI: brcmstb: Give 7216 SOCs their own config type Jim Quinlan
2020-11-30 21:24 ` Florian Fainelli
2020-11-30 21:11 ` [PATCH v2 5/6] PCI: brcmstb: Add panic/die handler to RC driver Jim Quinlan
2020-11-30 21:28 ` Florian Fainelli
2020-12-01 18:05 ` Bjorn Helgaas
2020-12-01 20:12 ` Jim Quinlan
2021-01-06 19:19 ` Bjorn Helgaas
[not found] ` <CA+-6iNzARUT63Mv7qFzk_g5wep4v6aPuN8f8yjQcgozVcKhVTw@mail.gmail.com>
2021-01-06 19:57 ` Jim Quinlan
2021-01-06 23:11 ` Bjorn Helgaas
2020-11-30 21:11 ` [PATCH v2 6/6] PCI: brcmstb: check return value of clk_prepare_enable() Jim Quinlan
2020-11-30 21:24 ` Florian Fainelli
2021-01-06 19:19 ` [PATCH v2 0/6] brcmstb: add EP regulators and panic handler Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201209140122.GA331678@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=james.quinlan@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=nsaenzjulienne@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).