From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24113C4361B for ; Wed, 9 Dec 2020 14:39:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C35D7227C3 for ; Wed, 9 Dec 2020 14:39:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C35D7227C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=techsingularity.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BGB3JZIsWZOhDpPpUO6CYw5hOGexM6PswjQbfrS62pc=; b=FIaOjZY95q7YHBFXleFX3siH4 iT3KB9pE1NhFizkw8ofotr27J75uNj4KP3Sv69i9FFdqyJXQDEZuxHYP+YFkvlSwX1EhS7t4DRn3F vxLkOpX8//V7JuGRiXfhCxVcfWdEkGL7EoHWp9eGO8LwUkYiu/+bC2EA7l7O77lT2mDVuNwurQ0C7 elEqa38pqFtS3z3hUoq3bl6ZchtQqAz+tDIw4aOlcl6hQjWC6csh0qwoLj73JPYkVn/vWk0bCf4E1 VCuq/kKPtYxSiDBbkLYJUu4eYyTK2Q48mxTJpsWL6huQCz+YC+eHFM6aU1Gm5EFWUnWaFbGMX5ES5 4O6KDjx2Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kn0bJ-0005vb-Sv; Wed, 09 Dec 2020 14:37:53 +0000 Received: from outbound-smtp61.blacknight.com ([46.22.136.249]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kn0bH-0005uh-BF for linux-arm-kernel@lists.infradead.org; Wed, 09 Dec 2020 14:37:52 +0000 Received: from mail.blacknight.com (pemlinmail06.blacknight.ie [81.17.255.152]) by outbound-smtp61.blacknight.com (Postfix) with ESMTPS id E6852FADBD for ; Wed, 9 Dec 2020 14:37:49 +0000 (GMT) Received: (qmail 14589 invoked from network); 9 Dec 2020 14:37:49 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.22.4]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 9 Dec 2020 14:37:49 -0000 Date: Wed, 9 Dec 2020 14:37:48 +0000 From: Mel Gorman To: Peter Ziljstra , Ingo Molnar , LKML Subject: Re: [PATCH 0/4] Reduce scanning of runqueues in select_idle_sibling Message-ID: <20201209143748.GP3371@techsingularity.net> References: <20201208153501.1467-1-mgorman@techsingularity.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201208153501.1467-1-mgorman@techsingularity.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201209_093751_499345_762F921A X-CRM114-Status: GOOD ( 11.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Barry Song , Juri Lelli , Vincent Guittot , Aubrey Li , Valentin Schneider , Linux-ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 08, 2020 at 03:34:57PM +0000, Mel Gorman wrote: > Changelog since v1 > o Drop single-pass patch (vincent) > o Scope variables used for SIS_AVG_CPU (dietmar) > o Remove redundant assignment (dietmar > > This reduces the amount of runqueue scanning in select_idle_sibling in > the worst case. > > Patch 1 removes SIS_AVG_CPU because it's unused. > > Patch 2 moves all SIS_PROP-related calculations under SIS_PROP > > Patch 3 improves the hit rate of p->recent_used_cpu to reduce the amount > of scanning. It should be relatively uncontroversial > > Patch 4 returns an idle candidate if one is found while scanning for a > free core. > Any other objections to the series? Vincent marked 1, 3 and 4 as reviewed. While patch 2 had some mild cosmetic concerns, I think the version and how it treats SIS_PROP is fine as it is to keep it functionally equivalent to !SIS_PROP and without adding too many SIS_PROP checks. -- Mel Gorman SUSE Labs _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel