From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 865DDC4361B for ; Wed, 9 Dec 2020 20:35:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 36D7F22C7B for ; Wed, 9 Dec 2020 20:35:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36D7F22C7B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=fossekall.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EcpYhdiP3IkMdcdbu9ZMDyS7gtuaPAfFRGYvX6mkbpo=; b=rroDrLOPaWrrn0EMvxW1zwdjV 73DuiSWqEuVjBvMqvOUeDS5dzwdFoK6dzXZMTio0J/WqClHsEFlGCeeBwO4LafYAqznmQrwR2RWbX YM9vvAescs3eq9DGkZKCdUNd4hYMvMUs183MId3gAtlZGe4a6O0PUCc4wQlFxvmFpvVsxJOqypa9J esYhvYE1weZqJ28FCuL0nItoBQ/Htp68cOT1OrrQ6RDhXFdJo2w35XqaUu5+D/mT81UEEb9zVhUoM JFAAl3ipY/7ZNmsU3wbMUGIN+97Wre6yTbUOl+5e9fS/pUaF4a1480BPPBsf177ILlwDSOqtKM/gy d/20SFAGg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kn6AC-00065M-BQ; Wed, 09 Dec 2020 20:34:16 +0000 Received: from mo4-p01-ob.smtp.rzone.de ([85.215.255.54]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kn6A5-00060W-4k for linux-arm-kernel@lists.infradead.org; Wed, 09 Dec 2020 20:34:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1607546044; s=strato-dkim-0002; d=fossekall.de; h=In-Reply-To:References:Message-ID:Subject:Cc:To:From:Date:From: Subject:Sender; bh=NW8oMEoZejP9UrMPWLz8vivLgh1kG3lHr/CL5F7qKGU=; b=Zn7FKLNu2BlIHeTMSikf4Oddhw59KZuj+p+c6O8+N+ZQFVEX4hQY104RQaSagaYYVt yf3MdXYtHnOksaIWEwYKJ2T0fRmhbsAP2cboVpAdcexGNDpFWVomYpD32trt1iXs1JCa WMvoPKH9IXkoQnSnGv3PBMGdRhogsxK2gUyodsmjr1nw5ftzSzcq20AA/LejGvQGF/0k Lnob+EhK5luXiWaeko3UgddPJzTPDwCAG3N1wNgAMApO0Pf03YDuUCZyFsOGvPv+Et9i Y9V6VVAa4EtXaAy0g+MBeAzF4bx8bavyOswPxj3SovdIACUV1UxJKRjSrGdZEgrHim3c qD6g== X-RZG-AUTH: ":O2kGeEG7b/pS1EzgE2y7nF0STYsSLflpbjNKxx7cGrBOdI6BL9pkS3QW19mO7I+/JwRspuzJFZuRzQ==" X-RZG-CLASS-ID: mo00 Received: from aerfugl by smtp.strato.de (RZmta 47.6.2 AUTH) with ESMTPSA id e07b38wB9KY2Aqh (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Wed, 9 Dec 2020 21:34:02 +0100 (CET) Received: from koltrast.a98shuttle.de ([192.168.1.27] helo=a98shuttle.de) by aerfugl with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1kn69x-00077t-G0; Wed, 09 Dec 2020 21:34:01 +0100 Date: Wed, 9 Dec 2020 21:34:00 +0100 From: Michael Klein To: Maxime Ripard Subject: Re: [PATCH v3 1/3] power: reset: new driver regulator-poweroff Message-ID: <20201209203400.GA108307@a98shuttle.de> References: <20201128103958.q6glewhhch7vtczr@gilmour> <20201207142756.17819-1-michael@fossekall.de> <20201207142756.17819-2-michael@fossekall.de> <20201208101052.ecq2hbixxi45h4mr@gilmour> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201208101052.ecq2hbixxi45h4mr@gilmour> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201209_153409_456329_C293DF27 X-CRM114-Status: GOOD ( 25.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Jernej Skrabec , linux-pm@vger.kernel.org, Sebastian Reichel , linux-kernel@vger.kernel.org, Chen-Yu Tsai , Rob Herring , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 08, 2020 at 11:10:52AM +0100, Maxime Ripard wrote: >On Mon, Dec 07, 2020 at 03:27:54PM +0100, Michael Klein wrote: >> This driver registers a pm_power_off function to disable a set of >> regulators defined in the devicetree to turn off the board. >> >> Signed-off-by: Michael Klein >> --- >> drivers/power/reset/Kconfig | 7 ++ >> drivers/power/reset/Makefile | 1 + >> drivers/power/reset/regulator-poweroff.c | 107 +++++++++++++++++++++++ >> 3 files changed, 115 insertions(+) >> create mode 100644 drivers/power/reset/regulator-poweroff.c >> >> diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig >> index d55b3727e00e..ae6cb7b0bd4d 100644 >> --- a/drivers/power/reset/Kconfig >> +++ b/drivers/power/reset/Kconfig >> @@ -177,6 +177,13 @@ config POWER_RESET_QNAP >> >> Say Y if you have a QNAP NAS. >> >> +config POWER_RESET_REGULATOR >> + bool "Regulator subsystem power-off driver" >> + depends on OF && REGULATOR >> + help >> + This driver supports turning off your board by disabling a set >> + of regulators defined in the devicetree. >> + >> config POWER_RESET_RESTART >> bool "Restart power-off driver" >> help >> diff --git a/drivers/power/reset/Makefile b/drivers/power/reset/Makefile >> index c51eceba9ea3..9dc49d3a57ff 100644 >> --- a/drivers/power/reset/Makefile >> +++ b/drivers/power/reset/Makefile >> @@ -19,6 +19,7 @@ obj-$(CONFIG_POWER_RESET_OCELOT_RESET) += ocelot-reset.o >> obj-$(CONFIG_POWER_RESET_PIIX4_POWEROFF) += piix4-poweroff.o >> obj-$(CONFIG_POWER_RESET_LTC2952) += ltc2952-poweroff.o >> obj-$(CONFIG_POWER_RESET_QNAP) += qnap-poweroff.o >> +obj-$(CONFIG_POWER_RESET_REGULATOR) += regulator-poweroff.o >> obj-$(CONFIG_POWER_RESET_RESTART) += restart-poweroff.o >> obj-$(CONFIG_POWER_RESET_ST) += st-poweroff.o >> obj-$(CONFIG_POWER_RESET_VERSATILE) += arm-versatile-reboot.o >> diff --git a/drivers/power/reset/regulator-poweroff.c b/drivers/power/reset/regulator-poweroff.c >> new file mode 100644 >> index 000000000000..df2ca4fdcc49 >> --- /dev/null >> +++ b/drivers/power/reset/regulator-poweroff.c >> @@ -0,0 +1,107 @@ >> +// SPDX-License-Identifier: GPL-2.0-only >> +/* >> + * Force-disables a regulator to power down a device >> + * >> + * Michael Klein >> + * >> + * Copyright (C) 2020 Michael Klein >> + * >> + * Based on the gpio-poweroff driver. >> + */ >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +#define DEFAULT_TIMEOUT_MS 3000 >> + >> +/* >> + * Hold configuration here, cannot be more than one instance of the driver >> + * since pm_power_off itself is global. >> + */ >> +static struct regulator **poweroff_regulators; >> +static u32 timeout = DEFAULT_TIMEOUT_MS; >> + >> +static void regulator_poweroff_do_poweroff(void) >> +{ >> + struct regulator **it; >> + >> + if (poweroff_regulators) >> + for (it = poweroff_regulators; *it; ++it) >> + if (regulator_is_enabled(*it)) >> + regulator_force_disable(*it); >> + >> + /* give it some time */ >> + mdelay(timeout); >> + >> + WARN_ON(1); >> +} >> + >> +static int regulator_poweroff_probe(struct platform_device *pdev) >> +{ >> + int count; >> + const char *name; >> + struct regulator **it; >> + struct property *prop; >> + struct device_node *node = pdev->dev.of_node; >> + >> + /* If a pm_power_off function has already been added, leave it alone */ >> + if (pm_power_off != NULL) { >> + dev_err(&pdev->dev, >> + "%s: pm_power_off function already registered\n", >> + __func__); >> + return -EBUSY; >> + } >> + >> + count = of_property_count_strings(node, "regulator-names"); >> + if (count <= 0) >> + return -ENOENT; >> + >> + poweroff_regulators = devm_kcalloc(&pdev->dev, count + 1, >> + sizeof(struct regulator *), GFP_KERNEL); >> + >> + it = poweroff_regulators; >> + of_property_for_each_string(node, "regulator-names", prop, name) { >> + *it = devm_regulator_get(&pdev->dev, name); >> + if (IS_ERR(*it)) >> + return PTR_ERR(*it); >> + it++; >> + } >> + >> + of_property_read_u32(node, "timeout-ms", &timeout); >> + >> + pm_power_off = ®ulator_poweroff_do_poweroff; >> + return 0; >> +} >> + >> +static int regulator_poweroff_remove(__maybe_unused struct platform_device *pdev) >> +{ >> + if (pm_power_off == ®ulator_poweroff_do_poweroff) >> + pm_power_off = NULL; >> + >> + return 0; >> +} >> + >> +static const struct of_device_id of_regulator_poweroff_match[] = { >> + { .compatible = "regulator-poweroff", }, >> + {}, >> +}; >> + >> +static struct platform_driver regulator_poweroff_driver = { >> + .probe = regulator_poweroff_probe, >> + .remove = regulator_poweroff_remove, >> + .driver = { >> + .name = "poweroff-regulator", >> + .of_match_table = of_regulator_poweroff_match, >> + }, >> +}; >> + >> +module_platform_driver(regulator_poweroff_driver); > >Since this can't be compiled as a module, you can use >module_platform_driver_probe instead. actually no, as platform_driver_probe() does not support deferred probing and the regulator might not be available during regulator_poweroff_probe() yet: # dmesg | grep poweroff [ 0.788135] poweroff-regulator poweroff: probe deferral not supported -- Michael _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel