From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3E91C4361B for ; Thu, 10 Dec 2020 09:58:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7CE6D23D3C for ; Thu, 10 Dec 2020 09:58:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7CE6D23D3C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Szsge1nmhbfTqP1blO6FB4j2i6p/muoomwDGGu7UU8E=; b=ONc7TZsAJmQowprX53aPenhC4 V7+qVp2GId4hAu3UCK4Yy9dE8K1nFQlx7aXadv3jFtDQtv7hBZTPE5QGJfZPJ8j92Stc9JR6VlvG9 tFIhHpqAWrH66RSnU2/R7ByPxspYCqbDVJNa05TnKKemtV7+Z/XSaUsHa8wZIVOgu47sW3f3LbgZm ykdMpH+OUrYcpI4Rll5BJEd7EB/w4QyTu7LGwX/bDI663CvG+2KKrKA4+x6plBeKqDk21wPA1mrNt giG3oGkwQ5uEh7h4C4/ZpYLz7ohMYvPPCtsCpbHxySf/b9kwsKPV9lUgtATxsTCN2mzUsiTDPUQ5m QfINDWXAQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1knIhP-0002V6-OW; Thu, 10 Dec 2020 09:57:23 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1knIhM-0002UE-Md for linux-arm-kernel@lists.infradead.org; Thu, 10 Dec 2020 09:57:21 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 64CE431B; Thu, 10 Dec 2020 01:57:16 -0800 (PST) Received: from localhost (unknown [10.1.198.32]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0527D3F718; Thu, 10 Dec 2020 01:57:15 -0800 (PST) Date: Thu, 10 Dec 2020 09:57:14 +0000 From: Ionela Voinescu To: Viresh Kumar Subject: Re: [PATCH] arm64: topology: Drop the useless update to per-cpu cycles Message-ID: <20201210095714.GA13331@arm.com> References: <7a171f710cdc0f808a2bfbd7db839c0d265527e7.1607579234.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7a171f710cdc0f808a2bfbd7db839c0d265527e7.1607579234.git.viresh.kumar@linaro.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201210_045720_804197_B7F332CD X-CRM114-Status: GOOD ( 17.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vincent Guittot , Catalin Marinas , linux-kernel@vger.kernel.org, Sudeep Holla , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thursday 10 Dec 2020 at 11:17:40 (+0530), Viresh Kumar wrote: > The previous call to update_freq_counters_refs() has already updated the > per-cpu variables, don't overwrite them with the same value again. > > Fixes: 4b9cf23c179a ("arm64: wrap and generalise counter read functions") > Signed-off-by: Viresh Kumar > --- > arch/arm64/kernel/topology.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/arch/arm64/kernel/topology.c b/arch/arm64/kernel/topology.c > index c8308befdb1e..f6faa697e83e 100644 > --- a/arch/arm64/kernel/topology.c > +++ b/arch/arm64/kernel/topology.c > @@ -314,7 +314,7 @@ void topology_scale_freq_tick(void) > > if (unlikely(core_cnt <= prev_core_cnt || > const_cnt <= prev_const_cnt)) > - goto store_and_exit; > + return; > > /* > * /\core arch_max_freq_scale > @@ -331,10 +331,6 @@ void topology_scale_freq_tick(void) > > scale = min_t(unsigned long, scale, SCHED_CAPACITY_SCALE); > this_cpu_write(freq_scale, (unsigned long)scale); > - > -store_and_exit: > - this_cpu_write(arch_core_cycles_prev, core_cnt); > - this_cpu_write(arch_const_cycles_prev, const_cnt); > } Right, no need for this anymore! Reviewed-by: Ionela Voinescu Thank you for the fix, Ionela. > > #ifdef CONFIG_ACPI_CPPC_LIB > -- > 2.25.0.rc1.19.g042ed3e048af > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel