From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 509EAC433FE for ; Thu, 10 Dec 2020 14:17:34 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E3B1823C81 for ; Thu, 10 Dec 2020 14:17:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E3B1823C81 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=f4nOllB/5Dae7ZW9gU6sL3Dx6tTcegDy2tl/5BPj0Hw=; b=wgz4I3/Hlj5hKjD/sM7MIM209 fA4q/tneMeeDuzTJzSF3IFQQTMaPRyn5A+CtZdSWMWOK4ewQr5nb/v7CtYOfgwM0NNL3NIgvrXk5I kRWYrWsSVqUbuoS+TbAJWlOtjqpNDK/m7qVT8v1m15+83GJLiyNBhz8GJM4DJmQjxpXNs6RKJ8ycH QaewE65OSYuHe+kDFScE1kcs9+HcP3ir5fmn48aiVOJXzU6C8nw0HopAbfLvlPt/R9BVvW5T/y6g7 3GtwD3NfWEKosYtT5MaI401hIdxjiAMC2S5gTq7jvrrpDhbo2I/mVsWmDvJWPvwr6pvT+Sz6oqaKe FYxRXGfWA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1knMjy-0002qc-QW; Thu, 10 Dec 2020 14:16:18 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1knMjw-0002pp-LD for linux-arm-kernel@lists.infradead.org; Thu, 10 Dec 2020 14:16:17 +0000 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1knMjq-00BEUo-5O; Thu, 10 Dec 2020 15:16:10 +0100 Date: Thu, 10 Dec 2020 15:16:10 +0100 From: Andrew Lunn To: Steen Hegelund Subject: Re: [PATCH v9 3/4] phy: Add Sparx5 ethernet serdes PHY driver Message-ID: <20201210141610.GG2638572@lunn.ch> References: <20201207121345.3818234-1-steen.hegelund@microchip.com> <20201207121345.3818234-4-steen.hegelund@microchip.com> <20201210021134.GD2638572@lunn.ch> <20201210125706.saub7c2rarifhbx4@mchp-dev-shegelun> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201210125706.saub7c2rarifhbx4@mchp-dev-shegelun> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201210_091616_729637_287CD569 X-CRM114-Status: GOOD ( 12.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bjarni Jonasson , Alexandre Belloni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , Vinod Koul , linux-arm-kernel@lists.infradead.org, Microchip UNG Driver List , Lars Povlsen Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > > So why are returning link up information? > > Yes that was a bit of a hijacking of the function. I will remove that. > I also removed the dependency on this behaviour in the client driver in the > meantime. > > I think a status function on the generic phy would be useful, but I will > take that as separate issue. In this context of an Ethernet SERDES, do you actually need it? You would normally look at the PCS link status to determine if the link is up. But it is useful debug information. If the PCS is down, but the PHY indicates up, you can guess you have a protocol misconfiguration. What exactly does link at this level mean? And thinking of the wider uses of the PHY subsystem, what would link mean at this level for SATA, PCIe, USB? Don't these all have some protocol level above similar to Ethernet PCS which is the real determiner of link? Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel