From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01877C4361B for ; Thu, 10 Dec 2020 15:01:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95D9D23109 for ; Thu, 10 Dec 2020 15:01:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95D9D23109 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bZvG3FU0Lama7tV0BAsdHb797Zj90VA8CgVJ7+Ddslo=; b=2NQchxxKbaSqM/GssZrGXUH3u EUx5CrUeHJO/HRxj/sC3f4acWNrPWztnHcu+jgdOt02iBdMqh6SdVHyEJr1GZSZJIkzfeAP96SYVu DQWB0Xd9pz65vIEQfnbKUi+VRQt1xCKLs6d8+S/eMvM/IudgAw0s++yfGzZJP3OpVC1Xzf0dXMkMH qDSSDlbK1rodoje66LlIGdWeNSSGDq87l3ACIAsTcHVt8SEV7zowq8JuqYAf36eGJZo1m4ANWrebF eJhFu02h1sFH314pTWEJDcKxc0VtRdFRjAkBt/VX1WHwzCHlzGXKWMeJHlqOGGfq4CrkGsE3ndmGr WE42dpMzA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1knNQG-0000JT-EV; Thu, 10 Dec 2020 15:00:00 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1knNPv-0000Ao-P2 for linux-arm-kernel@lists.infradead.org; Thu, 10 Dec 2020 14:59:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1607612379; x=1639148379; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=UqMkvKL7D8SiD3dwz7dJFaadhU8wN/9oUbsLA7y6BBs=; b=jYgNVoVzLXieLfjrCu8IxEq4QWI2GYb3fPQ2Om0d6ySkP6qa5liy6Ti8 QF6GgwPS1W2bxMGfTDl0F1jgLe+Owp9M8lF28XHAII+bKh/2nmlsWPedr 29+9fnvKfceHtQ1y/u3Q5zAFLlGopyYFXlYaUsmzeVlsN/LjWVjKlt/nG XAyVhacfCyCyplXyO2abZt//4jMsEO0Y8Iw9doUg76xg7G5WlLXId1A58 VoDYt6eceYCiG2YJp3R7pKbhcAWkYqFrFrP5TdlrGfyToxsDQNSlVfNx7 oidsK4DC/cC+Im5PyBV/eM664Eyv78GRi/xn9FgXdRCr9NyJZAdCwAw7E A==; IronPort-SDR: R3MJaP3nvzHZiidlIW4RrQ7dWRWphe6WNKjns6lRGwVl67uDBH1GvIQ5YmIHTkqYmUfE0wRLDc kInbCicGpSSFFjeHQxGlInx6cNvrsz64ClS3jGpWs25RVDGkvIJVBNPWsxq7rGt4S5GQW+RyiU VdlKiwdO1k5LNzChrE6WPp2SPJcYlzMbGg2Qe2vc3GbnLUw2ZBEcwusVYF3KIF7I+UCn5dtLE8 iu08kAFZUgviptzKSklFTEpjOo8b7wZhgJpaf6T8Zbi+gazz1XPtmj1TPxkLZQMbImhyZaPD2A T58= X-IronPort-AV: E=Sophos;i="5.78,408,1599548400"; d="scan'208";a="96633051" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa4.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 10 Dec 2020 07:59:37 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Thu, 10 Dec 2020 07:59:37 -0700 Received: from localhost (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.1979.3 via Frontend Transport; Thu, 10 Dec 2020 07:59:36 -0700 Date: Thu, 10 Dec 2020 15:59:35 +0100 From: Steen Hegelund To: Andrew Lunn Subject: Re: [PATCH v9 3/4] phy: Add Sparx5 ethernet serdes PHY driver Message-ID: <20201210145935.see4n6csnomsl2rx@mchp-dev-shegelun> References: <20201207121345.3818234-1-steen.hegelund@microchip.com> <20201207121345.3818234-4-steen.hegelund@microchip.com> <20201210021134.GD2638572@lunn.ch> <20201210125706.saub7c2rarifhbx4@mchp-dev-shegelun> <20201210141610.GG2638572@lunn.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201210141610.GG2638572@lunn.ch> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201210_095940_051280_30C7F25F X-CRM114-Status: GOOD ( 15.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bjarni Jonasson , Alexandre Belloni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , Vinod Koul , linux-arm-kernel@lists.infradead.org, Microchip UNG Driver List , Lars Povlsen Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10.12.2020 15:16, Andrew Lunn wrote: >EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > >> > So why are returning link up information? >> >> Yes that was a bit of a hijacking of the function. I will remove that. >> I also removed the dependency on this behaviour in the client driver in the >> meantime. >> >> I think a status function on the generic phy would be useful, but I will >> take that as separate issue. > >In this context of an Ethernet SERDES, do you actually need it? You >would normally look at the PCS link status to determine if the link is >up. But it is useful debug information. If the PCS is down, but the >PHY indicates up, you can guess you have a protocol misconfiguration. Yes - you are probably right about that. I have been exposing this via a procfs interface during the development phase, and it was really useful to have, to track down the origin of the problem in certain situations. But on a system level, the PCS link would have the final say anyway. > >What exactly does link at this level mean? And thinking of the wider >uses of the PHY subsystem, what would link mean at this level for >SATA, PCIe, USB? Don't these all have some protocol level above >similar to Ethernet PCS which is the real determiner of link? Yes - I think this is really only a debug feature. No need to force this on the other PHY categories. > > Andrew Thanks for your comments, Andrew. BR Steen --------------------------------------- Steen Hegelund steen.hegelund@microchip.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel